diff --git a/dp/wifi3.0/dp_ipa.c b/dp/wifi3.0/dp_ipa.c index da83669020f0..5eef588f9ca7 100644 --- a/dp/wifi3.0/dp_ipa.c +++ b/dp/wifi3.0/dp_ipa.c @@ -755,6 +755,7 @@ QDF_STATUS dp_ipa_set_doorbell_paddr(struct cdp_soc_t *soc_hdl, uint8_t pdev_id) soc->reo_dest_ring[IPA_REO_DEST_RING_IDX].hal_srng; uint32_t tx_comp_doorbell_dmaaddr; uint32_t rx_ready_doorbell_dmaaddr; + int ret = 0; if (!pdev) { dp_err("Invalid instance"); @@ -773,13 +774,19 @@ QDF_STATUS dp_ipa_set_doorbell_paddr(struct cdp_soc_t *soc_hdl, uint8_t pdev_id) ioremap(ipa_res->tx_comp_doorbell_paddr, 4); if (qdf_mem_smmu_s1_enabled(soc->osdev)) { - pld_smmu_map(soc->osdev->dev, ipa_res->tx_comp_doorbell_paddr, - &tx_comp_doorbell_dmaaddr, sizeof(uint32_t)); + ret = pld_smmu_map(soc->osdev->dev, + ipa_res->tx_comp_doorbell_paddr, + &tx_comp_doorbell_dmaaddr, + sizeof(uint32_t)); ipa_res->tx_comp_doorbell_paddr = tx_comp_doorbell_dmaaddr; + qdf_assert_always(!ret); - pld_smmu_map(soc->osdev->dev, ipa_res->rx_ready_doorbell_paddr, - &rx_ready_doorbell_dmaaddr, sizeof(uint32_t)); + ret = pld_smmu_map(soc->osdev->dev, + ipa_res->rx_ready_doorbell_paddr, + &rx_ready_doorbell_dmaaddr, + sizeof(uint32_t)); ipa_res->rx_ready_doorbell_paddr = rx_ready_doorbell_dmaaddr; + qdf_assert_always(!ret); } hal_srng_dst_set_hp_paddr(wbm_srng, ipa_res->tx_comp_doorbell_paddr); @@ -1702,14 +1709,12 @@ QDF_STATUS dp_ipa_cleanup(struct cdp_soc_t *soc_hdl, uint8_t pdev_id, ret = pld_smmu_unmap(soc->osdev->dev, ipa_res->rx_ready_doorbell_paddr, sizeof(uint32_t)); - if (ret) - dp_err_rl("IPA RX DB smmu unmap failed"); + qdf_assert_always(!ret); ret = pld_smmu_unmap(soc->osdev->dev, ipa_res->tx_comp_doorbell_paddr, sizeof(uint32_t)); - if (ret) - dp_err_rl("IPA TX DB smmu unmap failed"); + qdf_assert_always(!ret); } exit: