mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-28 02:32:09 -04:00
net: add a core netdev->rx_dropped counter
In various situations, a device provides a packet to our stack and we
drop it before it enters protocol stack :
- softnet backlog full (accounted in /proc/net/softnet_stat)
- bad vlan tag (not accounted)
- unknown/unregistered protocol (not accounted)
We can handle a per-device counter of such dropped frames at core level,
and automatically adds it to the device provided stats (rx_dropped), so
that standard tools can be used (ifconfig, ip link, cat /proc/net/dev)
This is a generalization of commit 8990f468a (net: rx_dropped
accounting), thus reverting it.
Signed-off-by: Eric Dumazet <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
This commit is contained in:
parent
a00eac0c45
commit
caf586e5f2
11 changed files with 26 additions and 34 deletions
|
|
@ -25,7 +25,6 @@ struct vlan_priority_tci_mapping {
|
|||
* @rx_multicast: number of received multicast packets
|
||||
* @syncp: synchronization point for 64bit counters
|
||||
* @rx_errors: number of errors
|
||||
* @rx_dropped: number of dropped packets
|
||||
*/
|
||||
struct vlan_rx_stats {
|
||||
u64 rx_packets;
|
||||
|
|
@ -33,7 +32,6 @@ struct vlan_rx_stats {
|
|||
u64 rx_multicast;
|
||||
struct u64_stats_sync syncp;
|
||||
unsigned long rx_errors;
|
||||
unsigned long rx_dropped;
|
||||
};
|
||||
|
||||
/**
|
||||
|
|
|
|||
|
|
@ -33,6 +33,7 @@ int __vlan_hwaccel_rx(struct sk_buff *skb, struct vlan_group *grp,
|
|||
return polling ? netif_receive_skb(skb) : netif_rx(skb);
|
||||
|
||||
drop:
|
||||
atomic_long_inc(&skb->dev->rx_dropped);
|
||||
dev_kfree_skb_any(skb);
|
||||
return NET_RX_DROP;
|
||||
}
|
||||
|
|
@ -123,6 +124,7 @@ vlan_gro_common(struct napi_struct *napi, struct vlan_group *grp,
|
|||
return dev_gro_receive(napi, skb);
|
||||
|
||||
drop:
|
||||
atomic_long_inc(&skb->dev->rx_dropped);
|
||||
return GRO_DROP;
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -225,16 +225,15 @@ int vlan_skb_recv(struct sk_buff *skb, struct net_device *dev,
|
|||
}
|
||||
}
|
||||
|
||||
if (unlikely(netif_rx(skb) == NET_RX_DROP)) {
|
||||
if (rx_stats)
|
||||
rx_stats->rx_dropped++;
|
||||
}
|
||||
netif_rx(skb);
|
||||
|
||||
rcu_read_unlock();
|
||||
return NET_RX_SUCCESS;
|
||||
|
||||
err_unlock:
|
||||
rcu_read_unlock();
|
||||
err_free:
|
||||
atomic_long_inc(&dev->rx_dropped);
|
||||
kfree_skb(skb);
|
||||
return NET_RX_DROP;
|
||||
}
|
||||
|
|
@ -846,15 +845,13 @@ static struct rtnl_link_stats64 *vlan_dev_get_stats64(struct net_device *dev, st
|
|||
accum.rx_packets += rxpackets;
|
||||
accum.rx_bytes += rxbytes;
|
||||
accum.rx_multicast += rxmulticast;
|
||||
/* rx_errors, rx_dropped are ulong, not protected by syncp */
|
||||
/* rx_errors is ulong, not protected by syncp */
|
||||
accum.rx_errors += p->rx_errors;
|
||||
accum.rx_dropped += p->rx_dropped;
|
||||
}
|
||||
stats->rx_packets = accum.rx_packets;
|
||||
stats->rx_bytes = accum.rx_bytes;
|
||||
stats->rx_errors = accum.rx_errors;
|
||||
stats->multicast = accum.rx_multicast;
|
||||
stats->rx_dropped = accum.rx_dropped;
|
||||
}
|
||||
return stats;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue