From cb598fd644d86239829181e0677fe4cf0b76a5cd Mon Sep 17 00:00:00 2001
From: Jeff Johnson <jjohnson@codeaurora.org>
Date: Mon, 29 Oct 2018 10:09:07 -0700
Subject: [PATCH] qcacld-3.0: Refactor WE_CLEAR_STATS processing

One of the HDD functions with the highest cyclomatic complexity is
__iw_setint_getnone(). The handing of WE_CLEAR_STATS has a complexity
greater than 1, so refactor that logic into a separate function to
help reduce the complexity of __iw_setint_getnone().

Change-Id: I51e72ccf83a6b63792c17d6c65daca6571ef21bb
CRs-Fixed: 2341122
---
 core/hdd/src/wlan_hdd_wext.c | 55 ++++++++++++++++++++----------------
 1 file changed, 30 insertions(+), 25 deletions(-)

diff --git a/core/hdd/src/wlan_hdd_wext.c b/core/hdd/src/wlan_hdd_wext.c
index 85e5d2f9c303..0f412b27f821 100644
--- a/core/hdd/src/wlan_hdd_wext.c
+++ b/core/hdd/src/wlan_hdd_wext.c
@@ -4476,6 +4476,35 @@ static int hdd_we_set_amsdu(struct hdd_adapter *adapter, int amsdu)
 	return 0;
 }
 
+static int hdd_we_clear_stats(struct hdd_adapter *adapter, int option)
+{
+	hdd_debug("option %d", option);
+
+	switch (option) {
+	case CDP_HDD_STATS:
+		memset(&adapter->stats, 0, sizeof(adapter->stats));
+		memset(&adapter->hdd_stats, 0, sizeof(adapter->hdd_stats));
+		break;
+	case CDP_TXRX_HIST_STATS:
+		wlan_hdd_clear_tx_rx_histogram(adapter->hdd_ctx);
+		break;
+	case CDP_HDD_NETIF_OPER_HISTORY:
+		wlan_hdd_clear_netif_queue_history(adapter->hdd_ctx);
+		break;
+	case CDP_HIF_STATS:
+		hdd_clear_hif_stats();
+		break;
+	case CDP_NAPI_STATS:
+		hdd_clear_napi_stats();
+		break;
+	default:
+		cdp_clear_stats(cds_get_context(QDF_MODULE_ID_SOC),
+				option);
+	}
+
+	return 0;
+}
+
 /**
  * iw_setint_getnone() - Generic "set integer" private ioctl handler
  * @dev: device upon which the ioctl was received
@@ -4909,32 +4938,8 @@ static int __iw_setint_getnone(struct net_device *dev,
 	}
 
 	case WE_CLEAR_STATS:
-	{
-		hdd_debug("WE_CLEAR_STATS val %d", set_value);
-		switch (set_value) {
-		case CDP_HDD_STATS:
-			memset(&adapter->stats, 0, sizeof(adapter->stats));
-			memset(&adapter->hdd_stats, 0,
-					sizeof(adapter->hdd_stats));
-			break;
-		case CDP_TXRX_HIST_STATS:
-			wlan_hdd_clear_tx_rx_histogram(hdd_ctx);
-			break;
-		case CDP_HDD_NETIF_OPER_HISTORY:
-			wlan_hdd_clear_netif_queue_history(hdd_ctx);
-			break;
-		case CDP_HIF_STATS:
-			hdd_clear_hif_stats();
-			break;
-		case CDP_NAPI_STATS:
-			hdd_clear_napi_stats();
-			break;
-		default:
-			cdp_clear_stats(cds_get_context(QDF_MODULE_ID_SOC),
-						set_value);
-		}
+		ret = hdd_we_clear_stats(adapter, set_value);
 		break;
-	}
 
 	case WE_PPS_PAID_MATCH:
 	{