From cb89aac98c579b707e2c539fbc874dceeff1b86a Mon Sep 17 00:00:00 2001 From: Srinivas Pitla Date: Fri, 9 Mar 2018 12:30:34 +0530 Subject: [PATCH] qcacmn: Add check for max pdev id on pdev search Max pdev count check is performed before accessing the pdev list index Change-Id: I755a5cb595824968b057321b13a6e1c837ece669 CRs-Fixed: 2177109 --- umac/cmn_services/obj_mgr/src/wlan_objmgr_psoc_obj.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/umac/cmn_services/obj_mgr/src/wlan_objmgr_psoc_obj.c b/umac/cmn_services/obj_mgr/src/wlan_objmgr_psoc_obj.c index fa654ba7a5fb..b24964d921e8 100644 --- a/umac/cmn_services/obj_mgr/src/wlan_objmgr_psoc_obj.c +++ b/umac/cmn_services/obj_mgr/src/wlan_objmgr_psoc_obj.c @@ -760,6 +760,10 @@ struct wlan_objmgr_pdev *wlan_objmgr_get_pdev_by_id( struct wlan_objmgr_psoc_objmgr *objmgr; struct wlan_objmgr_pdev *pdev = NULL; + /* If id is invalid, return */ + if (id >= WLAN_UMAC_MAX_PDEVS) + return NULL; + wlan_psoc_obj_lock(psoc); objmgr = &psoc->soc_objmgr; /* get pdev from pdev list */ @@ -784,6 +788,10 @@ struct wlan_objmgr_pdev *wlan_objmgr_get_pdev_by_id_no_state( struct wlan_objmgr_psoc_objmgr *objmgr; struct wlan_objmgr_pdev *pdev = NULL; + /* If id is invalid, return */ + if (id >= WLAN_UMAC_MAX_PDEVS) + return NULL; + wlan_psoc_obj_lock(psoc); objmgr = &psoc->soc_objmgr; /* get pdev from pdev list */