From cd192eccc885aea2119ce43ca7bd76acf783e977 Mon Sep 17 00:00:00 2001 From: Krunal Soni Date: Thu, 3 May 2018 15:06:44 -0700 Subject: [PATCH] qcacmn: Pass the arg by reference while calling sme_pdev_set_pcl() While calling sme_pdev_set_pcl() API, driver is passing the argument by value. The size of the argument is 280 bytes which is not good design. Pass the argument by reference instead of passing it by value to make design simple. CRs-Fixed: 2238293 Change-Id: I92849fb125fe864c1c7c7977bce392a7bcfe4121 --- umac/cmn_services/policy_mgr/inc/wlan_policy_mgr_api.h | 2 +- umac/cmn_services/policy_mgr/src/wlan_policy_mgr_core.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/umac/cmn_services/policy_mgr/inc/wlan_policy_mgr_api.h b/umac/cmn_services/policy_mgr/inc/wlan_policy_mgr_api.h index 044708767b71..38c84cb7cff2 100644 --- a/umac/cmn_services/policy_mgr/inc/wlan_policy_mgr_api.h +++ b/umac/cmn_services/policy_mgr/inc/wlan_policy_mgr_api.h @@ -792,7 +792,7 @@ struct policy_mgr_sme_cbacks { QDF_STATUS (*sme_soc_set_dual_mac_config)( struct policy_mgr_dual_mac_config msg); QDF_STATUS (*sme_pdev_set_hw_mode)(struct policy_mgr_hw_mode msg); - QDF_STATUS (*sme_pdev_set_pcl)(struct policy_mgr_pcl_list msg); + QDF_STATUS (*sme_pdev_set_pcl)(struct policy_mgr_pcl_list *msg); QDF_STATUS (*sme_nss_update_request)(uint32_t vdev_id, uint8_t new_nss, policy_mgr_nss_update_cback cback, uint8_t next_action, struct wlan_objmgr_psoc *psoc, diff --git a/umac/cmn_services/policy_mgr/src/wlan_policy_mgr_core.c b/umac/cmn_services/policy_mgr/src/wlan_policy_mgr_core.c index 46415feef511..30c604cb5285 100644 --- a/umac/cmn_services/policy_mgr/src/wlan_policy_mgr_core.c +++ b/umac/cmn_services/policy_mgr/src/wlan_policy_mgr_core.c @@ -1199,7 +1199,7 @@ void policy_mgr_pdev_set_pcl(struct wlan_objmgr_psoc *psoc, return; } - status = pm_ctx->sme_cbacks.sme_pdev_set_pcl(pcl); + status = pm_ctx->sme_cbacks.sme_pdev_set_pcl(&pcl); if (status != QDF_STATUS_SUCCESS) policy_mgr_err("Send soc set PCL to SME failed"); else