From ce76a35340c6d0f8ba2e69e0e964b6a2de5ac914 Mon Sep 17 00:00:00 2001 From: Kabilan Kannan Date: Wed, 23 Aug 2017 18:06:30 -0700 Subject: [PATCH] qcacmn: Fix TDLS peer capability initialization In tdls_set_peer_caps(), is_buffer_sta and is_off_channel_supported are declared, but are not initialized. This will create unpredictable problem in TDLS operations. Initialize all the variables with default values in peer capability. Change-Id: I469d7a56e1222944f3cd76efb76544aba7d8dff6 CRs-Fixed: 2092034 --- umac/tdls/core/src/wlan_tdls_peer.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/umac/tdls/core/src/wlan_tdls_peer.c b/umac/tdls/core/src/wlan_tdls_peer.c index c78f0f0f3569..1513295db464 100644 --- a/umac/tdls/core/src/wlan_tdls_peer.c +++ b/umac/tdls/core/src/wlan_tdls_peer.c @@ -618,7 +618,9 @@ void tdls_set_peer_caps(struct tdls_vdev_priv_obj *vdev_obj, const uint8_t *macaddr, struct tdls_update_peer_params *req_info) { - uint8_t is_buffer_sta, is_off_channel_supported, is_qos_wmm_sta; + uint8_t is_buffer_sta = 0; + uint8_t is_off_channel_supported = 0; + uint8_t is_qos_wmm_sta = 0; struct tdls_soc_priv_obj *soc_obj; struct tdls_peer *curr_peer; uint32_t feature; @@ -643,7 +645,7 @@ void tdls_set_peer_caps(struct tdls_vdev_priv_obj *vdev_obj, is_off_channel_supported = 1; if (TDLS_IS_WMM_ENABLED(feature) && req_info->is_qos_wmm_sta) - is_qos_wmm_sta = true; + is_qos_wmm_sta = 1; curr_peer->uapsd_queues = req_info->uapsd_queues; curr_peer->max_sp = req_info->max_sp;