mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 11:11:45 -04:00
genetlink: Fix a memory leak on error path
In genl_register_family(), when idr_alloc() fails,
we forget to free the memory we possibly allocate for
family->attrbuf.
Reported-by: Hulk Robot <[email protected]>
Fixes: 2ae0f17df1 ("genetlink: use idr to track families")
Signed-off-by: YueHaibing <[email protected]>
Reviewed-by: Kirill Tkhai <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
This commit is contained in:
parent
33872d79f5
commit
ceabee6c59
1 changed files with 2 additions and 1 deletions
|
|
@ -366,7 +366,7 @@ int genl_register_family(struct genl_family *family)
|
|||
start, end + 1, GFP_KERNEL);
|
||||
if (family->id < 0) {
|
||||
err = family->id;
|
||||
goto errout_locked;
|
||||
goto errout_free;
|
||||
}
|
||||
|
||||
err = genl_validate_assign_mc_groups(family);
|
||||
|
|
@ -385,6 +385,7 @@ int genl_register_family(struct genl_family *family)
|
|||
|
||||
errout_remove:
|
||||
idr_remove(&genl_fam_idr, family->id);
|
||||
errout_free:
|
||||
kfree(family->attrbuf);
|
||||
errout_locked:
|
||||
genl_unlock_all();
|
||||
|
|
|
|||
Loading…
Reference in a new issue