From cfba54476b2e3cc54a2d9df2747c5b4c8e6aa3b7 Mon Sep 17 00:00:00 2001 From: Jordan Crouse Date: Wed, 8 Aug 2018 13:01:36 -0600 Subject: [PATCH] checkpatch: Treat duplicate signatures as a different error class If code is merged upstream first it is possible that the same author may end up attempting to merge the same code into a downstream kernel. Since code coming from upstream is always a backport and may involve modifications it is appropriate for the author to add another Signed-off-by line to the bottom of the commit log but this will cause checkpatch to complain about duplicate signatures. By making the duplicate signature warning a different error class (DUPLICATE_SIGN_OFF instead of BAD_SIGN_OFF) this will let us ignore this error with --ignore DUPLICATE_SIGN_OFF without losing the benefits of the other signature checks. Change-Id: Ic0dedbadcc1b319061db324f88740e5320bfff09 Signed-off-by: Jordan Crouse --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 79851c968779..39aac0fb0b1a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2787,7 +2787,7 @@ sub process { $sig_nospace =~ s/\s//g; $sig_nospace = lc($sig_nospace); if (defined $signatures{$sig_nospace}) { - WARN("BAD_SIGN_OFF", + WARN("DUPLICATE_SIGN_OFF", "Duplicate signature\n" . $herecurr); } else { $signatures{$sig_nospace} = 1;