From d1225e6f65ce130d3b663e8b994ae331b3fe6dff Mon Sep 17 00:00:00 2001 From: "Selvaraj, Sridhar" Date: Fri, 17 Mar 2017 12:56:58 +0530 Subject: [PATCH] qcacld-3.0: Cleanup unnecessary logs in roaming component Remove unwanted redundant info printed across multiple layers[csr, lim, wma] with respect to roaming. Change-Id: I5197633b0e5afc775c1e10a6e75c58c58055ec49 CRs-Fixed: 2021082 --- core/hdd/src/wlan_hdd_cfg80211.c | 6 +++--- core/mac/src/pe/lim/lim_utils.c | 7 ------- core/sme/src/csr/csr_api_roam.c | 35 +++++++++++++++----------------- core/wma/src/wma_features.c | 5 +++-- core/wma/src/wma_scan_roam.c | 3 --- 5 files changed, 22 insertions(+), 34 deletions(-) diff --git a/core/hdd/src/wlan_hdd_cfg80211.c b/core/hdd/src/wlan_hdd_cfg80211.c index e85f64cc1471..31486cafde48 100644 --- a/core/hdd/src/wlan_hdd_cfg80211.c +++ b/core/hdd/src/wlan_hdd_cfg80211.c @@ -4361,7 +4361,6 @@ int wlan_hdd_send_roam_auth_event(hdd_adapter_t *adapter, uint8_t *bssid, hdd_err("nla put fail"); goto nla_put_failure; } - hdd_debug("Auth Status = %d", roam_info_ptr->synchAuthStatus); if (roam_info_ptr->synchAuthStatus == CSR_ROAM_AUTH_STATUS_AUTHENTICATED) { hdd_debug("Include Auth Params TLV's"); @@ -4402,8 +4401,9 @@ int wlan_hdd_send_roam_auth_event(hdd_adapter_t *adapter, uint8_t *bssid, } } - hdd_debug("Subnet Change Status = %d", - roam_info_ptr->subnet_change_status); + hdd_debug("Auth Status = %d Subnet Change Status = %d", + roam_info_ptr->synchAuthStatus, + roam_info_ptr->subnet_change_status); /* * Add subnet change status if subnet has changed diff --git a/core/mac/src/pe/lim/lim_utils.c b/core/mac/src/pe/lim/lim_utils.c index 82c5ec3096f6..2810cc9179a9 100644 --- a/core/mac/src/pe/lim/lim_utils.c +++ b/core/mac/src/pe/lim/lim_utils.c @@ -6638,7 +6638,6 @@ QDF_STATUS lim_send_ext_cap_ie(tpAniSirGlobal mac_ctx, struct vdev_ie_info *vdev_ie; struct scheduler_msg msg = {0}; tSirRetStatus status; - uint8_t *temp, i; wlan_cfg_get_int(mac_ctx, WNI_CFG_DOT11_MODE, &dot11mode); if (IS_DOT11_MODE_VHT(dot11mode)) @@ -6671,12 +6670,6 @@ QDF_STATUS lim_send_ext_cap_ie(tpAniSirGlobal mac_ctx, vdev_ie->length = num_bytes; vdev_ie->band = 0; - lim_log(mac_ctx, LOG1, FL("vdev %d ieid %d len %d"), session_id, - DOT11F_EID_EXTCAP, num_bytes); - temp = ext_cap_data.bytes; - for (i = 0; i < num_bytes; i++, temp++) - lim_log(mac_ctx, LOG1, FL("%d byte is %02x"), i+1, *temp); - vdev_ie->data = (uint8_t *)vdev_ie + sizeof(*vdev_ie); qdf_mem_copy(vdev_ie->data, ext_cap_data.bytes, num_bytes); diff --git a/core/sme/src/csr/csr_api_roam.c b/core/sme/src/csr/csr_api_roam.c index 65f52c0b7a85..b5d71b183ac8 100644 --- a/core/sme/src/csr/csr_api_roam.c +++ b/core/sme/src/csr/csr_api_roam.c @@ -16965,8 +16965,6 @@ csr_update_roam_scan_offload_request(tpAniSirGlobal mac_ctx, qdf_mem_copy(req_buf->PSK_PMK, session->psk_pmk, sizeof(req_buf->PSK_PMK)); req_buf->pmk_len = session->pmk_len; - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_DEBUG, - "LFR3: PMK Length = %d", req_buf->pmk_len); req_buf->R0KH_ID_Length = session->ftSmeContext.r0kh_id_len; qdf_mem_copy(req_buf->R0KH_ID, session->ftSmeContext.r0kh_id, @@ -17496,8 +17494,6 @@ csr_create_roam_scan_offload_request(tpAniSirGlobal mac_ctx, (2 * CSR_ROAM_SCAN_CHANNEL_SWITCH_TIME))); req_buf->HomeAwayTime = 0; } - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_DEBUG, - "HomeAwayTime: %d", req_buf->HomeAwayTime); /*Prepare a probe request for 2.4GHz band and one for 5GHz band */ dot11_mode = (uint8_t) csr_translate_to_wni_cfg_dot11_mode(mac_ctx, @@ -17512,10 +17508,11 @@ csr_create_roam_scan_offload_request(tpAniSirGlobal mac_ctx, req_buf->early_stop_scan_max_threshold = mac_ctx->roam.configParam.early_stop_scan_max_threshold; QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_DEBUG, - FL("EarlyStopFeature Enable=%d, MinThresh=%d, MaxThresh=%d"), - req_buf->early_stop_scan_enable, + FL("HomeAwayTime=%d EarlyStopFeature Enable=%d, MinThresh=%d, MaxThresh=%d PMK len=%d"), + req_buf->HomeAwayTime, req_buf->early_stop_scan_enable, req_buf->early_stop_scan_min_threshold, - req_buf->early_stop_scan_max_threshold); + req_buf->early_stop_scan_max_threshold, + req_buf->pmk_len); req_buf->roamscan_adaptive_dwell_mode = mac_ctx->roam.configParam.roamscan_adaptive_dwell_mode; #ifdef WLAN_FEATURE_ROAM_OFFLOAD @@ -17686,7 +17683,6 @@ static void csr_append_assoc_ies(tpAniSirGlobal mac_ctx, return; } - sme_debug("Appended IE(Id:%d) to RSO", ie_id); assoc_ie->addIEdata[assoc_ie->length] = ie_id; assoc_ie->addIEdata[assoc_ie->length + 1] = ie_len; qdf_mem_copy(&assoc_ie->addIEdata[assoc_ie->length + 2], @@ -18053,21 +18049,19 @@ csr_roam_offload_scan(tpAniSirGlobal mac_ctx, uint8_t session_id, roam_params_dst->max_drop_rssi_5g, req_buf->RoamRssiDiff, roam_params_dst->alert_rssi_threshold); - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_DEBUG, - "dense_rssi_thresh_offset: %d, dense_min_aps_cnt:%d, traffic_threshold:%d", - roam_params_dst->dense_rssi_thresh_offset, - roam_params_dst->dense_min_aps_cnt, - roam_params_dst->traffic_threshold); - /* Set initial dense roam status */ if (mac_ctx->scan.roam_candidate_count[session_id] > roam_params_dst->dense_min_aps_cnt) roam_params_dst->initial_dense_status = true; QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_DEBUG, - "initial_dense_status:%d, candidate count:%d", - roam_params_dst->initial_dense_status, - mac_ctx->scan.roam_candidate_count[session_id]); + "dense_rssi_thresh_offset: %d, dense_min_aps_cnt:%d, traffic_threshold:%d, " + "initial_dense_status:%d, candidate count:%d", + roam_params_dst->dense_rssi_thresh_offset, + roam_params_dst->dense_min_aps_cnt, + roam_params_dst->traffic_threshold, + roam_params_dst->initial_dense_status, + mac_ctx->scan.roam_candidate_count[session_id]); for (i = 0; i < roam_params_dst->num_bssid_avoid_list; i++) { QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_DEBUG, @@ -18120,6 +18114,11 @@ csr_roam_offload_scan(tpAniSirGlobal mac_ctx, uint8_t session_id, csr_update_driver_assoc_ies(mac_ctx, session, req_buf); } + QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_DEBUG, + "Assoc IE buffer:"); + QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_DEBUG, + req_buf->assoc_ie.addIEdata, req_buf->assoc_ie.length); + if (!QDF_IS_STATUS_SUCCESS( csr_roam_send_rso_cmd(mac_ctx, session_id, req_buf))) { QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, @@ -18135,8 +18134,6 @@ csr_roam_offload_scan(tpAniSirGlobal mac_ctx, uint8_t session_id, /* update the last sent cmd */ roam_info->last_sent_cmd = command; - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_DEBUG, - "Roam Scan Offload Command %d, Reason %d", command, reason); /* Update PER config to FW after sending the command */ csr_roam_offload_per_scan(mac_ctx, session_id); return status; diff --git a/core/wma/src/wma_features.c b/core/wma/src/wma_features.c index 8d6c4a22f1bd..e89b7935c3da 100644 --- a/core/wma/src/wma_features.c +++ b/core/wma/src/wma_features.c @@ -5552,8 +5552,9 @@ QDF_STATUS wma_process_set_ie_info(tp_wma_handle wma, cmd.data = ie_info->data; cmd.ie_source = WMA_SET_VDEV_IE_SOURCE_HOST; - WMA_LOGD(FL("ie_id: %d, band: %d, len: %d"), - ie_info->ie_id, ie_info->band, ie_info->length); + WMA_LOGD(FL("vdev id: %d, ie_id: %d, band: %d, len: %d"), + ie_info->vdev_id, ie_info->ie_id, ie_info->band, + ie_info->length); QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_WMA, QDF_TRACE_LEVEL_DEBUG, ie_info->data, ie_info->length); diff --git a/core/wma/src/wma_scan_roam.c b/core/wma/src/wma_scan_roam.c index 1e800dd9ef75..14cb86d4ef3a 100644 --- a/core/wma/src/wma_scan_roam.c +++ b/core/wma/src/wma_scan_roam.c @@ -1728,9 +1728,6 @@ QDF_STATUS wma_process_roaming_config(tp_wma_handle wma_handle, uint32_t mode = 0; struct wma_txrx_node *intr = NULL; - WMA_LOGD("%s: command 0x%x, reason %d", __func__, roam_req->Command, - roam_req->reason); - if (NULL == pMac) { WMA_LOGE("%s: pMac is NULL", __func__); qdf_mem_free(roam_req);