From 657d9f2ce952f143b3c450a858440a12b398e542 Mon Sep 17 00:00:00 2001 From: Manikandan Mohan Date: Thu, 6 Aug 2020 10:54:02 -0700 Subject: [PATCH] cnss2: Fix for static analysis issue Fix a potential null pointer issue with DT based bus bandwidth setup feature. Change-Id: I66187ac31a23886cd5279c81f001c69e401303a4 Signed-off-by: Manikandan Mohan --- drivers/net/wireless/cnss2/main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/cnss2/main.c b/drivers/net/wireless/cnss2/main.c index fbd5b3ba9fcf..4fd26feaddbc 100644 --- a/drivers/net/wireless/cnss2/main.c +++ b/drivers/net/wireless/cnss2/main.c @@ -2006,6 +2006,10 @@ static int cnss_register_bus_scale(struct cnss_plat_data *plat_priv) bus_bw_info->cfg_table = kcalloc(bus_bw_info->num_cfg, sizeof(*bus_bw_info->cfg_table), GFP_KERNEL); + if (!bus_bw_info->cfg_table) { + cnss_pr_err("No mem for Bus BW config table\n"); + return -ENOMEM; + } for (i = 0, j = 0; i < bus_bw_info->num_cfg; i++, j += 2) { bus_bw_info->cfg_table[i].ab = be32_to_cpu(cfg_arr[j]); bus_bw_info->cfg_table[i].ib = be32_to_cpu(cfg_arr[j + 1]); @@ -2013,7 +2017,6 @@ static int cnss_register_bus_scale(struct cnss_plat_data *plat_priv) i, bus_bw_info->cfg_table[i].ab, bus_bw_info->cfg_table[i].ib); } - return 0; out: return ret;