From d553a0ff41f74b6f7d47eb3f16b31f4eea5669f7 Mon Sep 17 00:00:00 2001 From: Nitin Rawat Date: Fri, 20 Nov 2020 13:43:34 +0530 Subject: [PATCH] scsi: ufs: Check qcg before dereferencing Check qcg before dereferencing to avoid NULL pointer dereference and return if its NULL. This is is to fix below kw warnings. ufs-qcom.c:2489: 'qcg' is assigned the return value from function 'cpu_to_group'. ufs-qcom.c:2439: 'cpu_to_group' explicitly returns a NULL value. ufs-qcom.c:2490: 'qcg' is explicitly dereferenced. Change-Id: I291c9230bb7fb5df414db8f80bfb17a50c8fc7cf Signed-off-by: Nitin Rawat --- drivers/scsi/ufs/ufs-qcom.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index 1ee2454d03fb..a74b14291099 100644 --- a/drivers/scsi/ufs/ufs-qcom.c +++ b/drivers/scsi/ufs/ufs-qcom.c @@ -2487,6 +2487,9 @@ static void ufs_qcom_qos(struct ufs_hba *hba, int tag, bool is_scsi_cmd) if (cpu < 0) return; qcg = cpu_to_group(host->ufs_qos, cpu); + if (!qcg) + return; + if (qcg->voted) { dev_dbg(qcg->host->hba->dev, "%s: qcg: 0x%08x | Mask: 0x%08x - Already voted - return\n", __func__, qcg, qcg->mask);