From d5c15fcdcc7f1c9a68247b94c45fb9e91dc2e1a3 Mon Sep 17 00:00:00 2001 From: Gao Xiang Date: Sat, 19 Sep 2020 15:27:28 +0800 Subject: [PATCH] erofs: avoid unnecessary variable `err' variable `err' in z_erofs_submit_queue() isn't useful here, remove it instead. Reviewed-by: Chao Yu Link: https://lore.kernel.org/r/20200919072730.24989-1-hsiangkao@redhat.com Change-Id: I67b4100f93351faa690d493a6d5360e07ba41ec2 Signed-off-by: Gao Xiang --- fs/erofs/zdata.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index 5c3f6ac41728..5551f36c6462 100644 --- a/fs/erofs/zdata.c +++ b/fs/erofs/zdata.c @@ -1191,7 +1191,6 @@ static void z_erofs_submit_queue(struct super_block *sb, do { struct page *page; - int err; page = pickup_page_for_submission(pcl, i++, pagepool, MNGD_MAPPING(sbi), @@ -1217,8 +1216,7 @@ submit_bio_retry: ++nr_bios; } - err = bio_add_page(bio, page, PAGE_SIZE, 0); - if (err < PAGE_SIZE) + if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE) goto submit_bio_retry; last_index = cur;