mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 19:21:31 -04:00
powerpc/sparse: Fix plain integer as NULL pointer warning
Trivial fix to remove the following sparse warnings: arch/powerpc/kernel/module_32.c:112:74: warning: Using plain integer as NULL pointer arch/powerpc/kernel/module_32.c:117:74: warning: Using plain integer as NULL pointer drivers/macintosh/via-pmu.c:1155:28: warning: Using plain integer as NULL pointer drivers/macintosh/via-pmu.c:1230:20: warning: Using plain integer as NULL pointer drivers/macintosh/via-pmu.c:1385:36: warning: Using plain integer as NULL pointer drivers/macintosh/via-pmu.c:1752:23: warning: Using plain integer as NULL pointer drivers/macintosh/via-pmu.c:2084:19: warning: Using plain integer as NULL pointer drivers/macintosh/via-pmu.c:2110:32: warning: Using plain integer as NULL pointer drivers/macintosh/via-pmu.c:2167:19: warning: Using plain integer as NULL pointer drivers/macintosh/via-pmu.c:2183:19: warning: Using plain integer as NULL pointer drivers/macintosh/via-pmu.c:277:20: warning: Using plain integer as NULL pointer arch/powerpc/platforms/powermac/setup.c:155:67: warning: Using plain integer as NULL pointer arch/powerpc/platforms/powermac/setup.c:247:27: warning: Using plain integer as NULL pointer arch/powerpc/platforms/powermac/setup.c:249:27: warning: Using plain integer as NULL pointer arch/powerpc/platforms/powermac/setup.c:252:37: warning: Using plain integer as NULL pointer arch/powerpc/mm/tlb_hash32.c:127:21: warning: Using plain integer as NULL pointer arch/powerpc/mm/tlb_hash32.c:148:21: warning: Using plain integer as NULL pointer arch/powerpc/mm/tlb_hash32.c:44:21: warning: Using plain integer as NULL pointer arch/powerpc/mm/tlb_hash32.c:57:21: warning: Using plain integer as NULL pointer arch/powerpc/mm/tlb_hash32.c:87:21: warning: Using plain integer as NULL pointer arch/powerpc/kernel/btext.c:160:31: warning: Using plain integer as NULL pointer arch/powerpc/kernel/btext.c:167:22: warning: Using plain integer as NULL pointer arch/powerpc/kernel/btext.c:274:21: warning: Using plain integer as NULL pointer arch/powerpc/kernel/btext.c:285:31: warning: Using plain integer as NULL pointer arch/powerpc/include/asm/hugetlb.h:204:16: warning: Using plain integer as NULL pointer arch/powerpc/mm/ppc_mmu_32.c:170:21: warning: Using plain integer as NULL pointer arch/powerpc/platforms/powermac/pci.c:1227:23: warning: Using plain integer as NULL pointer arch/powerpc/platforms/powermac/pci.c:65:24: warning: Using plain integer as NULL pointer Also use `--fix` command line option from `script/checkpatch --strict` to remove the following: CHECK: Comparison to NULL could be written "!dispDeviceBase" #72: FILE: arch/powerpc/kernel/btext.c:160: + if (dispDeviceBase == NULL) CHECK: Comparison to NULL could be written "!vbase" #80: FILE: arch/powerpc/kernel/btext.c:167: + if (vbase == NULL) CHECK: Comparison to NULL could be written "!base" #89: FILE: arch/powerpc/kernel/btext.c:274: + if (base == NULL) CHECK: Comparison to NULL could be written "!dispDeviceBase" #98: FILE: arch/powerpc/kernel/btext.c:285: + if (dispDeviceBase == NULL) CHECK: Comparison to NULL could be written "strstr" #117: FILE: arch/powerpc/kernel/module_32.c:117: + if (strstr(secstrings + sechdrs[i].sh_name, ".debug") != NULL) CHECK: Comparison to NULL could be written "!Hash" #130: FILE: arch/powerpc/mm/ppc_mmu_32.c:170: + if (Hash == NULL) CHECK: Comparison to NULL could be written "Hash" #143: FILE: arch/powerpc/mm/tlb_hash32.c:44: + if (Hash != NULL) { CHECK: Comparison to NULL could be written "!Hash" #152: FILE: arch/powerpc/mm/tlb_hash32.c:57: + if (Hash == NULL) { CHECK: Comparison to NULL could be written "!Hash" #161: FILE: arch/powerpc/mm/tlb_hash32.c:87: + if (Hash == NULL) { CHECK: Comparison to NULL could be written "!Hash" #170: FILE: arch/powerpc/mm/tlb_hash32.c:127: + if (Hash == NULL) { CHECK: Comparison to NULL could be written "!Hash" #179: FILE: arch/powerpc/mm/tlb_hash32.c:148: + if (Hash == NULL) { ERROR: space required after that ';' (ctx:VxV) #192: FILE: arch/powerpc/platforms/powermac/pci.c:65: + for (; node != NULL;node = node->sibling) { CHECK: Comparison to NULL could be written "node" #192: FILE: arch/powerpc/platforms/powermac/pci.c:65: + for (; node != NULL;node = node->sibling) { CHECK: Comparison to NULL could be written "!region" #201: FILE: arch/powerpc/platforms/powermac/pci.c:1227: + if (region == NULL) CHECK: Comparison to NULL could be written "of_get_property" #214: FILE: arch/powerpc/platforms/powermac/setup.c:155: + if (of_get_property(np, "cache-unified", NULL) != NULL && dc) { CHECK: Comparison to NULL could be written "!np" #223: FILE: arch/powerpc/platforms/powermac/setup.c:247: + if (np == NULL) CHECK: Comparison to NULL could be written "np" #226: FILE: arch/powerpc/platforms/powermac/setup.c:249: + if (np != NULL) { CHECK: Comparison to NULL could be written "l2cr" #230: FILE: arch/powerpc/platforms/powermac/setup.c:252: + if (l2cr != NULL) { CHECK: Comparison to NULL could be written "via" #243: FILE: drivers/macintosh/via-pmu.c:277: + if (via != NULL) CHECK: Comparison to NULL could be written "current_req" #252: FILE: drivers/macintosh/via-pmu.c:1155: + if (current_req != NULL) { CHECK: Comparison to NULL could be written "!req" #261: FILE: drivers/macintosh/via-pmu.c:1230: + if (req == NULL || pmu_state != idle CHECK: Comparison to NULL could be written "!req" #270: FILE: drivers/macintosh/via-pmu.c:1385: + if (req == NULL) { CHECK: Comparison to NULL could be written "!pp" #288: FILE: drivers/macintosh/via-pmu.c:2084: + if (pp == NULL) CHECK: Comparison to NULL could be written "!pp" #297: FILE: drivers/macintosh/via-pmu.c:2110: + if (count < 1 || pp == NULL) CHECK: Comparison to NULL could be written "!pp" #306: FILE: drivers/macintosh/via-pmu.c:2167: + if (pp == NULL) CHECK: Comparison to NULL could be written "pp" #315: FILE: drivers/macintosh/via-pmu.c:2183: + if (pp != NULL) { Link: https://github.com/linuxppc/linux/issues/37 Signed-off-by: Mathieu Malaterre <[email protected]> Signed-off-by: Michael Ellerman <[email protected]>
This commit is contained in:
Mathieu Malaterre
Michael Ellerman
parent
7cf76a68f1
commit
d8731527ac
8 changed files with 28 additions and 28 deletions
|
|
@ -274,7 +274,7 @@ int __init find_via_pmu(void)
|
|||
u64 taddr;
|
||||
const u32 *reg;
|
||||
|
||||
if (via != 0)
|
||||
if (via)
|
||||
return 1;
|
||||
vias = of_find_node_by_name(NULL, "via-pmu");
|
||||
if (vias == NULL)
|
||||
|
|
@ -1152,7 +1152,7 @@ pmu_queue_request(struct adb_request *req)
|
|||
req->complete = 0;
|
||||
|
||||
spin_lock_irqsave(&pmu_lock, flags);
|
||||
if (current_req != 0) {
|
||||
if (current_req) {
|
||||
last_req->next = req;
|
||||
last_req = req;
|
||||
} else {
|
||||
|
|
@ -1227,7 +1227,7 @@ pmu_start(void)
|
|||
/* assert pmu_state == idle */
|
||||
/* get the packet to send */
|
||||
req = current_req;
|
||||
if (req == 0 || pmu_state != idle
|
||||
if (!req || pmu_state != idle
|
||||
|| (/*req->reply_expected && */req_awaiting_reply))
|
||||
return;
|
||||
|
||||
|
|
@ -1382,7 +1382,7 @@ next:
|
|||
if ((1 << pirq) & PMU_INT_ADB) {
|
||||
if ((data[0] & PMU_INT_ADB_AUTO) == 0) {
|
||||
struct adb_request *req = req_awaiting_reply;
|
||||
if (req == 0) {
|
||||
if (!req) {
|
||||
printk(KERN_ERR "PMU: extra ADB reply\n");
|
||||
return;
|
||||
}
|
||||
|
|
@ -1749,7 +1749,7 @@ pmu_shutdown(void)
|
|||
int
|
||||
pmu_present(void)
|
||||
{
|
||||
return via != 0;
|
||||
return via != NULL;
|
||||
}
|
||||
|
||||
#if defined(CONFIG_SUSPEND) && defined(CONFIG_PPC32)
|
||||
|
|
@ -2081,7 +2081,7 @@ pmu_open(struct inode *inode, struct file *file)
|
|||
unsigned long flags;
|
||||
|
||||
pp = kmalloc(sizeof(struct pmu_private), GFP_KERNEL);
|
||||
if (pp == 0)
|
||||
if (!pp)
|
||||
return -ENOMEM;
|
||||
pp->rb_get = pp->rb_put = 0;
|
||||
spin_lock_init(&pp->lock);
|
||||
|
|
@ -2107,7 +2107,7 @@ pmu_read(struct file *file, char __user *buf,
|
|||
unsigned long flags;
|
||||
int ret = 0;
|
||||
|
||||
if (count < 1 || pp == 0)
|
||||
if (count < 1 || !pp)
|
||||
return -EINVAL;
|
||||
if (!access_ok(VERIFY_WRITE, buf, count))
|
||||
return -EFAULT;
|
||||
|
|
@ -2164,7 +2164,7 @@ pmu_fpoll(struct file *filp, poll_table *wait)
|
|||
__poll_t mask = 0;
|
||||
unsigned long flags;
|
||||
|
||||
if (pp == 0)
|
||||
if (!pp)
|
||||
return 0;
|
||||
poll_wait(filp, &pp->wait, wait);
|
||||
spin_lock_irqsave(&pp->lock, flags);
|
||||
|
|
@ -2180,7 +2180,7 @@ pmu_release(struct inode *inode, struct file *file)
|
|||
struct pmu_private *pp = file->private_data;
|
||||
unsigned long flags;
|
||||
|
||||
if (pp != 0) {
|
||||
if (pp) {
|
||||
file->private_data = NULL;
|
||||
spin_lock_irqsave(&all_pvt_lock, flags);
|
||||
list_del(&pp->list);
|
||||
|
|
|
|||
Loading…
Reference in a new issue