A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-29 11:11:45 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Refactor WE_SET_POWER processing

Browse source 
Currently the HDD function with the highest cyclomatic complexity is
__iw_setint_getnone(). The handing of WE_SET_POWER has a complexity
greater than 1, so refactor that logic into a separate function to
help reduce the complexity of __iw_setint_getnone().

Change-Id: I4a2c08faf7ec88ca35a353c778fa0269f35eb76d
CRs-Fixed: 2336977
This commit is contained in:
Jeff Johnson 2018-10-19 12:46:35 -07:00 • committed by nshrivas
commit daf2e6a888
1 changed files with 36 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

66
core/hdd/src/wlan_hdd_wext.c
View file

@ -4126,6 +4126,39 @@ static int hdd_we_set_11d_state(struct hdd_context *hdd_ctx, int state_11d)
return 0;
}
static int hdd_we_set_power(struct hdd_adapter *adapter, int value)
{
struct hdd_context *hdd_ctx = WLAN_HDD_GET_CTX(adapter);
mac_handle_t mac_handle = hdd_ctx->mac_handle;
if (!mac_handle)
return -EINVAL;
switch (value) {
case 1:
/* Enable PowerSave */
sme_ps_enable_disable(mac_handle, adapter->session_id,
SME_PS_ENABLE);
return 0;
case 2:
/* Disable PowerSave */
sme_ps_enable_disable(mac_handle, adapter->session_id,
SME_PS_DISABLE);
return 0;
case 3:
/* Enable UASPD */
sme_ps_uapsd_enable(mac_handle, adapter->session_id);
return 0;
case 4:
/* Disable UASPD */
sme_ps_uapsd_disable(mac_handle, adapter->session_id);
return 0;
default:
hdd_err("Invalid value %d", value);
return -EINVAL;
}
}
/**
* iw_setint_getnone() - Generic "set integer" private ioctl handler
* @dev: device upon which the ioctl was received
@ -4153,11 +4186,11 @@ static int __iw_setint_getnone(struct net_device *dev,
hdd_ctx = WLAN_HDD_GET_CTX(adapter);
ret = wlan_hdd_validate_context(hdd_ctx);
if (0 != ret)
if (ret)
return ret;
ret = hdd_check_private_wext_control(hdd_ctx, info);
if (0 != ret)
if (ret)
return ret;
mac_handle = hdd_ctx->mac_handle;
@ -4167,35 +4200,8 @@ static int __iw_setint_getnone(struct net_device *dev,
break;
case WE_SET_POWER:
{
if (!mac_handle)
return -EINVAL;
switch (set_value) {
case 1:
/* Enable PowerSave */
sme_ps_enable_disable(mac_handle, adapter->session_id,
SME_PS_ENABLE);
break;
case 2:
/* Disable PowerSave */
sme_ps_enable_disable(mac_handle, adapter->session_id,
SME_PS_DISABLE);
break;
case 3: /* Enable UASPD */
sme_ps_uapsd_enable(mac_handle, adapter->session_id);
break;
case 4: /* Disable UASPD */
sme_ps_uapsd_disable(mac_handle, adapter->session_id);
break;
default:
hdd_err("Invalid arg %d in WE_SET_POWER IOCTL",
set_value);
ret = -EINVAL;
break;
}
ret = hdd_we_set_power(adapter, set_value);
break;
}
case WE_SET_MAX_ASSOC:
{