mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 03:01:39 -04:00
Use f_lock to protect f_flags
Traditionally, changes to struct file->f_flags have been done under BKL protection, or with no protection at all. This patch causes all f_flags changes after file open/creation time to be done under protection of f_lock. This allows the removal of some BKL usage and fixes a number of longstanding (if microscopic) races. Reviewed-by: Christoph Hellwig <[email protected]> Cc: Al Viro <[email protected]> Signed-off-by: Jonathan Corbet <[email protected]>
This commit is contained in:
parent
6849991490
commit
db1dd4d376
13 changed files with 33 additions and 9 deletions
|
|
@ -189,7 +189,9 @@ static int setfl(int fd, struct file * filp, unsigned long arg)
|
|||
}
|
||||
}
|
||||
|
||||
spin_lock(&filp->f_lock);
|
||||
filp->f_flags = (arg & SETFL_MASK) | (filp->f_flags & ~SETFL_MASK);
|
||||
spin_unlock(&filp->f_lock);
|
||||
out:
|
||||
unlock_kernel();
|
||||
return error;
|
||||
|
|
|
|||
Loading…
Reference in a new issue