From dbb563fda17d901959d7e37d9ddeaf24f92b2c8c Mon Sep 17 00:00:00 2001 From: Prasad Sodagudi Date: Tue, 14 Jan 2020 11:06:16 -0800 Subject: [PATCH] clk: qcom: Fix accessing of clks element during the probe There is access to platform descriptor clks init.name without checking, whether clks is present or not. This is leading to kernel crash during the device bootup. Move the init.name access after checking whether clks is valid or not. Change-Id: I7b27e5103822d6b2f499fb5f5e94ae9f9d4af34a Signed-off-by: Prasad Sodagudi --- drivers/clk/qcom/clk-rpmh.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index 262f41fd0d44..abd48318e7f4 100644 --- a/drivers/clk/qcom/clk-rpmh.c +++ b/drivers/clk/qcom/clk-rpmh.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved. + * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved. */ #include @@ -509,14 +509,14 @@ static int clk_rpmh_probe(struct platform_device *pdev) hw_clks = desc->clks; for (i = 0; i < desc->num_clks; i++) { - const char *name = hw_clks[i]->init->name; + const char *name; u32 res_addr; size_t aux_data_len; const struct bcm_db *data; if (!hw_clks[i]) continue; - + name = hw_clks[i]->init->name; rpmh_clk = to_clk_rpmh(hw_clks[i]); res_addr = cmd_db_read_addr(rpmh_clk->res_name); if (!res_addr) {