From dc75b47b7c3da22f64e2356cf7ebcb2047bc28ad Mon Sep 17 00:00:00 2001 From: Naman Padhiar Date: Thu, 16 Dec 2021 23:08:17 +0530 Subject: [PATCH] icnss: Add check for valid SMEM handler Validate SMEM state handler before using it. Change-Id: I762cef00daa267ff7e411a5c740556d7f235d383 Signed-off-by: Naman Padhiar --- drivers/soc/qcom/icnss2/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/icnss2/main.c b/drivers/soc/qcom/icnss2/main.c index 4180981c3a75..dc873a24e54f 100644 --- a/drivers/soc/qcom/icnss2/main.c +++ b/drivers/soc/qcom/icnss2/main.c @@ -1307,7 +1307,8 @@ static int icnss_driver_event_pd_service_down(struct icnss_priv *priv, if (priv->force_err_fatal) ICNSS_ASSERT(0); - if (priv->device_id == WCN6750_DEVICE_ID) { + if (priv->device_id == WCN6750_DEVICE_ID && + !IS_ERR(priv->smp2p_info.smem_state)) { priv->smp2p_info.seq = 0; if (qcom_smem_state_update_bits( priv->smp2p_info.smem_state, @@ -3912,7 +3913,7 @@ static inline void icnss_get_smp2p_info(struct icnss_priv *priv) "wlan-smp2p-out", &priv->smp2p_info.smem_bit); if (IS_ERR(priv->smp2p_info.smem_state)) { - icnss_pr_smp2p("Failed to get smem state %d", + icnss_pr_err("Failed to get smem state %d", PTR_ERR(priv->smp2p_info.smem_state)); }