From dd1d8ba52a3654e3d01e2a0a935357b5c6f32d02 Mon Sep 17 00:00:00 2001 From: Dundi Raviteja Date: Tue, 15 May 2018 14:16:21 +0530 Subject: [PATCH] qcacmn: Possible information leak due to uninitialized data In qdf_trace_hex_dump() API, linebuf array is not initialized where it is used to print in the form of string in qdf_trace_msg() API, this may cause information leak. To address this issue, initialize the linebuf array to zero. Change-Id: If2fe200eb16b28f7fff4413873c1d149716fb1a7 CRs-Fixed: 2232012 --- qdf/linux/src/qdf_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qdf/linux/src/qdf_trace.c b/qdf/linux/src/qdf_trace.c index 75ef6e9b68c2..dce8140a9b7c 100644 --- a/qdf/linux/src/qdf_trace.c +++ b/qdf/linux/src/qdf_trace.c @@ -361,7 +361,7 @@ void qdf_trace_hex_dump(QDF_MODULE_ID module, QDF_TRACE_LEVEL level, return; while (buf_len > 0) { - unsigned char linebuf[BUFFER_SIZE]; + unsigned char linebuf[BUFFER_SIZE] = {0}; int linelen = min(buf_len, ROW_SIZE); buf_len -= ROW_SIZE;