mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 03:01:39 -04:00
xfs: fallback to vmalloc for large buffers in xfs_attrlist_by_handle
Shamelessly copied from dchinner's:
ad650f5b xfs: fallback to vmalloc for large buffers in xfs_attrmulti_attr_get
xfsdump uses for a large buffer for extended attributes, which has a
kmalloc'd shadow buffer in the kernel. This can fail after the
system has been running for some time as it is a high order
allocation. Add a fallback to vmalloc so that it doesn't require
contiguous memory and so won't randomly fail while xfsdump is
running.
Signed-off-by: Eric Sandeen <[email protected]>
Reviewed-by: Mark Tinguely <[email protected]>
Signed-off-by: Ben Myers <[email protected]>
This commit is contained in:
parent
742ae1e35b
commit
dd700d9452
1 changed files with 10 additions and 4 deletions
|
|
@ -422,9 +422,12 @@ xfs_attrlist_by_handle(
|
|||
if (IS_ERR(dentry))
|
||||
return PTR_ERR(dentry);
|
||||
|
||||
kbuf = kzalloc(al_hreq.buflen, GFP_KERNEL);
|
||||
if (!kbuf)
|
||||
goto out_dput;
|
||||
kbuf = kmem_zalloc(al_hreq.buflen, KM_SLEEP | KM_MAYFAIL);
|
||||
if (!kbuf) {
|
||||
kbuf = kmem_zalloc_large(al_hreq.buflen);
|
||||
if (!kbuf)
|
||||
goto out_dput;
|
||||
}
|
||||
|
||||
cursor = (attrlist_cursor_kern_t *)&al_hreq.pos;
|
||||
error = -xfs_attr_list(XFS_I(dentry->d_inode), kbuf, al_hreq.buflen,
|
||||
|
|
@ -436,7 +439,10 @@ xfs_attrlist_by_handle(
|
|||
error = -EFAULT;
|
||||
|
||||
out_kfree:
|
||||
kfree(kbuf);
|
||||
if (is_vmalloc_addr(kbuf))
|
||||
kmem_free_large(kbuf);
|
||||
else
|
||||
kmem_free(kbuf);
|
||||
out_dput:
|
||||
dput(dentry);
|
||||
return error;
|
||||
|
|
|
|||
Loading…
Reference in a new issue