A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-28 18:51:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

fbdev: sh_mobile_hdmi: modify flags name to more specific

Browse source 
This patch solve below report from Guennadi

1)

> +/* Audio source select */
> +#define HDMI_SRC_MASK		(0xF << 0)
> +#define HDMI_SRC_I2S		(0 << 0) /* default */
> +#define HDMI_SRC_SPDIF		(1 << 0)
> +#define HDMI_SRC_DSD		(2 << 0)
> +#define HDMI_SRC_HBR		(3 << 0)

I would be more specific with these macro names, i.e., include "AUDIO" or
"SND" or something similar in them, e.g., HDMI_AUDIO_SRC_I2S.

2)

> +	case HDMI_SRC_I2S:
> +		data = (0x0 << 3);
> +		break;
> +	case HDMI_SRC_SPDIF:
> +		data = (0x1 << 3);
> +		break;
> +	case HDMI_SRC_DSD:
> +		data = (0x2 << 3);
> +		break;
> +	case HDMI_SRC_HBR:
> +		data = (0x3 << 3);

In all above cases parenthesis are superfluous.

Reported-by: Guennadi Liakhovetski <[email protected]>
Signed-off-by: Kuninori Morimoto <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
Acked-by: Liam Girdwood <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
This commit is contained in:
Kuninori Morimoto 2010-09-09 11:48:01 +09:00 • committed by Mark Brown
commit dec6aa49ab
2 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

18
drivers/video/sh_mobile_hdmi.c
View file

@ -389,20 +389,20 @@ static void sh_hdmi_audio_config(struct sh_hdmi *hdmi)
* [6:5] set required down sampling rate if required
* [4:3] set required audio source
*/
switch (pdata->flags & HDMI_SRC_MASK) {
switch (pdata->flags & HDMI_SND_SRC_MASK) {
default:
/* fall through */
case HDMI_SRC_I2S:
data = (0x0 << 3);
case HDMI_SND_SRC_I2S:
data = 0x0 << 3;
break;
case HDMI_SRC_SPDIF:
data = (0x1 << 3);
case HDMI_SND_SRC_SPDIF:
data = 0x1 << 3;
break;
case HDMI_SRC_DSD:
data = (0x2 << 3);
case HDMI_SND_SRC_DSD:
data = 0x2 << 3;
break;
case HDMI_SRC_HBR:
data = (0x3 << 3);
case HDMI_SND_SRC_HBR:
data = 0x3 << 3;
break;
}
hdmi_write(hdmi, data, HDMI_AUDIO_SETTING_1);