From e3f87b092fc910b40e9395d71d97884e43addffd Mon Sep 17 00:00:00 2001 From: Elliot Berman Date: Thu, 13 Feb 2020 15:37:11 -0800 Subject: [PATCH] soc: qcom: Remove incorrect error check from Guest VM PIL Loader Incorrect error check and return value in guestvm_load_start causes kernel to loop this function indefinitely. Change-Id: I483cc084b4caa02c3478abcc856123dfa14216e9 Signed-off-by: Elliot Berman --- drivers/soc/qcom/guestvm_loader.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soc/qcom/guestvm_loader.c b/drivers/soc/qcom/guestvm_loader.c index 2a09fcc30cba..201d0f33bec5 100644 --- a/drivers/soc/qcom/guestvm_loader.c +++ b/drivers/soc/qcom/guestvm_loader.c @@ -82,8 +82,8 @@ static ssize_t guestvm_load_start(struct kobject *kobj, priv = container_of(kobj, struct guestvm_loader_private, vm_loader_kobj); - if (ret != 1 || priv->vm_loaded) { - dev_err(priv->dev, "invalid arguments for guestvm_loader.\n"); + if (priv->vm_loaded) { + dev_err(priv->dev, "VM load has already been started\n"); return -EINVAL; } @@ -99,7 +99,7 @@ static ssize_t guestvm_load_start(struct kobject *kobj, schedule_work(&priv->vm_loader_work); } - return ret; + return count; } static struct kobj_attribute guestvm_loader_attribute = __ATTR(boot_guestvm, 0220, NULL, guestvm_load_start);