From e57b2b062ec19f9c6e09af2298072b3d1768cfe0 Mon Sep 17 00:00:00 2001 From: Raviteja Laggyshetty Date: Tue, 2 May 2023 14:45:42 +0530 Subject: [PATCH] interconnect: qcom: holi: fix UAF under remove function UAF is observed while unloading the interconnect driver. Interconnect is core to the system and should not be unloaded once it is probed. Marking the driver as permanent by removing the module_exit function. Change-Id: If4ddebec67f008e5412c1bf03bed0693fcaaffe0 Signed-off-by: Raviteja Laggyshetty --- drivers/interconnect/qcom/holi.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/interconnect/qcom/holi.c b/drivers/interconnect/qcom/holi.c index a6a92e8719c8..8503687a1cd5 100644 --- a/drivers/interconnect/qcom/holi.c +++ b/drivers/interconnect/qcom/holi.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-only /* * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved. + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. * */ @@ -1868,11 +1869,5 @@ static int __init qnoc_driver_init(void) } core_initcall(qnoc_driver_init); -static void __exit qnoc_driver_exit(void) -{ - platform_driver_unregister(&qnoc_driver); -} -module_exit(qnoc_driver_exit); - MODULE_DESCRIPTION("Holi NoC driver"); MODULE_LICENSE("GPL v2");