From e5fa197b07c12bb2854b2e82bd2a17533b18916f Mon Sep 17 00:00:00 2001 From: Dustin Brown Date: Mon, 13 Aug 2018 14:28:55 -0700 Subject: [PATCH] Revert "qcacld-3.0: Collect F/W dump when host F/W out of sync" Revert I457c20f6ba908cac32cfc9b27fbaf980f1ec174d, which removes the check to ensure recovery has been enabled via configuration before starting the recovery process. This is a critical feature for internal debugging. The check was moved into cds_trigger_recovery() to prevent callers from bypassing this configuration and unconditionally asserting the target firmware. Restore that check now. Change-Id: Ieb347cfcd0eecd24f005d374c0fead07c34f3705 CRs-Fixed: 2296038 --- core/cds/src/cds_api.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/core/cds/src/cds_api.c b/core/cds/src/cds_api.c index 9e16a6c2b895..92c5b575486c 100644 --- a/core/cds/src/cds_api.c +++ b/core/cds/src/cds_api.c @@ -1796,6 +1796,12 @@ static void cds_trigger_recovery_work(void *param) return; } + if (!cds_is_self_recovery_enabled()) { + cds_err("Recovery is not enabled"); + QDF_BUG(0); + return; + } + qdf = cds_get_context(QDF_MODULE_ID_QDF_DEVICE); if (!qdf) { cds_err("Qdf context is null");