From e6403310abccc1af37bd3bb3536876701ceb365f Mon Sep 17 00:00:00 2001 From: Min Liu Date: Tue, 28 Aug 2018 17:57:12 +0800 Subject: [PATCH] qcacmn: remove time-consuming debug log print format "pS" in module will call module_address_lookup in kernel, which will disable preempt. This could result in some performance issues, like block rt task vsync_retire_work and then cause janks. Change-Id: Ic334490b607d2fcee9eede2a0175c0f92cfc7ffd CRs-Fixed: 2304391 --- os_if/linux/wlan_osif_request_manager.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/os_if/linux/wlan_osif_request_manager.c b/os_if/linux/wlan_osif_request_manager.c index 6943fae1a24f..448b8532dc5d 100644 --- a/os_if/linux/wlan_osif_request_manager.c +++ b/os_if/linux/wlan_osif_request_manager.c @@ -83,15 +83,14 @@ struct osif_request *osif_request_alloc(const struct osif_request_params *params struct osif_request *request; if (!is_initialized) { - cfg80211_err("invoked when not initialized from %pS", - (void *)_RET_IP_); + cfg80211_err("invoked when not initialized"); return NULL; } length = sizeof(*request) + params->priv_size; request = qdf_mem_malloc(length); if (!request) { - cfg80211_err("allocation failed for %pS", (void *)_RET_IP_); + cfg80211_err("allocation failed"); return NULL; } request->reference_count = 1; @@ -101,8 +100,8 @@ struct osif_request *osif_request_alloc(const struct osif_request_params *params request->cookie = cookie++; qdf_list_insert_back(&requests, &request->node); qdf_spin_unlock_bh(&spinlock); - cfg80211_debug("request %pK, cookie %pK, caller %pS", - request, request->cookie, (void *)_RET_IP_); + cfg80211_debug("request %pK, cookie %pK", + request, request->cookie); return request; } @@ -123,8 +122,7 @@ struct osif_request *osif_request_get(void *cookie) struct osif_request *request; if (!is_initialized) { - cfg80211_err("invoked when not initialized from %pS", - (void *)_RET_IP_); + cfg80211_err("invoked when not initialized"); return NULL; } qdf_spin_lock_bh(&spinlock); @@ -132,8 +130,8 @@ struct osif_request *osif_request_get(void *cookie) if (request) request->reference_count++; qdf_spin_unlock_bh(&spinlock); - cfg80211_debug("cookie %pK, request %pK, caller %pS", - cookie, request, (void *)_RET_IP_); + cfg80211_debug("cookie %pK, request %pK", + cookie, request); return request; } @@ -142,8 +140,8 @@ void osif_request_put(struct osif_request *request) { bool unlinked = false; - cfg80211_debug("request %pK, cookie %pK, caller %pS", - request, request->cookie, (void *)_RET_IP_); + cfg80211_debug("request %pK, cookie %pK", + request, request->cookie); qdf_spin_lock_bh(&spinlock); request->reference_count--; if (0 == request->reference_count) { @@ -172,7 +170,6 @@ void osif_request_complete(struct osif_request *request) void osif_request_manager_init(void) { - cfg80211_debug("%pS", (void *)_RET_IP_); if (is_initialized) return; @@ -190,6 +187,5 @@ void osif_request_manager_init(void) */ void osif_request_manager_deinit(void) { - cfg80211_debug("%pS", (void *)_RET_IP_); is_initialized = false; }