From e673511908684c3b92340e212543959e39af3181 Mon Sep 17 00:00:00 2001 From: Amruta Kulkarni Date: Fri, 3 Jan 2020 13:55:59 -0800 Subject: [PATCH] qcacld-3.0: Change info/err prints to debug in roaming path In roaming path, while processing roam synch indication info/err prints at the driver adds up latency to the total roaming transition time and the KPI for maximum transition time exceeds the expected 100ms. The printk buffer is protected by a global raw spinlock for readers and writers. This restricts the contexts that are allowed to access the buffer. So large latencies exists when printing to kmsg done with QDF trace levels WARN, INFO, ERROR. Change the redundant/less significant info, error, warn level prints in roaming path to debug level. Change-Id: I8e2a03ddef8f3cd680263939f6e0275b8703e681 CRs-Fixed: 2597624 --- components/blacklist_mgr/core/src/wlan_blm_core.c | 4 ++-- core/hdd/src/wlan_hdd_stats.c | 4 ++-- core/mac/src/pe/lim/lim_process_assoc_rsp_frame.c | 4 ++-- core/sme/src/qos/sme_qos.c | 6 +++--- core/wma/src/wma_dev_if.c | 4 ++-- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/components/blacklist_mgr/core/src/wlan_blm_core.c b/components/blacklist_mgr/core/src/wlan_blm_core.c index 87d3d8cae6c5..f12eddd0b01b 100644 --- a/components/blacklist_mgr/core/src/wlan_blm_core.c +++ b/components/blacklist_mgr/core/src/wlan_blm_core.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2011-2019 The Linux Foundation. All rights reserved. + * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -244,7 +244,7 @@ blm_filter_bssid(struct wlan_objmgr_pdev *pdev, qdf_list_t *scan_list) qdf_list_node_t *cur_node = NULL, *next_node = NULL; if (!scan_list || !qdf_list_size(scan_list)) { - blm_err("Scan list is NULL or No BSSIDs present"); + blm_debug("Scan list is NULL or No BSSIDs present"); return QDF_STATUS_E_EMPTY; } diff --git a/core/hdd/src/wlan_hdd_stats.c b/core/hdd/src/wlan_hdd_stats.c index 8ca1aa6cb1da..1cb90317a273 100644 --- a/core/hdd/src/wlan_hdd_stats.c +++ b/core/hdd/src/wlan_hdd_stats.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012-2019 The Linux Foundation. All rights reserved. + * Copyright (c) 2012-2020 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -5025,7 +5025,7 @@ static int __wlan_hdd_cfg80211_dump_survey(struct wiphy *wiphy, return -ENONET; if (sta_ctx->hdd_reassoc_scenario) { - hdd_info("Roaming in progress, hence return"); + hdd_debug("Roaming in progress, hence return"); return -ENONET; } diff --git a/core/mac/src/pe/lim/lim_process_assoc_rsp_frame.c b/core/mac/src/pe/lim/lim_process_assoc_rsp_frame.c index 80a5e41721be..a67dafcbd4b3 100644 --- a/core/mac/src/pe/lim/lim_process_assoc_rsp_frame.c +++ b/core/mac/src/pe/lim/lim_process_assoc_rsp_frame.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2011-2019 The Linux Foundation. All rights reserved. + * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -385,7 +385,7 @@ static void lim_update_ese_tsm(struct mac_context *mac_ctx, * Ie is present in the reassoc rsp */ if (!assoc_rsp->tspecPresent) { - pe_err("TSM present but TSPEC IE not present"); + pe_debug("TSM present but TSPEC IE not present"); return; } tsm_ctx = &session_entry->eseContext.tsm; diff --git a/core/sme/src/qos/sme_qos.c b/core/sme/src/qos/sme_qos.c index 56673e16c1df..425f372a1d5e 100644 --- a/core/sme/src/qos/sme_qos.c +++ b/core/sme/src/qos/sme_qos.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012-2019 The Linux Foundation. All rights reserved. + * Copyright (c) 2012-2020 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -3359,7 +3359,7 @@ static void sme_qos_fill_aggr_info(int ac_id, int ts_id, tSirAggrQosReq *msg, struct sme_qos_sessioninfo *session) { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_WARN, + QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_DEBUG, FL("Found tspec entry AC=%d, flow=%d, direction = %d"), ac_id, ts_id, direction); @@ -3451,7 +3451,7 @@ static QDF_STATUS sme_qos_ft_aggr_qos_req(struct mac_context *mac_ctx, uint8_t } } - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_INFO, + QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_DEBUG, FL("Sending aggregated message to HAL 0x%x"), aggr_req->aggrInfo.tspecIdx); diff --git a/core/wma/src/wma_dev_if.c b/core/wma/src/wma_dev_if.c index 2873fe1bb20f..acd68a8b1c3e 100644 --- a/core/wma/src/wma_dev_if.c +++ b/core/wma/src/wma_dev_if.c @@ -4358,8 +4358,8 @@ static void wma_add_sta_req_sta_mode(tp_wma_handle wma, tpAddStaParams params) } if (wma_is_vdev_up(params->smesessionId)) { - WMA_LOGE("%s: vdev id %d is already UP for %pM", __func__, - params->smesessionId, params->bssId); + WMA_LOGD("%s: vdev id %d is already UP for %pM", __func__, + params->smesessionId, params->bssId); status = QDF_STATUS_E_FAILURE; goto out; }