A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-09 13:49:24 -04:00
Code Issues Projects Releases Packages Wiki Activity

usb: gadget: Give back request from ep_dequeue

Browse source 
Consider a case where DWC3_DEPCMD_ENDTRANSFER command times out,
then controller will not receive DWC3_DEPEVT_EPCMDCMPLT event and
request queued will not be given back to the function driver from
remove_requests. Now, if a function driver(e.g mass storage)
tries to dequeue the request, gadget driver will move the request
from started_list to cancelled_list but will not giveback the
request to function driver causing it to wait forever for the
transfer to be completed. This can lead the tasks to be in hung
state causing a crash.

Fix this by giving back the request from ep_dequeue by cleaning up
the cancelled requests.

Change-Id: I08b7a766d34992808260788a907054c835402c45
Signed-off-by: Pratham Pratap <prathampratap@codeaurora.org>
This commit is contained in:
Pratham Pratap 2021-02-25 21:04:05 +05:30 • committed by Gerrit - the friendly Code Review server
commit eec9afd56c
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
drivers/usb/dwc3/gadget.c
View file

@ -1779,6 +1779,12 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
list_for_each_entry_safe(r, t, &dep->started_list, list)
dwc3_gadget_move_cancelled_request(r);
/* If ep isn't started, then there's no end transfer
* pending
*/
if (!(dep->flags & DWC3_EP_END_TRANSFER_PENDING))
dwc3_gadget_ep_cleanup_cancelled_requests(dep);
goto out;
}
}