A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-07 20:33:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

cnss2: Skip the dump segment if memory allocation fails

Browse source 
Avoid accessing NULL pointer if memory allocation fails for
a dump segment.

Change-Id: Ie2c501b619c361b9a108abf6ff41ecefa2e81c44
Signed-off-by: Yue Ma <yuem@codeaurora.org>
This commit is contained in:
Yue Ma 2021-03-22 17:52:37 -07:00 • committed by Gerrit - the friendly Code Review server
commit eed205c3f6
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
drivers/net/wireless/cnss2/main.c
View file

@ -2131,13 +2131,15 @@ int cnss_do_elf_ramdump(struct cnss_plat_data *plat_priv)
continue;
}
seg = kcalloc(1, sizeof(*seg), GFP_KERNEL);
if (!seg)
continue;
if (meta_info.entry[dump_seg->type].entry_start == 0) {
meta_info.entry[dump_seg->type].type = dump_seg->type;
meta_info.entry[dump_seg->type].entry_start = i + 1;
}
meta_info.entry[dump_seg->type].entry_num++;
seg = kcalloc(1, sizeof(*seg), GFP_KERNEL);
seg->da = dump_seg->address;
seg->va = dump_seg->v_address;
seg->size = dump_seg->size;
@ -2145,16 +2147,19 @@ int cnss_do_elf_ramdump(struct cnss_plat_data *plat_priv)
dump_seg++;
}
seg = kcalloc(1, sizeof(*seg), GFP_KERNEL);
if (!seg)
goto do_elf_dump;
meta_info.magic = CNSS_RAMDUMP_MAGIC;
meta_info.version = CNSS_RAMDUMP_VERSION;
meta_info.chipset = plat_priv->device_id;
meta_info.total_entries = CNSS_FW_DUMP_TYPE_MAX;
seg = kcalloc(1, sizeof(*seg), GFP_KERNEL);
seg->va = &meta_info;
seg->size = sizeof(meta_info);
list_add(&seg->node, &head);
do_elf_dump:
ret = do_elf_dump(&head, info_v2->ramdump_dev);
while (!list_empty(&head)) {