diff --git a/target_if/core/inc/target_if.h b/target_if/core/inc/target_if.h index 4e539f0146a0..045e62b80015 100644 --- a/target_if/core/inc/target_if.h +++ b/target_if/core/inc/target_if.h @@ -497,7 +497,7 @@ bool target_is_tgt_type_qca9888(uint32_t target_type); static inline void target_psoc_set_wlan_init_status (struct target_psoc_info *psoc_info, uint32_t wlan_init_status) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.wlan_init_status = wlan_init_status; @@ -514,7 +514,7 @@ static inline void target_psoc_set_wlan_init_status static inline uint32_t target_psoc_get_wlan_init_status (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return (uint32_t)-1; return psoc_info->info.wlan_init_status; @@ -532,7 +532,7 @@ static inline uint32_t target_psoc_get_wlan_init_status static inline void target_psoc_set_target_type (struct target_psoc_info *psoc_info, uint32_t target_type) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.target_type = target_type; @@ -549,7 +549,7 @@ static inline void target_psoc_set_target_type static inline uint32_t target_psoc_get_target_type (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return (uint32_t)-1; return psoc_info->info.target_type; @@ -567,7 +567,7 @@ static inline uint32_t target_psoc_get_target_type static inline void target_psoc_set_max_descs (struct target_psoc_info *psoc_info, uint32_t max_descs) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.max_descs = max_descs; @@ -584,7 +584,7 @@ static inline void target_psoc_set_max_descs static inline uint32_t target_psoc_get_max_descs (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return (uint32_t)-1; return psoc_info->info.max_descs; @@ -602,7 +602,7 @@ static inline uint32_t target_psoc_get_max_descs static inline void target_psoc_set_wmi_service_ready (struct target_psoc_info *psoc_info, bool wmi_service_ready) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.wmi_service_ready = wmi_service_ready; @@ -634,7 +634,7 @@ static inline bool target_psoc_get_wmi_service_ready static inline void target_psoc_set_wmi_ready (struct target_psoc_info *psoc_info, bool wmi_ready) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.wmi_ready = wmi_ready; @@ -666,7 +666,7 @@ static inline bool target_psoc_get_wmi_ready static inline void target_psoc_set_preferred_hw_mode( struct target_psoc_info *psoc_info, uint32_t preferred_hw_mode) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.preferred_hw_mode = preferred_hw_mode; @@ -683,7 +683,7 @@ static inline void target_psoc_set_preferred_hw_mode( static inline uint32_t target_psoc_get_preferred_hw_mode (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return WMI_HOST_HW_MODE_MAX; return psoc_info->info.preferred_hw_mode; @@ -718,7 +718,7 @@ static inline struct target_supported_modes *target_psoc_get_supported_hw_modes static inline void target_psoc_set_wmi_timeout (struct target_psoc_info *psoc_info, uint32_t wmi_timeout) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.wmi_timeout = wmi_timeout; @@ -735,7 +735,7 @@ static inline void target_psoc_set_wmi_timeout static inline uint32_t target_psoc_get_wmi_timeout (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return (uint32_t)-1; return psoc_info->info.wmi_timeout; @@ -753,7 +753,7 @@ static inline uint32_t target_psoc_get_wmi_timeout static inline void target_psoc_set_total_mac_phy_cnt (struct target_psoc_info *psoc_info, uint8_t total_mac_phy_cnt) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.total_mac_phy_cnt = total_mac_phy_cnt; @@ -770,7 +770,7 @@ static inline void target_psoc_set_total_mac_phy_cnt static inline uint8_t target_psoc_get_total_mac_phy_cnt( struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return 0; return psoc_info->info.total_mac_phy_cnt; @@ -788,7 +788,7 @@ static inline uint8_t target_psoc_get_total_mac_phy_cnt( static inline void target_psoc_set_num_radios( struct target_psoc_info *psoc_info, uint8_t num_radios) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.num_radios = num_radios; @@ -805,7 +805,7 @@ static inline void target_psoc_set_num_radios( static inline uint8_t target_psoc_get_num_radios (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return 0; return psoc_info->info.num_radios; @@ -853,7 +853,7 @@ static inline uint32_t *target_psoc_get_service_bitmap static inline void target_psoc_set_num_mem_chunks( struct target_psoc_info *psoc_info, uint32_t num_mem_chunks) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.num_mem_chunks = num_mem_chunks; } @@ -869,7 +869,7 @@ static inline void target_psoc_set_num_mem_chunks( static inline uint32_t target_psoc_get_num_mem_chunks (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return (uint32_t)-1; return psoc_info->info.num_mem_chunks; @@ -887,7 +887,7 @@ static inline void target_psoc_set_hif_hdl (struct target_psoc_info *psoc_info, struct common_hif_handle *hif_hdl) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->hdls.hif_hdl = hif_hdl; @@ -904,7 +904,7 @@ static inline void target_psoc_set_hif_hdl static inline struct common_hif_handle *target_psoc_get_hif_hdl (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return psoc_info->hdls.hif_hdl; @@ -923,7 +923,7 @@ static inline void target_psoc_set_htc_hdl (struct target_psoc_info *psoc_info, struct common_htc_handle *htc_hdl) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->hdls.htc_hdl = htc_hdl; @@ -940,7 +940,7 @@ static inline void target_psoc_set_htc_hdl static inline struct common_htc_handle *target_psoc_get_htc_hdl (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return psoc_info->hdls.htc_hdl; @@ -958,7 +958,7 @@ static inline void target_psoc_set_wmi_hdl (struct target_psoc_info *psoc_info, struct common_wmi_handle *wmi_hdl) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->hdls.wmi_hdl = wmi_hdl; @@ -975,7 +975,7 @@ static inline void target_psoc_set_wmi_hdl static inline struct common_wmi_handle *target_psoc_get_wmi_hdl (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return psoc_info->hdls.wmi_hdl; @@ -994,7 +994,7 @@ static inline void target_psoc_set_accelerator_hdl (struct target_psoc_info *psoc_info, struct common_accelerator_handle *accelerator_hdl) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->hdls.accelerator_hdl = accelerator_hdl; @@ -1012,7 +1012,7 @@ static inline struct common_accelerator_handle *target_psoc_get_accelerator_hdl (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return psoc_info->hdls.accelerator_hdl; @@ -1030,7 +1030,7 @@ struct common_accelerator_handle *target_psoc_get_accelerator_hdl static inline void target_psoc_set_feature_ptr (struct target_psoc_info *psoc_info, void *feature_ptr) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->feature_ptr = feature_ptr; @@ -1047,7 +1047,7 @@ static inline void target_psoc_set_feature_ptr static inline void *target_psoc_get_feature_ptr (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return psoc_info->feature_ptr; @@ -1093,7 +1093,7 @@ static inline uint32_t target_psoc_get_target_ver static inline void target_psoc_set_target_ver (struct target_psoc_info *psoc_info, uint32_t target_ver) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.version.target_ver = target_ver; @@ -1111,7 +1111,7 @@ static inline void target_psoc_set_target_ver static inline void target_psoc_set_target_rev (struct target_psoc_info *psoc_info, uint32_t target_rev) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->info.version.target_rev = target_rev; @@ -1144,7 +1144,7 @@ static inline void target_psoc_set_dbglog_hdl (struct target_psoc_info *psoc_info, struct common_dbglog_handle *dbglog_hdl) { - if (psoc_info == NULL) + if (!psoc_info) return; psoc_info->hdls.dbglog_hdl = dbglog_hdl; @@ -1161,7 +1161,7 @@ static inline void target_psoc_set_dbglog_hdl static inline struct common_dbglog_handle *target_psoc_get_dbglog_hdl (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return psoc_info->hdls.dbglog_hdl; @@ -1178,7 +1178,7 @@ static inline struct common_dbglog_handle *target_psoc_get_dbglog_hdl static inline target_resource_config *target_psoc_get_wlan_res_cfg (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return &psoc_info->info.wlan_res_cfg; @@ -1195,7 +1195,7 @@ static inline target_resource_config *target_psoc_get_wlan_res_cfg static inline wmi_host_ext_resource_config *target_psoc_get_wlan_ext_res_cfg (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return &psoc_info->info.wlan_ext_res_cfg; @@ -1212,7 +1212,7 @@ static inline wmi_host_ext_resource_config *target_psoc_get_wlan_ext_res_cfg static inline qdf_event_t *target_psoc_get_event (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return &psoc_info->info.event; @@ -1229,7 +1229,7 @@ static inline qdf_event_t *target_psoc_get_event static inline struct wlan_psoc_target_capability_info *target_psoc_get_target_caps(struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return &psoc_info->info.target_caps; @@ -1247,7 +1247,7 @@ static inline struct wlan_psoc_host_service_ext_param *target_psoc_get_service_ext_param (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return &psoc_info->info.service_ext_param; @@ -1265,7 +1265,7 @@ static inline struct wlan_psoc_host_service_ext_param static inline struct wlan_psoc_host_mac_phy_caps *target_psoc_get_mac_phy_cap (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return psoc_info->info.mac_phy_cap; @@ -1282,7 +1282,7 @@ static inline struct wlan_psoc_host_mac_phy_caps *target_psoc_get_mac_phy_cap static inline struct wlan_psoc_host_dbr_ring_caps *target_psoc_get_dbr_ring_caps(struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return psoc_info->info.dbr_ring_cap; @@ -1317,7 +1317,7 @@ static inline struct wlan_psoc_host_spectral_scaling_params static inline struct wmi_host_mem_chunk *target_psoc_get_mem_chunks (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return psoc_info->info.mem_chunks; @@ -1334,7 +1334,7 @@ static inline struct wmi_host_mem_chunk *target_psoc_get_mem_chunks static inline struct target_ops *target_psoc_get_tif_ops (struct target_psoc_info *psoc_info) { - if (psoc_info == NULL) + if (!psoc_info) return NULL; return psoc_info->tif_ops; @@ -1352,7 +1352,7 @@ static inline struct target_ops *target_psoc_get_tif_ops static inline void target_pdev_set_feature_ptr (struct target_pdev_info *pdev_info, void *feature_ptr) { - if (pdev_info == NULL) + if (!pdev_info) return; pdev_info->feature_ptr = feature_ptr; @@ -1369,7 +1369,7 @@ static inline void target_pdev_set_feature_ptr static inline void *target_pdev_get_feature_ptr (struct target_pdev_info *pdev_info) { - if (pdev_info == NULL) + if (!pdev_info) return NULL; return pdev_info->feature_ptr; @@ -1388,7 +1388,7 @@ static inline void target_pdev_set_wmi_handle (struct target_pdev_info *pdev_info, struct common_wmi_handle *wmi_handle) { - if (pdev_info == NULL) + if (!pdev_info) return; pdev_info->wmi_handle = wmi_handle; @@ -1405,7 +1405,7 @@ static inline void target_pdev_set_wmi_handle static inline struct common_wmi_handle *target_pdev_get_wmi_handle (struct target_pdev_info *pdev_info) { - if (pdev_info == NULL) + if (!pdev_info) return NULL; return pdev_info->wmi_handle; @@ -1424,7 +1424,7 @@ static inline void target_pdev_set_accelerator_hdl (struct target_pdev_info *pdev_info, struct common_accelerator_handle *accelerator_hdl) { - if (pdev_info == NULL) + if (!pdev_info) return; pdev_info->accelerator_hdl = accelerator_hdl; @@ -1441,7 +1441,7 @@ static inline void target_pdev_set_accelerator_hdl static inline struct common_accelerator_handle * target_pdev_get_accelerator_hdl(struct target_pdev_info *pdev_info) { - if (pdev_info == NULL) + if (!pdev_info) return NULL; return pdev_info->accelerator_hdl; @@ -1459,7 +1459,7 @@ target_pdev_get_accelerator_hdl(struct target_pdev_info *pdev_info) static inline void target_pdev_set_pdev_idx (struct target_pdev_info *pdev_info, int32_t pdev_idx) { - if (pdev_info == NULL) + if (!pdev_info) return; pdev_info->pdev_idx = pdev_idx; @@ -1476,7 +1476,7 @@ static inline void target_pdev_set_pdev_idx static inline int32_t target_pdev_get_pdev_idx (struct target_pdev_info *pdev_info) { - if (pdev_info == NULL) + if (!pdev_info) return -EINVAL; return pdev_info->pdev_idx; @@ -1494,7 +1494,7 @@ static inline int32_t target_pdev_get_pdev_idx static inline void target_pdev_set_phy_idx (struct target_pdev_info *pdev_info, int32_t phy_idx) { - if (pdev_info == NULL) + if (!pdev_info) return; pdev_info->phy_idx = phy_idx; @@ -1511,7 +1511,7 @@ static inline void target_pdev_set_phy_idx static inline int32_t target_pdev_get_phy_idx (struct target_pdev_info *pdev_info) { - if (pdev_info == NULL) + if (!pdev_info) return -EINVAL; return pdev_info->phy_idx; @@ -1943,7 +1943,7 @@ static inline QDF_STATUS target_if_sw_version_check( static inline int32_t target_if_get_phy_capability (struct target_psoc_info *target_psoc_info) { - if (target_psoc_info == NULL) + if (!target_psoc_info) return -EINVAL; return target_psoc_info->info.target_caps.phy_capability; @@ -1961,7 +1961,7 @@ static inline int32_t target_if_get_phy_capability static inline void target_if_set_phy_capability (struct target_psoc_info *target_psoc_info, int phy_capability) { - if (target_psoc_info == NULL) + if (!target_psoc_info) return; target_psoc_info->info.target_caps.phy_capability = phy_capability; @@ -1979,7 +1979,7 @@ static inline void target_if_set_phy_capability static inline void target_if_set_max_frag_entry (struct target_psoc_info *target_psoc_info, int max_frag_entry) { - if (target_psoc_info == NULL) + if (!target_psoc_info) return; target_psoc_info->info.target_caps.max_frag_entry = max_frag_entry; @@ -1996,7 +1996,7 @@ static inline void target_if_set_max_frag_entry static inline int32_t target_if_get_max_frag_entry (struct target_psoc_info *target_psoc_info) { - if (target_psoc_info == NULL) + if (!target_psoc_info) return -EINVAL; return target_psoc_info->info.target_caps.max_frag_entry; @@ -2013,7 +2013,7 @@ static inline int32_t target_if_get_max_frag_entry static inline int32_t target_if_get_ht_cap_info (struct target_psoc_info *target_psoc_info) { - if (target_psoc_info == NULL) + if (!target_psoc_info) return -EINVAL; return target_psoc_info->info.target_caps.ht_cap_info; @@ -2030,7 +2030,7 @@ static inline int32_t target_if_get_ht_cap_info static inline int32_t target_if_get_vht_cap_info (struct target_psoc_info *target_psoc_info) { - if (target_psoc_info == NULL) + if (!target_psoc_info) return -EINVAL; return target_psoc_info->info.target_caps.vht_cap_info; @@ -2047,7 +2047,7 @@ static inline int32_t target_if_get_vht_cap_info static inline int32_t target_if_get_num_rf_chains (struct target_psoc_info *target_psoc_info) { - if (target_psoc_info == NULL) + if (!target_psoc_info) return -EINVAL; return target_psoc_info->info.target_caps.num_rf_chains; @@ -2064,7 +2064,7 @@ static inline int32_t target_if_get_num_rf_chains static inline int32_t target_if_get_fw_version (struct target_psoc_info *target_psoc_info) { - if (target_psoc_info == NULL) + if (!target_psoc_info) return 0; return target_psoc_info->info.target_caps.fw_version; @@ -2081,7 +2081,7 @@ static inline int32_t target_if_get_fw_version static inline int32_t target_if_get_wmi_fw_sub_feat_caps (struct target_psoc_info *target_psoc_info) { - if (target_psoc_info == NULL) + if (!target_psoc_info) return -EINVAL; return target_psoc_info->info.target_caps.wmi_fw_sub_feat_caps; @@ -2098,7 +2098,7 @@ static inline int32_t target_if_get_wmi_fw_sub_feat_caps static inline int32_t target_if_get_conc_scan_config_bits (struct target_psoc_info *tgt_hdl) { - if (tgt_hdl == NULL) + if (!tgt_hdl) return -EINVAL; return tgt_hdl->info.service_ext_param.default_conc_scan_config_bits; @@ -2115,7 +2115,7 @@ static inline int32_t target_if_get_conc_scan_config_bits static inline int32_t target_if_get_fw_config_bits (struct target_psoc_info *tgt_hdl) { - if (tgt_hdl == NULL) + if (!tgt_hdl) return -EINVAL; return tgt_hdl->info.service_ext_param.default_fw_config_bits; @@ -2132,7 +2132,7 @@ static inline int32_t target_if_get_fw_config_bits static inline int32_t target_psoc_get_num_hw_modes (struct target_psoc_info *tgt_hdl) { - if (tgt_hdl == NULL) + if (!tgt_hdl) return -EINVAL; return tgt_hdl->info.service_ext_param.num_hw_modes; diff --git a/target_if/direct_buf_rx/src/target_if_direct_buf_rx_api.c b/target_if/direct_buf_rx/src/target_if_direct_buf_rx_api.c index b50ad2d96588..a64bdf3ef8b8 100644 --- a/target_if/direct_buf_rx/src/target_if_direct_buf_rx_api.c +++ b/target_if/direct_buf_rx/src/target_if_direct_buf_rx_api.c @@ -141,7 +141,7 @@ QDF_STATUS direct_buf_rx_target_attach(struct wlan_objmgr_psoc *psoc, { struct direct_buf_rx_psoc_obj *dbr_psoc_obj; - if (hal_soc == NULL || osdev == NULL) { + if (!hal_soc || !osdev) { direct_buf_rx_err("hal soc or osdev is null"); return QDF_STATUS_E_INVAL; } @@ -151,7 +151,7 @@ QDF_STATUS direct_buf_rx_target_attach(struct wlan_objmgr_psoc *psoc, direct_buf_rx_info("Dbr psoc obj %pK", dbr_psoc_obj); - if (dbr_psoc_obj == NULL) { + if (!dbr_psoc_obj) { direct_buf_rx_err("dir buf rx psoc obj is null"); return QDF_STATUS_E_FAILURE; } diff --git a/target_if/direct_buf_rx/src/target_if_direct_buf_rx_main.c b/target_if/direct_buf_rx/src/target_if_direct_buf_rx_main.c index 123b159d48e7..7719fac2021f 100644 --- a/target_if/direct_buf_rx/src/target_if_direct_buf_rx_main.c +++ b/target_if/direct_buf_rx/src/target_if_direct_buf_rx_main.c @@ -47,13 +47,13 @@ static uint8_t get_num_dbr_modules_per_pdev(struct wlan_objmgr_pdev *pdev) psoc = wlan_pdev_get_psoc(pdev); - if (psoc == NULL) { + if (!psoc) { direct_buf_rx_err("psoc is null"); return 0; } tgt_psoc_info = wlan_psoc_get_tgt_if_handle(psoc); - if (tgt_psoc_info == NULL) { + if (!tgt_psoc_info) { direct_buf_rx_err("target_psoc_info is null"); return 0; } @@ -85,13 +85,13 @@ static QDF_STATUS populate_dbr_cap_mod_param(struct wlan_objmgr_pdev *pdev, psoc = wlan_pdev_get_psoc(pdev); - if (psoc == NULL) { + if (!psoc) { direct_buf_rx_err("psoc is null"); return QDF_STATUS_E_INVAL; } tgt_psoc_info = wlan_psoc_get_tgt_if_handle(psoc); - if (tgt_psoc_info == NULL) { + if (!tgt_psoc_info) { direct_buf_rx_err("target_psoc_info is null"); return QDF_STATUS_E_INVAL; } @@ -134,14 +134,14 @@ QDF_STATUS target_if_direct_buf_rx_pdev_create_handler( direct_buf_rx_enter(); - if (pdev == NULL) { + if (!pdev) { direct_buf_rx_err("pdev context passed is null"); return QDF_STATUS_E_INVAL; } psoc = wlan_pdev_get_psoc(pdev); - if (psoc == NULL) { + if (!psoc) { direct_buf_rx_err("psoc is null"); return QDF_STATUS_E_INVAL; } @@ -196,7 +196,7 @@ QDF_STATUS target_if_direct_buf_rx_pdev_destroy_handler( QDF_STATUS status; uint8_t num_modules, mod_idx; - if (pdev == NULL) { + if (!pdev) { direct_buf_rx_err("pdev context passed is null"); return QDF_STATUS_E_INVAL; } @@ -204,7 +204,7 @@ QDF_STATUS target_if_direct_buf_rx_pdev_destroy_handler( dbr_pdev_obj = wlan_objmgr_pdev_get_comp_private_obj(pdev, WLAN_TARGET_IF_COMP_DIRECT_BUF_RX); - if (dbr_pdev_obj == NULL) { + if (!dbr_pdev_obj) { direct_buf_rx_err("dir buf rx object is null"); return QDF_STATUS_E_FAILURE; } @@ -238,7 +238,7 @@ QDF_STATUS target_if_direct_buf_rx_psoc_create_handler( direct_buf_rx_enter(); - if (psoc == NULL) { + if (!psoc) { direct_buf_rx_err("psoc context passed is null"); return QDF_STATUS_E_INVAL; } @@ -328,7 +328,7 @@ static QDF_STATUS target_if_dbr_replenish_ring(struct wlan_objmgr_pdev *pdev, dbr_psoc_obj = wlan_objmgr_psoc_get_comp_private_obj(psoc, WLAN_TARGET_IF_COMP_DIRECT_BUF_RX); - if (dbr_psoc_obj == NULL) { + if (!dbr_psoc_obj) { direct_buf_rx_err("dir buf rx psoc object is null"); return QDF_STATUS_E_FAILURE; } @@ -355,7 +355,7 @@ static QDF_STATUS target_if_dbr_replenish_ring(struct wlan_objmgr_pdev *pdev, hal_srng_access_start(hal_soc, srng); ring_entry = hal_srng_src_get_next(hal_soc, srng); - QDF_ASSERT(ring_entry != NULL); + QDF_ASSERT(ring_entry); dw_lo = (uint64_t)paddr & 0xFFFFFFFF; WMI_HOST_DBR_RING_ADDR_HI_SET(dw_hi, (uint64_t)paddr >> 32); WMI_HOST_DBR_DATA_ADDR_HI_HOST_DATA_SET(dw_hi, cookie); @@ -434,13 +434,13 @@ static QDF_STATUS target_if_dbr_init_ring(struct wlan_objmgr_pdev *pdev, dbr_psoc_obj = wlan_objmgr_psoc_get_comp_private_obj(psoc, WLAN_TARGET_IF_COMP_DIRECT_BUF_RX); - if (dbr_psoc_obj == NULL) { + if (!dbr_psoc_obj) { direct_buf_rx_err("dir buf rx psoc object is null"); return QDF_STATUS_E_FAILURE; } - if (dbr_psoc_obj->hal_soc == NULL || - dbr_psoc_obj->osdev == NULL) { + if (!dbr_psoc_obj->hal_soc || + !dbr_psoc_obj->osdev) { direct_buf_rx_err("dir buf rx target attach failed"); return QDF_STATUS_E_FAILURE; } @@ -677,12 +677,12 @@ QDF_STATUS target_if_direct_buf_rx_module_register( QDF_STATUS status; struct direct_buf_rx_pdev_obj *dbr_pdev_obj; - if (pdev == NULL) { + if (!pdev) { direct_buf_rx_err("pdev context passed is null"); return QDF_STATUS_E_INVAL; } - if (dbr_rsp_handler == NULL) { + if (!dbr_rsp_handler) { direct_buf_rx_err("Response handler is null"); return QDF_STATUS_E_INVAL; } @@ -695,7 +695,7 @@ QDF_STATUS target_if_direct_buf_rx_module_register( dbr_pdev_obj = wlan_objmgr_pdev_get_comp_private_obj(pdev, WLAN_TARGET_IF_COMP_DIRECT_BUF_RX); - if (dbr_pdev_obj == NULL) { + if (!dbr_pdev_obj) { direct_buf_rx_err("dir buf rx object is null"); return QDF_STATUS_E_FAILURE; } @@ -874,7 +874,7 @@ static QDF_STATUS target_if_get_dbr_data(struct wlan_objmgr_pdev *pdev, dbr_psoc_obj = wlan_objmgr_psoc_get_comp_private_obj(psoc, WLAN_TARGET_IF_COMP_DIRECT_BUF_RX); - if (dbr_psoc_obj == NULL) { + if (!dbr_psoc_obj) { direct_buf_rx_err("dir buf rx psoc object is null"); return QDF_STATUS_E_FAILURE; } @@ -949,7 +949,7 @@ static int target_if_direct_buf_rx_rsp_event_handler(ol_scn_t scn, dbr_pdev_obj = wlan_objmgr_pdev_get_comp_private_obj(pdev, WLAN_TARGET_IF_COMP_DIRECT_BUF_RX); - if (dbr_pdev_obj == NULL) { + if (!dbr_pdev_obj) { direct_buf_rx_err("dir buf rx object is null"); wlan_objmgr_pdev_release_ref(pdev, dbr_mod_id); return QDF_STATUS_E_FAILURE; @@ -1066,7 +1066,7 @@ static QDF_STATUS target_if_dbr_deinit_ring(struct wlan_objmgr_pdev *pdev, dbr_psoc_obj = wlan_objmgr_psoc_get_comp_private_obj(psoc, WLAN_TARGET_IF_COMP_DIRECT_BUF_RX); - if (dbr_psoc_obj == NULL) { + if (!dbr_psoc_obj) { direct_buf_rx_err("dir buf rx psoc object is null"); return QDF_STATUS_E_FAILURE; } @@ -1216,7 +1216,7 @@ target_if_direct_buf_rx_get_ring_params(struct wlan_objmgr_pdev *pdev, struct direct_buf_rx_pdev_obj *dbr_pdev_obj; struct direct_buf_rx_module_param *dbr_mod_param; - if (NULL == pdev) { + if (!pdev) { direct_buf_rx_err("pdev context passed is null"); return QDF_STATUS_E_INVAL; } @@ -1224,7 +1224,7 @@ target_if_direct_buf_rx_get_ring_params(struct wlan_objmgr_pdev *pdev, dbr_pdev_obj = wlan_objmgr_pdev_get_comp_private_obj (pdev, WLAN_TARGET_IF_COMP_DIRECT_BUF_RX); - if (NULL == dbr_pdev_obj) { + if (!dbr_pdev_obj) { direct_buf_rx_err("dir buf rx object is null"); return QDF_STATUS_E_FAILURE; } diff --git a/target_if/init_deinit/src/init_cmd_api.c b/target_if/init_deinit/src/init_cmd_api.c index a5c148e110d2..ee7db77e2fd4 100644 --- a/target_if/init_deinit/src/init_cmd_api.c +++ b/target_if/init_deinit/src/init_cmd_api.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018 The Linux Foundation. All rights reserved. + * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -87,7 +87,7 @@ static uint32_t init_deinit_alloc_host_mem_chunk(struct wlan_objmgr_psoc *psoc, while (!info->mem_chunks[idx].vaddr && num_units) { info->mem_chunks[idx].vaddr = qdf_mem_alloc_consistent(qdf_dev, qdf_dev->dev, num_units * unit_len, &paddr); - if (info->mem_chunks[idx].vaddr == NULL) { + if (!info->mem_chunks[idx].vaddr) { if (num_unit_info & HOST_CONTIGUOUS_MEM_CHUNK_REQUIRED) { num_units = 0; diff --git a/target_if/init_deinit/src/service_ready_util.c b/target_if/init_deinit/src/service_ready_util.c index cf906bcc80c2..e6f56698f711 100644 --- a/target_if/init_deinit/src/service_ready_util.c +++ b/target_if/init_deinit/src/service_ready_util.c @@ -570,7 +570,7 @@ QDF_STATUS init_deinit_validate_160_80p80_fw_caps( } reg_cap = ucfg_reg_get_hal_reg_cap(psoc); - if (reg_cap == NULL) { + if (!reg_cap) { target_if_err("reg cap is NULL"); return QDF_STATUS_E_FAILURE; } diff --git a/target_if/spectral/target_if_spectral_phyerr.c b/target_if/spectral/target_if_spectral_phyerr.c index 87d8f49558b2..1e64e9f3b187 100644 --- a/target_if/spectral/target_if_spectral_phyerr.c +++ b/target_if/spectral/target_if_spectral_phyerr.c @@ -1809,7 +1809,7 @@ int target_if_spectral_process_report_gen3( struct spectral_report report; spectral = get_target_if_spectral_handle_from_pdev(pdev); - if (spectral == NULL) { + if (!spectral) { spectral_err("Spectral target object is null"); return -EINVAL; }