From f06184550ad269fdb1fc5f693aea203aad158397 Mon Sep 17 00:00:00 2001 From: Om Prakash Tripathi Date: Thu, 5 Apr 2018 17:24:47 +0530 Subject: [PATCH] qcacmn: Move object ref prints to error level By default object manager log level is error while reference prints use info level. This eventually disables object ref prints. To fix this move ref prints to error level. Change-Id: I87bd589cc0eee3bed4591d5a978cf51840ac6b34 CRs-Fixed: 2219152 --- .../obj_mgr/src/wlan_objmgr_global_obj.c | 4 ++-- .../obj_mgr/src/wlan_objmgr_psoc_obj.c | 22 ++++++++++++------- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/umac/cmn_services/obj_mgr/src/wlan_objmgr_global_obj.c b/umac/cmn_services/obj_mgr/src/wlan_objmgr_global_obj.c index ac302ceab93c..dcd84f98d404 100644 --- a/umac/cmn_services/obj_mgr/src/wlan_objmgr_global_obj.c +++ b/umac/cmn_services/obj_mgr/src/wlan_objmgr_global_obj.c @@ -775,11 +775,11 @@ void wlan_objmgr_print_ref_ids(qdf_atomic_t *id) uint32_t i; uint32_t pending_ref; - obj_mgr_info("Pending references of object"); + obj_mgr_err("Pending references of object"); for (i = 0; i < WLAN_REF_ID_MAX; i++) { pending_ref = qdf_atomic_read(&id[i]); if (pending_ref) - obj_mgr_info("%s -- %d", + obj_mgr_err("%s -- %d", string_from_dbgid(i), pending_ref); } diff --git a/umac/cmn_services/obj_mgr/src/wlan_objmgr_psoc_obj.c b/umac/cmn_services/obj_mgr/src/wlan_objmgr_psoc_obj.c index 7ab431d765c9..4beef5d60f6a 100644 --- a/umac/cmn_services/obj_mgr/src/wlan_objmgr_psoc_obj.c +++ b/umac/cmn_services/obj_mgr/src/wlan_objmgr_psoc_obj.c @@ -1859,15 +1859,19 @@ static void wlan_objmgr_psoc_peer_ref_print(struct wlan_objmgr_psoc *psoc, void *obj, void *args) { struct wlan_objmgr_peer *peer = (struct wlan_objmgr_peer *)obj; + WLAN_OBJ_STATE obj_state; + uint8_t vdev_id; uint8_t *macaddr; wlan_peer_obj_lock(peer); macaddr = wlan_peer_get_macaddr(peer); + obj_state = peer->obj_state; + vdev_id = wlan_vdev_get_id(wlan_peer_get_vdev(peer)); wlan_peer_obj_unlock(peer); - obj_mgr_info("Peer MAC is %02x:%02x:%02x:%02x:%02x:%02x", + obj_mgr_err("Peer MAC is %02x:%02x:%02x:%02x:%02x:%02x state:%d vdev_id:%d", macaddr[0], macaddr[1], macaddr[2], macaddr[3], - macaddr[4], macaddr[5]); + macaddr[4], macaddr[5], obj_state, vdev_id); wlan_objmgr_print_ref_ids(peer->peer_objmgr.ref_id_dbg); } @@ -1875,12 +1879,14 @@ static void wlan_objmgr_psoc_vdev_ref_print(struct wlan_objmgr_psoc *psoc, void *obj, void *args) { struct wlan_objmgr_vdev *vdev = (struct wlan_objmgr_vdev *)obj; + WLAN_OBJ_STATE obj_state; uint8_t id; wlan_vdev_obj_lock(vdev); id = wlan_vdev_get_id(vdev); + obj_state = vdev->obj_state; wlan_vdev_obj_unlock(vdev); - obj_mgr_info("Vdev ID is %d", id); + obj_mgr_err("Vdev ID is %d, state %d", id, obj_state); wlan_objmgr_print_ref_ids(vdev->vdev_objmgr.ref_id_dbg); } @@ -1894,7 +1900,7 @@ static void wlan_objmgr_psoc_pdev_ref_print(struct wlan_objmgr_psoc *psoc, wlan_pdev_obj_lock(pdev); id = wlan_objmgr_pdev_get_pdev_id(pdev); wlan_pdev_obj_unlock(pdev); - obj_mgr_info("pdev ID is %d", id); + obj_mgr_err("pdev ID is %d", id); wlan_objmgr_print_ref_ids(pdev->pdev_objmgr.ref_id_dbg); } @@ -1902,17 +1908,17 @@ static void wlan_objmgr_psoc_pdev_ref_print(struct wlan_objmgr_psoc *psoc, QDF_STATUS wlan_objmgr_print_ref_all_objects_per_psoc( struct wlan_objmgr_psoc *psoc) { - obj_mgr_info("Ref counts of PEER"); + obj_mgr_err("Ref counts of PEER"); wlan_objmgr_iterate_obj_list_all_noref(psoc, WLAN_PEER_OP, wlan_objmgr_psoc_peer_ref_print, NULL); - obj_mgr_info("Ref counts of VDEV"); + obj_mgr_err("Ref counts of VDEV"); wlan_objmgr_iterate_obj_list_all_noref(psoc, WLAN_VDEV_OP, wlan_objmgr_psoc_vdev_ref_print, NULL); - obj_mgr_info("Ref counts of PDEV"); + obj_mgr_err("Ref counts of PDEV"); wlan_objmgr_iterate_obj_list_all_noref(psoc, WLAN_PDEV_OP, wlan_objmgr_psoc_pdev_ref_print, NULL); - obj_mgr_info(" Ref counts of PSOC"); + obj_mgr_err(" Ref counts of PSOC"); wlan_objmgr_print_ref_ids(psoc->soc_objmgr.ref_id_dbg); return QDF_STATUS_SUCCESS;