From f1c46d33ced1fdcd6cf858e9fe3259295cf0150d Mon Sep 17 00:00:00 2001 From: jixj Date: Mon, 16 May 2022 13:59:01 +0800 Subject: [PATCH] mmi_info: Add missing of_node_put() of_find_node_by_path() returns a node point with refcount incremented and need use of_node_put() to decrement refcount Change-Id: Ib1cbdc4c40b1ea5e9bfc1c5d02ddd231185a42b1 Reviewed-on: https://gerrit.mot.com/2269870 SME-Granted: SME Approvals Granted SLTApproved: Slta Waiver Tested-by: Jira Key Reviewed-by: Zhenxin Xi Submit-Approved: Jira Key --- drivers/mmi_info/mmi_info_main.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/mmi_info/mmi_info_main.c b/drivers/mmi_info/mmi_info_main.c index c01183bfe3cb..ca44295b483f 100644 --- a/drivers/mmi_info/mmi_info_main.c +++ b/drivers/mmi_info/mmi_info_main.c @@ -54,15 +54,16 @@ bool mmi_device_is_available(struct device_node *np) } path = prop->value; - mmi_np = of_find_node_by_path(path); - if (mmi_np == NULL) - return false; - mmi_dts = of_prop_next_string(prop, path); if (mmi_dts == NULL) return false; + mmi_np = of_find_node_by_path(path); + if (mmi_np == NULL) + return false; + mmi_dts_val = of_get_property(mmi_np, mmi_dts, &len); + of_node_put(mmi_np); if (mmi_dts_val == NULL || len <= 0) return false; @@ -105,6 +106,7 @@ struct device_node *mmi_check_dynamic_device_node(char *dev_name) return NULL; prop = of_find_property(node, "mmi,dynamic_devices", &len); + of_node_put(node); if (prop == NULL || len < 0) { pr_err("%s: cannot find mmi,dynamic_devices property\n", __func__); return NULL;