From e2aea67ceb926336dd6cfa870d277a2a69947895 Mon Sep 17 00:00:00 2001 From: Yue Ma Date: Wed, 10 Mar 2021 10:19:15 -0800 Subject: [PATCH] cnss2: Avoid dereferencing pointer before NULL check In fs_ready_store(), only dereference plat_priv pointer after NULL check. Change-Id: I222139d02a8cc8aef19e2ff879a953977896a08c Signed-off-by: Yue Ma --- drivers/net/wireless/cnss2/main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/cnss2/main.c b/drivers/net/wireless/cnss2/main.c index 03021d123753..016c8f5a4a59 100644 --- a/drivers/net/wireless/cnss2/main.c +++ b/drivers/net/wireless/cnss2/main.c @@ -2661,13 +2661,13 @@ static ssize_t fs_ready_store(struct device *dev, cnss_pr_dbg("File system is ready, fs_ready is %d, count is %zu\n", fs_ready, count); - if (test_bit(QMI_BYPASS, &plat_priv->ctrl_params.quirks)) { - cnss_pr_dbg("QMI is bypassed.\n"); + if (!plat_priv) { + cnss_pr_err("plat_priv is NULL\n"); return count; } - if (!plat_priv) { - cnss_pr_err("plat_priv is NULL!\n"); + if (test_bit(QMI_BYPASS, &plat_priv->ctrl_params.quirks)) { + cnss_pr_dbg("QMI is bypassed\n"); return count; }