From 612b69bab254526dcf0152a3c26f8fba593e4d55 Mon Sep 17 00:00:00 2001 From: Deepak Kumar Date: Fri, 11 Sep 2020 23:55:00 +0530 Subject: [PATCH] msm; kgsl: Correct secure pagetable pointer check Secure pagetable pointer in case of secure pagetable creation failure is set to ERR_PTR. Correct the secure pagetable pointer check in kgsl_iommu_map_secure_global to avoid invalid pointer access when someone tries to map a secure global buffer. Change-Id: Ic938072e38c410a31158b8ab83f2678b2a64f276 Signed-off-by: Deepak Kumar --- drivers/gpu/msm/kgsl_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/msm/kgsl_iommu.c b/drivers/gpu/msm/kgsl_iommu.c index 2cffb4488c3e..98de4ccd5222 100644 --- a/drivers/gpu/msm/kgsl_iommu.c +++ b/drivers/gpu/msm/kgsl_iommu.c @@ -182,7 +182,7 @@ static int kgsl_iommu_get_gpuaddr(struct kgsl_pagetable *pagetable, static void kgsl_iommu_map_secure_global(struct kgsl_mmu *mmu, struct kgsl_memdesc *memdesc) { - if (!mmu->securepagetable) + if (IS_ERR_OR_NULL(mmu->securepagetable)) return; if (!memdesc->gpuaddr) {