A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-08 12:58:12 -04:00
Code Issues Projects Releases Packages Wiki Activity

USB: configfs: Don't send DISCONNECT uevent during unbind

Browse source 
while testing composition switch from UI, composite driver sending
disconnect event to userspace from function unbind path or from the
bus reset. As per the none composition rules in init.msm.usb.configfs.rc
unbind should happen first and sending the disconnect event to userspace.
Userspace code will starts 1 sec timer for enumeration.

In some cases where adbd is enabled, adbd taking more than 1sec to restart
and causing delay in next composition enumeration. Another case is in RNDIS
composition switch. Where rndis function is taking more time in unbind path
and causing delay for next composition switch.

This results in userpsace timeout (1 second) causing actual composition
enumeration failure and falls back to default composition.

Workaround the issue by not sending disconnect event to userspace on
composition switch from unbind path. Instead send the disconnect event
from USB bus reset so that userspace enable timer starts from bus reset.

Change-Id: I2d1fcaa0704e369204fbba4eceb8ba9b1c525b41
Signed-off-by: Vijayavardhan Vennapusa <vvreddy@codeaurora.org>
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
Signed-off-by: Pratham Pratap <prathampratap@codeaurora.org>
This commit is contained in:
Vijayavardhan Vennapusa 2017-10-30 14:33:51 +05:30 • committed by Gerrit - the friendly Code Review server
commit f7f3dfda59
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
drivers/usb/gadget/configfs.c
View file

@ -85,6 +85,7 @@ struct gadget_info {
struct usb_composite_driver composite;
struct usb_composite_dev cdev;
bool use_os_desc;
bool unbinding;
char b_vendor_code;
char qw_sign[OS_STRING_QW_SIGN_LEN];
spinlock_t spinlock;
@ -277,9 +278,12 @@ static int unregister_gadget(struct gadget_info *gi)
if (!gi->composite.gadget_driver.udc_name)
return -ENODEV;
gi->unbinding = true;
ret = usb_gadget_unregister_driver(&gi->composite.gadget_driver);
if (ret)
return ret;
gi->unbinding = false;
kfree(gi->composite.gadget_driver.udc_name);
gi->composite.gadget_driver.udc_name = NULL;
return 0;
@ -1629,7 +1633,8 @@ static void android_disconnect(struct usb_gadget *gadget)
acc_disconnect();
#endif
gi->connected = 0;
schedule_work(&gi->work);
if (!gi->unbinding)
schedule_work(&gi->work);
composite_disconnect(gadget);
}