From fa90d6210fff3f2002e67d48b74add9e6f9873e9 Mon Sep 17 00:00:00 2001 From: Vignesh Viswanathan Date: Fri, 22 Dec 2017 13:13:26 +0530 Subject: [PATCH] qcacld-3.0: Remove add PMKSA cache logic from connect path Currently host is adding PMKSA cache on bssid from connect request if PMKID is present in the RSNIE. This may cause duplicate entry of PMKSA since supplicant may add the same PMKSA on basis of SSID + cache identifier. This also cause different caches present in driver and supplicant. Setting PMKSA in connect request is not needed since supplicant will always set/delete PMKSA cache using seperate kernel APIs. Add changes to remove set PMKSA logic during connect path and increased PMKSA cache path logging. Change-Id: I7aa13daa59c4221380daebab3bee49de5d681d6b CRs-Fixed: 2054351 --- core/hdd/src/wlan_hdd_cfg80211.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/core/hdd/src/wlan_hdd_cfg80211.c b/core/hdd/src/wlan_hdd_cfg80211.c index 4830b4b2891f..e286d4fc8a7a 100644 --- a/core/hdd/src/wlan_hdd_cfg80211.c +++ b/core/hdd/src/wlan_hdd_cfg80211.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012-2017 The Linux Foundation. All rights reserved. + * Copyright (c) 2012-2018 The Linux Foundation. All rights reserved. * * Previously licensed under the ISC license by Qualcomm Atheros, Inc. * @@ -19100,12 +19100,13 @@ static int wlan_hdd_cfg80211_add_station(struct wiphy *wiphy, static inline bool wlan_hdd_is_pmksa_valid(struct cfg80211_pmksa *pmksa) { if (!pmksa->bssid) { - hdd_err("bssid (%pK) is NULL", - pmksa->bssid); - } else if (!pmksa->ssid || !pmksa->cache_id) { - hdd_err("either ssid (%pK) or cache_id (%pK) are NULL", - pmksa->ssid, pmksa->cache_id); - return false; + hdd_warn("bssid (%pK) is NULL", + pmksa->bssid); + if (!pmksa->ssid || !pmksa->cache_id) { + hdd_err("either ssid (%pK) or cache_id (%pK) are NULL", + pmksa->ssid, pmksa->cache_id); + return false; + } } return true; }