HID: input: Fix NULL pointer dereference when power_supply_register fails

Do not call power_supply_powers() if power_supply_register() failed
earlier. This fixes possible NULL pointer dereference by
power_supply_powers() in such case.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Acked-by: Jiri Kosina <[email protected]>
Signed-off-by: Sebastian Reichel <[email protected]>
This commit is contained in:
Krzysztof Kozlowski 2015-03-23 16:34:51 +01:00 • committed by Sebastian Reichel
commit fbea947c7d

View file

@ -452,10 +452,10 @@ static bool hidinput_setup_battery(struct hid_device *dev, unsigned report_type,
kfree(psy_desc->name);
kfree(psy_desc);
dev->battery = NULL;
} else {
power_supply_powers(dev->battery, &dev->dev);
}
power_supply_powers(dev->battery, &dev->dev);
out:
return true;
}