A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-28 18:51:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

crypto: crc32c - Fix crc32c soft dependency

Browse source 
I don't think it makes sense for a module to have a soft dependency
on itself. This seems quite cyclic by nature and I can't see what
purpose it could serve.

OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
much assumes that some incarnation of the "crc32c" hash algorithm has
been loaded. Therefore it makes sense to have the soft dependency
there (as crc-t10dif does.)

Cc: [email protected]
Cc: Tim Chen <[email protected]>
Cc: "David S. Miller" <[email protected]>
Signed-off-by: Jean Delvare <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
This commit is contained in:
Jean Delvare 2016-01-18 17:06:05 +01:00 • committed by Herbert Xu
commit fd7f672710
2 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lib/libcrc32c.c
View file

@ -74,3 +74,4 @@ module_exit(libcrc32c_mod_fini);
MODULE_AUTHOR("Clay Haapala <[email protected]>");
MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations");
MODULE_LICENSE("GPL");
MODULE_SOFTDEP("pre: crc32c");