mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 19:21:31 -04:00
cs5535-clockevt: Free timer in IRQ setup error path
Due to a hardware limitation cs5535_mfgpt_free_timer() cannot actually release the timer hardware, but it will at least free the now unreferenced struct associated with it so calling it is the cleaner thing to do. Signed-off-by: Jens Rottmann <[email protected]> Acked-by: Andres Salomon <[email protected]> Cc: Jordan Crouse <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: john stultz <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]>
This commit is contained in:
parent
522dba7134
commit
fdb19a6cb4
1 changed files with 5 additions and 3 deletions
|
|
@ -154,14 +154,14 @@ static int __init cs5535_mfgpt_init(void)
|
|||
if (cs5535_mfgpt_setup_irq(timer, MFGPT_CMP2, &timer_irq)) {
|
||||
printk(KERN_ERR DRV_NAME ": Could not set up IRQ %d\n",
|
||||
timer_irq);
|
||||
return -EIO;
|
||||
goto err_timer;
|
||||
}
|
||||
|
||||
/* And register it with the kernel */
|
||||
ret = setup_irq(timer_irq, &mfgptirq);
|
||||
if (ret) {
|
||||
printk(KERN_ERR DRV_NAME ": Unable to set up the interrupt.\n");
|
||||
goto err;
|
||||
goto err_irq;
|
||||
}
|
||||
|
||||
/* Set the clock scale and enable the event mode for CMP2 */
|
||||
|
|
@ -184,8 +184,10 @@ static int __init cs5535_mfgpt_init(void)
|
|||
|
||||
return 0;
|
||||
|
||||
err:
|
||||
err_irq:
|
||||
cs5535_mfgpt_release_irq(cs5535_event_clock, MFGPT_CMP2, &timer_irq);
|
||||
err_timer:
|
||||
cs5535_mfgpt_free_timer(cs5535_event_clock);
|
||||
printk(KERN_ERR DRV_NAME ": Unable to set up the MFGPT clock source\n");
|
||||
return -EIO;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue