From 6044ba189bfd2d93628e55222c0d9570126e4dbf Mon Sep 17 00:00:00 2001 From: Mohammed Siddiq Date: Thu, 28 Jan 2021 15:07:04 +0530 Subject: [PATCH] cnss2: Fix error case print for dev_boot debugfs Add code to fix error case print for dev_boot debugfs. Change-Id: Id73e8d98fa493ff3a7cfe3820e33543aae7091a6 Signed-off-by: Mohammed Siddiq --- drivers/net/wireless/cnss2/debug.c | 45 +++++++++++++++--------------- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/drivers/net/wireless/cnss2/debug.c b/drivers/net/wireless/cnss2/debug.c index d9f4d08fc2d4..2123a7c2efd3 100644 --- a/drivers/net/wireless/cnss2/debug.c +++ b/drivers/net/wireless/cnss2/debug.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/* Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. */ +/* Copyright (c) 2016-2021, The Linux Foundation. All rights reserved. */ #include #include @@ -195,28 +195,29 @@ static ssize_t cnss_dev_boot_debug_write(struct file *fp, CNSS_DRIVER_EVENT_POWER_DOWN, 0, NULL); clear_bit(CNSS_DRIVER_DEBUG, &plat_priv->driver_state); - } - - pci_priv = plat_priv->bus_priv; - if (!pci_priv) - return -ENODEV; - - if (sysfs_streq(cmd, "download")) { - set_bit(CNSS_DRIVER_DEBUG, &plat_priv->driver_state); - ret = cnss_pci_start_mhi(pci_priv); - } else if (sysfs_streq(cmd, "linkup")) { - ret = cnss_resume_pci_link(pci_priv); - } else if (sysfs_streq(cmd, "linkdown")) { - ret = cnss_suspend_pci_link(pci_priv); - } else if (sysfs_streq(cmd, "assert")) { - cnss_pr_info("FW Assert triggered for debug\n"); - ret = cnss_force_fw_assert(&pci_priv->pci_dev->dev); - } else if (sysfs_streq(cmd, "set_cbc_done")) { - cnss_pr_dbg("Force set cold boot cal done status\n"); - set_bit(CNSS_COLD_BOOT_CAL_DONE, &plat_priv->driver_state); } else { - cnss_pr_err("Device boot debugfs command is invalid\n"); - ret = -EINVAL; + pci_priv = plat_priv->bus_priv; + if (!pci_priv) + return -ENODEV; + + if (sysfs_streq(cmd, "download")) { + set_bit(CNSS_DRIVER_DEBUG, &plat_priv->driver_state); + ret = cnss_pci_start_mhi(pci_priv); + } else if (sysfs_streq(cmd, "linkup")) { + ret = cnss_resume_pci_link(pci_priv); + } else if (sysfs_streq(cmd, "linkdown")) { + ret = cnss_suspend_pci_link(pci_priv); + } else if (sysfs_streq(cmd, "assert")) { + cnss_pr_info("FW Assert triggered for debug\n"); + ret = cnss_force_fw_assert(&pci_priv->pci_dev->dev); + } else if (sysfs_streq(cmd, "set_cbc_done")) { + cnss_pr_dbg("Force set cold boot cal done status\n"); + set_bit(CNSS_COLD_BOOT_CAL_DONE, + &plat_priv->driver_state); + } else { + cnss_pr_err("Device boot debugfs command is invalid\n"); + ret = -EINVAL; + } } if (ret < 0)