There were just a few macros being used, remove them and have the places
where they were being used to make the proper kernel api call instead.
Cc: Andreas Dilger <[email protected]>
Cc: Oleg Drokin <[email protected]>
Cc: hpdd-discuss <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
There are only 2 functions that are actually called from it, so move it
to the local place where it is needed, no need for it to be "global" for
the rest of lustre to see it.
Also remove the unneeded EXPORT_SYMBOL() markings for these functions,
as no one else calls them.
Cc: Andreas Dilger <[email protected]>
Cc: Oleg Drokin <[email protected]>
Cc: hpdd-discuss <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The gss code has never been built, there is no Kconfig option for it, so
delete it as code that can not build goes bad really fast.
If someone wants it back, they can revert this and fix any build errors
that might be in it.
Cc: Andreas Dilger <[email protected]>
Cc: Oleg Drokin <[email protected]>
Cc: hpdd-discuss <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
In drivers/staging/lustre/lustre/include there was a bunch of .h files
relying on ccflags to be set up right. Make all of them proper relative
paths so that ccflags for different subdirs can be now removed.
Cc: Andreas Dilger <[email protected]>
Cc: Oleg Drokin <[email protected]>
Cc: hpdd-discuss <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
There were two paths being added, yet only one was needed. Remove both,
and fix up the 3 .c files to point to the location of the needed .h
file.
Cc: Andreas Dilger <[email protected]>
Cc: Oleg Drokin <[email protected]>
Cc: hpdd-discuss <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The lnet code did not even need the cflags setting in the Makefile, so
remove it, as it is not doing anything at all.
Cc: Andreas Dilger <[email protected]>
Cc: Oleg Drokin <[email protected]>
Cc: hpdd-discuss <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
We need to remove the ccflags from the Lustre code as it prevents
individual object files from building properly in the kernel build
system. It also hids the horrid mess that the Lustre include files are
made up of.
Start out by removing the toplevel ccflags variable pointing to
drivers/staging/lustre/include/ as a valid include path. This requires
the absolute include markings of a bunch of .h and .c files, which is
also done here.
Cc: Andreas Dilger <[email protected]>
Cc: Oleg Drokin <[email protected]>
Cc: hpdd-discuss <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The issue was discovered with static analysis and has two instances in
this file. The code looks like this
if (x < 65536000) {
...
} else if (x < 655360000) {
...
} else if (x <= 0xffffffff /* 6553600000 */) {
...
} else if (x <= 0xffffffff /* 65536000000 */) {
...
}
The meaning of this block is to select appropriate clock frequency for
interval timer basing on "x", which is amount of time.
Notes:
1. That last condition matches previous one - that's the issue.
2. Decimal numbers in comments don't match hex numbers in expressions.
But in first case the numbers have same order, while in the second case
the hex number is the same, and the decimal one is 10 times bigger.
3. Actually type of "x" is "unsigned int", so its exact upper limit is
not obviously known.
4. There's no "else" block.
So it makes sense to make an "else" block from last "else if" case. The
code inside the block seems correct for such usage.
[ Actually, get rid of the final "else if" case and change the
next-to-last "else if" case to an "else" as the upper limit of "x" _is_
known to be 0xffffffff (UINT_MAX), which is less than 6553600000 -- Ian ]
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=79871
Reported-by: David Binderman <[email protected]>
Signed-off-by: Andrey Utkin <[email protected]>
Signed-off-by: Ian Abbott <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
s->maxdata for the do subdevice should be 1, however currently it is
being set to 0xffffffff. Fix this.
Signed-off-by: Chase Southwood <[email protected]>
Reviewed-by: Ian Abbott <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
There is no need to test whether devpriv is null in this function. The
check looks left over and we can just remove it.
Signed-off-by: Chase Southwood <[email protected]>
Reviewed-by: Ian Abbott <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The dev->board_name is now initialized by the comedi core before calling
the(*attach) or (*auto_attach) function in a driver. As long as the driver
does no additional probing, it's no longer necessary initialize the board_name.
Signed-off-by: Chase Southwood <[email protected]>
Reviewed-by: Ian Abbott <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This value is only needed for subdevices that support async commands.
The comedi core will default the value to 1 when it is not initialized.
Signed-off-by: Chase Southwood <[email protected]>
Reviewed-by: Ian Abbott <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
patch 'vnt_set_keymode don't save pairwise key entry' caused
a slight regression in access point mode
Only don't save in station mode.
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The default is that all the channels are enabled for rf types
not mentioned here.
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
