Coverting all functions to struct vnt_private in device.h and device_main.c
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
There is already a function to get next TBTT.
Replace code with CARDqGetNextTBTT.
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Replace the variables with u64/__le64.
The endian variant is needed in some places endian correction is
needed.
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
There is a code alignment error after this directive realign
code
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
With struct vnt_mic_hdr replacing pointer assigments in
s_vFillTxKey.
The size of new struture is the same as old with packing
Create the struture rxtx.h where it is only used.
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Add missing __user macro casting in the function wpa_set_keys.
This is okay since the function handles the possibility of
param->u.wpa_key.key and param->u.wpa_key.seq pointing to
kernelspace using a flag, fcpfkernel.
Signed-off-by: Martin Berglund <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This is a patch to the r819xU_phyreg.h file that fixes
commenting style warning
Signed-off-by: Sanjeev Sharma <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Correct coding style errors in rtw_efuse.c. checkpatch.pl reported:
ERROR: that open brace { should be on the previous line
Signed-off-by: Andreas Schlick <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit fixes the checkpath warning 'void function return
statements are not generally useful' caused by the 'return' at the end
of 'void' function.
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit fixes the missing blank lines after declarations checkpath
warnings found in dgnc_cls.c file.
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit fixes the checkpath warning about misused 'volatile'
modifier. In this case the 'volatile' was not needed as it was used
for regular automatic variable. Thos commit removes the 'volatile'.
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit fixes the following checkpath warning in dgnc_neo.c file:
'braces {} are not necessary for single statement blocks'
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit fixes the following checkpath error in dgnc_neo.c file:
'that open brace { should be on the previous line'
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit deals with the checkapth warnings 'missing line after
declarations' in the dgnc_neo.c file.
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit fixes the checkpatch warning:
drivers/staging/dgnc/dgnc_neo.c:37:
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
It turned out that the TODO file contained the invalid information as
some of the work has already been done. This commit updates it with the
current status of what is left to be done.
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit slightly simplifies the sgnc_start() function by
rearranging it. As a result the indentation level is reduced.
This is not the functional change.
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit moves the utility functions out of dgnc_driver.c file and
puts them in the new dgnc_utils.{c,h} files. The accompanying changes
adjust the existing code to work with this design.
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit slightly cleans up the dgnc_driver.c file. The changes
include removing one-line proxy functions as they were not needed.
Additionaly the pci 'remove' function is deleted because it was no
need for it.
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This comit fixes the following sparse warnign:
drivers/staging/dgnc/dgnc_tty.c:572:1:
warning: the frame size of 1060 bytes is larger than 1024 bytes
[-Wframe-larger-than=]
This was caused by having buffer as an automatic variable. This commit
moves it from the stack to the heap.
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit corrects the 'no space before tabs' checkpath warning.
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This commit fixes the following checkpatch warnings:
WARNING: externs should be avoided in .c files
#80: FILE: drivers/staging/dgnc/dgnc_driver.c:80:
+int dgnc_init_module(void);
#81: FILE: drivers/staging/dgnc/dgnc_driver.c:81:
+void dgnc_cleanup_module(void);
This was caused by putting the declarations for module init and module
exit fucntions on the top of the file. The fix removes these
declarations plus it also corrects the type of the init/exit functions.
Due to the dependency between init and exit functions the
dgnc_cleanup_module had to be put first.
Signed-off-by: Konrad Zapalowicz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This is a patch to the nokia_fw.c file that removes an unnecessary return statement found by the checkpatch.pl tool
Signed-off-by: Lars Hamre <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Fix the following sparse warning :
In file included from drivers/staging/wlan-ng/prism2usb.c:5:0:
drivers/staging/wlan-ng/prism2fw.c: In function
‘read_cardpda.constprop.43’:
drivers/staging/wlan-ng/prism2fw.c:792:1: warning: the frame size of
1068 bytes is larger than 1024 bytes [-Wframe-larger-than=]
The variable to 'struct p80211msg_p2req_readpda' was previously being created
on the stack, which inturn exeeded the frame size limit, resulting in a
sparse warning. This patch alloctes the memory to the structure dynamically
and the operations are left unchanged.
Signed-off-by: A Raghavendra Rao <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Use dev_dbg with %*ph format specifier and print_hex_dump_bytes to dump memory
instead of relying on custom macro.
Signed-off-by: Fabio Falzoi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Of_node_put supports NULL as its argument, so the initial test is not
necessary.
Suggested by Uwe Kleine-König.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e;
@@
-if (e)
of_node_put(e);
// </smpl>
Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Make use of the various list helper functions to improve readability.
Signed-off-by: Christoph Jaeger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Use a slab cache rather than rolling our own free list.
Signed-off-by: Christoph Jaeger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Use a slab cache rather than rolling our own free list.
Signed-off-by: Christoph Jaeger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Use a slab cache rather than rolling our own free list.
Signed-off-by: Christoph Jaeger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Simplify the somewhat overcomplicated application interface; improves
readability and saves a bunch of lines.
Use designated struct initializers for clarity.
Signed-off-by: Christoph Jaeger <[email protected]>
Reviewed-by: Dan Carpenter <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
No need to return a value from elt_buf_init().
Signed-off-by: Christoph Jaeger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Member 'ops' has already been initialized by calling cdev_init().
Signed-off-by: Christoph Jaeger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
OZ_MAX_TIMER_POOL_SIZE is not used anywhere; remove it.
Signed-off-by: Christoph Jaeger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
drivers: staging: lustre: fix sparse warning: symbol XYZ was
not declared. Should it be static?
This was done by declaring them static. This could be done because the functions
were used only in this file.
Deleted the function lnet_print_text_bufs because it were unused.
Compiled without an error.
Done to complete a eudyptula task.
Signed-off-by: Benedict Boerger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Remove spaces between the function names and open paranthesis and use the kernel coding style.
Signed-off-by: Tom Wales <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Remove ComputeTxTime since it is not used.
Signed-off-by: Fernando Apesteguia <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This is a patch to the rtl8188e_xmit.c file that fixes up a missing
blank line warning found by the checkpatch.pl tool.
Signed-off-by: Adrian Remonda <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
