Only single element from XGI330_StandTable is used, so the array can be
truncated.
Signed-off-by: Aaro Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Drop code for mode_no <= 14. These are not supported so this is all
just dead code.
Signed-off-by: Aaro Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Unwrap lines to improve readability. Comments were deleted as they were not
really informative.
Signed-off-by: Aaro Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Delete mode names from the table. They are just redundant data.
Signed-off-by: Aaro Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Since the mode search is not string-based anymore, we can drop XxYx24
entries which were just duplicated XxYx32 entries.
Signed-off-by: Aaro Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Eliminate string comparison from the video mode search.
Signed-off-by: Aaro Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The default rate_idx is same for all video modes, no need to keep that
in the table.
Signed-off-by: Aaro Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
XG_41 is not listed in xgifb_pci_table, so the code can be safely dropped.
Signed-off-by: Aaro Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Initialize ModeIdIndex according to the selected video mode. Currently
index 0 is always used and wrong clock data may be used.
Signed-off-by: Aaro Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Initialize ModeIdIndex according to the selected video mode. Currently
index 0 is always used and wrong video mode data may be used.
Signed-off-by: Aaro Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
XGIfb driver transfers integer port number through several typecasts via
pjIOAddress field. Drop that field completely and use vga_base field of
xgifb_info directly.
Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The RelIO field is unused in the driver, drop it.
Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This doesn't happen with the usbip virtual hci module, but another
module wanting to interface with this user space code could cause a
seg-fault by sending data without newlines.
Signed-off-by: Christopher Harvey <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
This patch changes the space of the indent to the tab that warning
found by the checkpatch.pl tool.
Signed-off-by: Hitoshi NAKAMORI<[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The below patch is a resend to fix some typos and comments that
I have found while reading.
Signed-off-by: Justin P. Mattock <[email protected]>
Acked-by: David Daney <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
1. use wd: prefix for all messages
2. fix strings
3. change from dev_dbg to dev_err where appropriate
Signed-off-by: Tomas Winkler <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The function has returned false in both error and success
cases.
1. change return value to int and return appropriate errno
2. use typical Linux kernel error handling.
3. normalize debug messages
Signed-off-by: Tomas Winkler <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
1. use only mei_driver_name and remove define MEI_DRIVER_NAME
2. drop MEI_DEV_NAME and assign device name directly
3. drop mei_driver_string, it is not used
Signed-off-by: Tomas Winkler <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
fix sparse warning:
'amt_wd_dev' was not declared. Should it be static
Signed-off-by: Tomas Winkler <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
one instance of bare printk was forgotten in init.c file
Signed-off-by: Tomas Winkler <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
mei_wd_set_start_timeout is only used from within wd.c
so remove its declaration from interface.h and mark
it static
Signed-off-by: Tomas Winkler <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
define pr_fmt macro and remove mei: from the messages
Signed-off-by: Tomas Winkler <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The below patch fixes a typo that I found while reading.
Signed-off-by: Justin P. Mattock <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
The below patch fixes a typo that I found while reading.
Signed-off-by: Justin P. Mattock <[email protected]>
Acked-by: Chris Kelly <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
stub_shutdown_connection() and vhci_shutdown_connection() use
task_is_dead() before kthread_stop(). This buys nothing and wrong.
kthread_stop() is fine even if this thread is dead. However, if it
is dead nothing protects this task_struct, we shouldn't touch this
memory.
Change the code to do the necessary get_task_struct/put_task_struct.
This patch assumes that
- xxx_shutdown_connection() is always called, so we can't
leak the task_struct.
- kthread_stop_put() can't be called twice on the same task.
Signed-off-by: Oleg Nesterov <[email protected]>
Cc: Tobias Klauser <[email protected]>
Cc: Matt Mooney <[email protected]>,
Signed-off-by: Greg Kroah-Hartman <[email protected]>
In drivers/staging/rtl8192e/rtl8192e/rtl_core.c the follwing printk-message can be found:
printk(KERN_ERR "rtl8193e: Unable to allocate space "
This is quite obviously just a typo, all other similar messages use
"rtl8192e" and the string "rtl8193e" does not occur anywhere else in the
source of the driver.
Signed-off-by: Axel Koellhofer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
