In case of two readers trying to read buffer one acquires spin
lock and populates uci_chan cur_buf and rx_size and local uci_buf.
After first one releases the spin lock other reader populates local
uci_buf with same cur_buf used by first reader. Second reader queues
the buffer to a TRE and releases the spinlock. Now first reader get
the spin lock and ends up copying 0 byte to user space buffer as the
rx_size becomes zero when second reader queues the buffer to transfer
ring. Now first reader queues the same buffer to a different TRE.
When dl xfer completion comes for both TREs, same buffer gets freed up
twice causes the double free. In case of a write it is possible that
two writers can race in case only one TRE is available to transfer the
request, although it does not result into any invalid access issue as in
case of read. Hence acquire channel mutex lock for both read and write
file operations to make sure read and write are done atomically.
Change-Id: I63bccedb28e1bfd59801ccdf642e4f70eb81021d
Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
The qrtr driver can guarantee that the packet gets queued to the socket
but cannot guarantee the client process will get time to run if auto
sleep is enabled. This config will help mitigate missed packets on
systems where auto sleep is too aggressive.
Use the pm_wakeup_ws_event() api so a hard wakeup can be specified.
This will ensure a resume occurs if the data coming in happens while
the device is going into suspend.
Change-Id: Ic596e06e585b3479a6faa1d0210c016fc9138c6e
Signed-off-by: Chris Lew <clew@codeaurora.org>
Before 5.10-rc1, the upstream kernel blocked any compat calls into XFRM
code with EOPNOTSUPP, however Android kernels had been patching this
check out and made userspace match the 64-bit kernel netlink format
instead.
When the new XFRM_USER_COMPAT feature landed, it added a similar check
in two places which returns EOPNOTSUPP only if the XFRM_USER_COMPAT
feature is disabled, however that is currently always the case for
Android kernels and we do not want to filter these callers.
While we work to remove the userspace compatibility mess, disable the
filtering of compat calls when XFRM_USER_COMPAT is disabled. If the
XFRM_USER_COMPAT feature is enabled, nothing changes.
Bug: 163141236
Bug: 172541864
Signed-off-by: Alistair Delva <adelva@google.com>
Change-Id: Ifbea109070650dfcb4f93a3cc692c18a8d11ab44
Add CONFIG_QPNP_QG to enable the QG device present on PM7250B
that can be used on sdxlemur platforms.
Also, add CONFIG_TYPEC and CONFIG_QCOM_POWER_SUPPLY to compile
QG and SMB5 drivers properly.
Change-Id: Ibb8230ccb1366b7f2a04e2ac77b043ece7f463dd
Signed-off-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
Snapshot of PCIe endpoint driver as of msm-4.14.
'commit <adeff59> (""drivers: clk: msm:
fix compilation for non DEBUG_FS build"")'.
The following changes were done:
-Replace msm_bus driver with interconnect framework.
-Remove iommu deprecated API's.
-Fix checkpatch warnings on usage of module param.
-Fix several checkpatch warnings.
Change-Id: I04ee8f5d5802af0aa0cdd607a79c91e3eca7f194
Signed-off-by: Siddartha Mohanadoss <smohanad@codeaurora.org>
This reverts commit fc6d479bac4c756359388647d45f39f08d0c8534. The
functionality offered by this change was not implemented correctly,
so revert it in favor of a different way of addressing the issue
that was supposed to be fixed.
Change-Id: Id061372026dea2960758c4dad0a5e37c2604576e
Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
After giving an abort command, wait for interrupt to
mark the command completion else log it as a failure scenario.
Change-Id: Ifcc6063f6d6b3457a2807ac411873a15fc556578
Signed-off-by: Vipin Deep Kaur <vkaur@codeaurora.org>
Sometimes crashdumper can timeout due to unresponsive hang
scenarios. Hence fill the crash dumper with known pattern to
know the progress of crashdumper before it gets timed out.
Change-Id: I757fa345b4d7db7d7012ff6501b169a562f9b9c6
Signed-off-by: Hareesh Gundu <hareeshg@codeaurora.org>
Enable memshare driver compilation necessary for
allocation of memory for the clients requesting.
Change-Id: Icdc3d836682d323a33e0eabf42abe8fddf5677c7
Signed-off-by: Manoj Prabhu B <bmanoj@codeaurora.org>
Correct the FM port numbers for Chk 3.x.
They are currently reversed.
CRs-Fixed: 2801744
Change-Id: Id713e373b5db015830f9dc597525e1cfd5519888
Signed-off-by: Satish Kodishala <skodisha@codeaurora.org>
Remove linking and create dependency by exporting the function
in synaptics touch driver.
Change-Id: I494d61fafbed516a39972521b14b0bfc2337b3bd
Signed-off-by: Ravikanth Tuniki <rtunik@codeaurora.org>
Add Synaptics Touch Driver as Modules for Holi GKI.
Change-Id: Id40deb882a80624b702731576effd43a6d43da4a
Signed-off-by: Ravikanth Tuniki <rtunik@codeaurora.org>
Certain Type-C USB adapters (which doesn't support PD),
when connected switch the USB port type from USB3 to USB2.
This is because the response for GET_CONNECTOR_STATUS
has empty partner type.
Example UCSI IPC log:
213.212929: sync_write: CONTROL: 12 00 01 00 00 00 00 00
213.216613: read: CCI: 02 09 00 80
213.221135: read: MSG_IN: 00 00 0d 00 00 00 00 00 00
Parsing the logs gives the following information:
Connect Status: connected
Power Operation Mode: USB Type-C Current - 3A
Power Direction: consumer
Connector Partner Type: Reserved
Fix this by checking whether partner change flag is set
and not process if it is not set.
Change-Id: Ic5884f52e3d0c6936eae6a87b2e133d3e2032428
Signed-off-by: Linyu Yuan <linyyuan@codeaurora.org>
Add mutex to protect time sync operation and PCIe bus suspend from
system suspend to avoid race condition between msm_pcie_pm_suspend
and msm_pcie_prevent_l1/allow_l1.
Change-Id: I8ff0f258e8928b97deeada134982ee2cbe93ae9a
Signed-off-by: Yue Ma <yuem@codeaurora.org>
Add partner_change and connect flags when notifying clients
about the partner information.This would be useful for some clients to
modify their state/configuration.
Change-Id: I85b601b7ea60dda2ac630c51a499767f5fb70351
Signed-off-by: Linyu Yuan <linyyuan@codeaurora.org>
This reverts commit 1bed1828a2.
When boot up without USB cable, UCSI_GET_CONNECTOR_STATUS command
will return all zero message,
Example UCSI IPC log:
40.319381997: sync_write: CONTROL: 12 00 01 00 00 00 00 00
40.319507987: read: CCI: 00 09 00 80
40.319620018: read: MSG_IN: 00 00 00 00 00 00 00 00 00
the change will block this message notify client, so revert it.
Change-Id: Ic0f575f1676a03c4ef88ff92a7a38bc2ac74050d
Signed-off-by: Linyu Yuan <linyyuan@codeaurora.org>
Fix build-break for non GKI builds caused by using the
_rcuidle() variant of a vendor hook.
Fixes: bad091cc4b ("ANDROID: vendor_hooks: Add vendor hooks for
getting printk messages")
Signed-off-by: Todd Kjos <tkjos@google.com>
Change-Id: I0dffaf7e0df198a63578818f7c155671efe382b5
Correct the enable/disable bits of dma interrupt registers by
using DMA_IRQ_EN_SET/DMA_IRQ_EN_CLR registers respectively.
Previously DMA_IRQ_EN register was used to set and unset the
dma interrupt register bits but, DMA_IRQ_EN is a read only
register and DMA_IRQ_EN_SET and DMA_IRQ_EN_CLR are the right
registers for setting and unsetting the dma interrupt bits.
Change-Id: I0c873742b32960673320ddc9a9e3c88922a22684
Signed-off-by: Prudhvi Yarlagadda <pyarlaga@codeaurora.org>
Don't queue a new dma rx buffer only when the rx_length_in register
is zero and dma_done interrupt bit is set. The rx_length_in register
shows number of bytes received and this can be zero when dma_done
interrupt bit is set when we give a cancel command.
This helps when there is a race condition between rx data coming into
rx fifo and a cancel_s_cmd is given. The rx data will end up consuming
the rx dma buffer mapped for cancel command and due to this dma engine
will be in active state even though geni goes to inactive state.
Issue is that we get a dma_done interrupt for the previously pending
EOT byte which came for cancel command. And this interrupt will come
when we queue the rx buffer in start_rx and this might cause uart
to read partial data from rx fifo.
Change-Id: Id3d9b32330c1ac4205100a30936bd4015e20f24d
Signed-off-by: Prudhvi Yarlagadda <pyarlaga@codeaurora.org>
This patch adds new IPC log file to dump IRQ registers to know
the interrupt status in dma mode. This will help in debugging
interrupt storm issues in dma mode.
Also increase the IPC log buffer size.
Change-Id: I33a32e8d237769808a9c7553c9c3e6d1024d9f50
Signed-off-by: Chandana Kishori Chiluveru <cchiluve@codeaurora.org>
Check for RX data in rx buffer for faulty transfer and add
delay of 2 msecs delay in order for dma rx transfer
to be actually completed.
Also dump required qup registers when the uart dma rx data is
seen as all zeros.
Change-Id: Ifaa0cb7d22b8419ffacfee7212b0a28ed8ebf2a1
Signed-off-by: Chandana Kishori Chiluveru <cchiluve@codeaurora.org>
Delete l2wb and l3 access pmu events when the governor
is stopped.
Change-Id: If443cb6b53e2ad43ebee04a1fc3274a31b05e5b9
Signed-off-by: Santosh Mardi <gsantosh@codeaurora.org>
Call perf_event_read_local() to update current counter value
in hw_perf_event structure before saving PMU snapshot to
shared memory.
Change-Id: Id5945cd6b6c9fab6f87917224b5b5f54dca5ef9c
Signed-off-by: Santosh Mardi <gsantosh@codeaurora.org>
Enable required drivers for CPUCP communication on
yupik target.
Change-Id: Ia47a867118e3eadf011228ef21c6a2c87ac7efa4
Signed-off-by: Santosh Mardi <gsantosh@codeaurora.org>
Initial support of rimps PLH interface.
This interface exposes sysfs nodes required to configure
PLH running in rimps.
Change-Id: I18a4cfc346b7923dc083a0433a1993df964dba86
Signed-off-by: Gaurav Singh <sgaurav@codeaurora.org>
Fix this link error:
ERROR: modpost: "rcu_idle_enter" [drivers/acpi/processor.ko] undefined!
ERROR: modpost: "rcu_idle_exit" [drivers/acpi/processor.ko] undefined!
when CONFIG_ACPI_PROCESSOR is built as module. PeterZ says that in light
of ARM needing those soon too, they should simply be exported.
Link: https://lore.kernel.org/linux-pm/20200921103741.GC5901@zn.tnic/
Bug: 172034763
Change-Id: I26d516d11edbce673f52df6474f6695c5a1e2b07
(cherry picked from commit 3ad1c8ef083bef96ec922688966484be1039e6b5)
Fixes: 1fecfdbb7acc ("ACPI: processor: Take over RCU-idle for C3-BM idle")
Reported-by: Sven Joachim <svenjoac@gmx.de>
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Paul E. McKenney <paulmckrcu@kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Cheng Jui Wang <cheng-jui.wang@mediatek.com>
Signed-off-by: Chun-Hung Wu <chun-hung.wu@mediatek.com>
