Ira Weiny
49dac5e017
mm/highmem: Lift memcpy_[to|from]_page to core ...
[ Upstream commit bb90d4bc7b6a536b2e4db45f4763e467c2008251 ]
Working through a conversion to a call kmap_local_page() instead of
kmap() revealed many places where the pattern kmap/memcpy/kunmap
occurred.
Eric Biggers, Matthew Wilcox, Christoph Hellwig, Dan Williams, and Al
Viro all suggested putting this code into helper functions. Al Viro
further pointed out that these functions already existed in the iov_iter
code.[1]
Various locations for the lifted functions were considered.
Headers like mm.h or string.h seem ok but don't really portray the
functionality well. pagemap.h made some sense but is for page cache
functionality.[2]
Another alternative would be to create a new header for the promoted
memcpy functions, but it masks the fact that these are designed to copy
to/from pages using the kernel direct mappings and complicates matters
with a new header.
Placing these functions in 'highmem.h' is suboptimal especially with the
changes being proposed in the functionality of kmap. From a caller
perspective including/using 'highmem.h' implies that the functions
defined in that header are only required when highmem is in use which is
increasingly not the case with modern processors. However, highmem.h is
where all the current functions like this reside (zero_user(),
clear_highpage(), clear_user_highpage(), copy_user_highpage(), and
copy_highpage()). So it makes the most sense even though it is
distasteful for some.[3]
Lift memcpy_to_page() and memcpy_from_page() to pagemap.h.
[1] https://lore.kernel.org/lkml/20201013200149.GI3576660@ZenIV.linux.org.uk/
https://lore.kernel.org/lkml/20201013112544.GA5249@infradead.org/
[2] https://lore.kernel.org/lkml/20201208122316.GH7338@casper.infradead.org/
[3] https://lore.kernel.org/lkml/20201013200149.GI3576660@ZenIV.linux.org.uk/#t
https://lore.kernel.org/lkml/20201208163814.GN1563847@iweiny-DESK2.sc.intel.com/
Cc: Boris Pismenny <borisp@mellanox.com>
Cc: Or Gerlitz <gerlitz.or@gmail.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Suggested-by: Matthew Wilcox <willy@infradead.org>
Suggested-by: Christoph Hellwig <hch@infradead.org>
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Suggested-by: Eric Biggers <ebiggers@kernel.org>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Stable-dep-of: 956510c0c743 ("fs: ext4: initialize fsdata in pagecache_write()")
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-01-18 11:41:55 +01:00
lib: 842: no need to check return value of debugfs_create functions
2019-07-03 16:57:17 +02:00
lib/crypto: blake2s: move hmac construction into wireguard
2022-06-22 14:11:02 +02:00
dim: initialize all struct fields
2022-05-18 09:47:25 +02:00
lib/fonts: fix undefined behavior in bit shift for get_default_font
2023-01-18 11:40:54 +01:00
livepatch: Proper error handling in the shadow variables selftest
2019-02-06 11:01:57 +01:00
lz4: fix LZ4_decompress_safe_partial read out of bound
2022-04-15 14:18:39 +02:00
lib/lzo: fix ambiguous encoding bug in lzo-rle
2020-06-17 16:40:28 +02:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
lib/mpi: use kcalloc in mpi_resize
2021-09-15 09:47:29 +02:00
lib/raid6/test/Makefile: Use $(pound) instead of \# for Make 4.3
2022-04-15 14:18:23 +02:00
rslib: Make some functions static
2019-07-02 08:41:37 +02:00
lib/vdso: use "grep -E" instead of "egrep"
2022-12-08 11:22:59 +01:00
lib/xz: Validate the value before assigning it to an enum variable
2021-11-17 09:48:31 +01:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
lib/zlib: remove outdated and incorrect pre-increment optimization
2020-06-24 17:50:39 +02:00
lib/zstd/mem.h: replace __inline by inline
2019-09-15 19:42:16 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 120
2019-05-24 17:39:02 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 120
2019-05-24 17:39:02 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36
2019-05-24 17:27:11 +02:00
assoc_array: Fix BUG_ON during garbage collect
2022-06-06 08:33:50 +02:00
locking/atomic: Use s64 for atomic64
2019-06-03 12:32:56 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cpumask: Implement cpumask_or_equal()
2019-07-25 15:47:37 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 372
2019-06-05 17:37:10 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 431
2019-06-05 17:37:16 +02:00
bug: Remove redundant condition check in report_bug
2021-05-14 09:44:27 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36
2019-05-24 17:27:11 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230
2019-06-19 17:09:06 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 120
2019-05-24 17:39:02 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
treewide: add checks for the return value of memblock_alloc*()
2019-03-12 10:04:02 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230
2019-06-19 17:09:06 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230
2019-06-19 17:09:06 +02:00
crc-t10dif: Fix potential crypto notify dead-lock
2020-08-19 08:15:54 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230
2019-06-19 17:09:06 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230
2019-06-19 17:09:06 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230
2019-06-19 17:09:06 +02:00
lib/crc32.c: fix trivial typo in preprocessor condition
2020-10-29 09:57:52 +01:00
lib/crc32test: remove extra local_irq_disable/enable
2020-11-10 12:37:27 +01:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
debugobjects: Fix various data races
2020-02-24 08:36:52 +01:00
lib/decompress_unlz4.c: correctly handle zero-padding around initrds.
2021-07-20 16:10:46 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 95
2019-05-24 17:37:53 +02:00
lib/xz: Avoid overlapping memcpy() with invalid input with in-place decompression
2021-11-17 09:48:31 +01:00
devres: keep both device name and resource name in pretty name
2020-08-21 13:05:32 +02:00
Revert "Merge tag 'keys-acl-20190703' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs"
2019-07-10 18:43:43 -07:00
dump_stack: avoid the livelock of the dump_lock
2019-11-06 08:47:50 -08:00
dyndbg: let query-modname override actual module name
2022-10-26 13:22:37 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 283
2019-06-05 17:36:37 +02:00
treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively
2019-04-09 14:19:06 +02:00
lib/extable.c: add missing prototypes
2019-09-25 17:51:39 -07:00
fault-inject: clean up debugfs file creation logic
2019-06-18 13:47:24 +02:00
uapi: rename ext2_swab() to swab() and share globally in swab.h
2020-04-13 10:48:07 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295
2019-06-05 17:36:38 +02:00
lib: don't depend on linux headers being installed.
2018-12-29 11:36:44 -08:00
lib/genalloc: fix the overflow when size is too big
2021-01-12 20:16:10 +01:00
lib/generic-radix-tree.c: add kmemleak annotations
2019-10-14 15:04:00 -07:00
hex2bin: fix access beyond string end
2022-05-09 09:03:22 +02:00
x86/kconfig: Disable CONFIG_GENERIC_HWEIGHT and remove __HAVE_ARCH_SW_HWEIGHT
2019-05-13 11:07:33 +02:00
ida: don't use BUG_ON() for debugging
2022-07-12 16:30:49 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
iomap: introduce io{read|write}64_{lo_hi|hi_lo}
2019-01-22 13:39:59 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 504
2019-06-19 17:09:56 +02:00
mm/ioremap: probe platform for p4d huge map support
2019-07-16 19:23:22 -07:00
mm/highmem: Lift memcpy_[to|from]_page to core
2023-01-18 11:41:55 +01:00
lib/irq_poll: Support schedules in non-interrupt contexts
2019-02-19 20:52:19 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36
2019-05-24 17:27:11 +02:00
ARM: 9178/1: fix unmet dependency on BITREVERSE for HAVE_ARCH_BITREVERSE
2022-03-19 13:40:16 +01:00
Kconfig.debug: provide a little extra FRAME_WARN leeway when KASAN is enabled
2022-12-08 11:23:05 +01:00
kasan: add memory corruption identification for software tag-based mode
2019-09-24 15:54:07 -07:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
Partially revert "kfifo: fix kfifo_alloc() and kfifo_init()"
2019-08-30 18:47:15 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 248
2019-06-19 17:09:08 +02:00
kobject: Restore old behaviour of kobject_del(NULL)
2020-09-17 13:47:52 +02:00
kobject_uevent: remove warning in init_uevent_argv()
2021-05-19 10:08:33 +02:00
lib: vsprintf: Fix handling of number field widths in vsscanf
2021-07-14 16:53:16 +02:00
lib: vsprintf: Fix handling of number field widths in vsscanf
2021-07-14 16:53:16 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
lib/list_debug.c: Detect uninitialized lists
2022-08-25 11:18:36 +02:00
lib: list_sort.c: add a blank line to avoid kernel-doc warnings
2019-06-20 14:07:34 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
locking/lockdep: Make it easy to detect whether or not inside a selftest
2019-02-28 07:55:43 +01:00
lockref: Limit number of cmpxchg loop retries
2019-06-07 13:15:06 -07:00
PCI: Fix pci_register_io_range() memory leak
2021-03-17 17:03:44 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 91
2019-05-24 17:37:53 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 120
2019-05-24 17:39:02 +02:00
avoid __memcat_p link failure
2021-05-07 10:51:37 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 120
2019-05-24 17:39:02 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
net: fix nla_strcmp to handle more then one trailing null character
2021-05-19 10:08:27 +02:00
nodemask: Fix return values to be unsigned
2022-06-14 18:12:02 +02:00
lib/notifier-error-inject: fix error when writing -errno to debugfs file
2023-01-18 11:40:55 +01:00
lib: objagg: Use struct_size() in kzalloc()
2019-06-05 19:03:39 -07:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36
2019-05-24 17:27:11 +02:00
once: add DO_ONCE_SLOW() for sleepable contexts
2022-10-26 13:22:27 +02:00
lib: Add support for generic packing operations
2019-05-03 10:49:17 -04:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230
2019-06-19 17:09:06 +02:00
Merge branch 'for-5.3' of git://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu
2019-07-14 16:17:18 -07:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 10
2019-05-21 11:28:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
idr: Fix idr_alloc_u32 on 32-bit systems
2019-11-03 06:36:50 -05:00
random: replace custom notifier chain with standard one
2022-06-22 14:11:13 +02:00
ratelimit: Fix data-races in ___ratelimit().
2022-09-05 10:27:42 +02:00
lib/rbtree: avoid generating code twice for the cached versions
2019-07-16 19:23:22 -07:00
augmented rbtree: add new RB_DECLARE_CALLBACKS_MAX macro
2019-09-25 17:51:39 -07:00
locking/refcount: Consolidate implementations of refcount_t
2022-07-29 17:14:17 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
sbitmap: only queue kyber's wait callback if not already active
2020-01-12 12:21:44 +01:00
sgl_alloc_order: fix memory leak
2020-11-05 11:43:22 +01:00
seq_buf: Fix overflow in seq_buf_putmem_hex()
2021-07-19 08:53:16 +02:00
SCSI sg on 20190709
2019-07-11 15:17:41 -07:00
lib: scatterlist: Fix to support no mapped sg
2019-08-08 07:45:01 -06:00
lib/crypto: sha1: re-roll loops to reduce code size
2022-06-22 14:11:03 +02:00
mm: remove quicklist page table caches
2019-09-24 15:54:09 -07:00
siphash: use one source of truth for siphash permutations
2022-06-22 14:11:16 +02:00
sched/core: Provide a pointer to the valid CPU mask
2019-06-03 11:49:37 +02:00
media: lib/sort.c: implement sort() variant taking context argument
2019-08-19 13:14:53 -03:00
lib: stackdepot: turn depot_lock spinlock to raw_spinlock
2021-05-22 11:38:30 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
lib/string.c: implement stpcpy
2020-10-01 13:18:23 +02:00
lib/string_helpers: fix some kerneldoc warnings
2019-07-16 19:23:22 -07:00
lib: Reduce user_access_begin() boundaries in strncpy_from_user() and strnlen_user()
2020-01-29 16:45:29 +01:00
lib: Reduce user_access_begin() boundaries in strncpy_from_user() and strnlen_user()
2020-01-29 16:45:29 +01:00
lib/syscall: fix syscall registers retrieval on 32-bit platforms
2020-12-11 13:23:32 +01:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
blackhole_dev: add a selftest
2019-07-01 19:34:46 -07:00
bpf/tests: Do not PASS tests without actually testing the result
2021-09-22 12:26:29 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
test_firmware: fix memory leak in test_firmware_init()
2023-01-18 11:41:23 +01:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
kasan: stop tests being eliminated as dead code with FORTIFY_SOURCE
2020-06-22 09:31:12 +02:00
lib/test: use after free in register_test_dev_kmod()
2022-04-15 14:18:21 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
lib/test_meminit: destroy cache in kmem_cache_alloc_bulk() test
2022-01-27 09:19:55 +01:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
test_objagg: Fix potential memory leak in error handling
2020-06-30 15:37:04 -04:00
lib/test_overflow.c: avoid tainting the kernel and fix wrap size
2019-07-16 19:23:22 -07:00
vsprintf: don't obfuscate NULL and error pointers
2020-05-27 17:46:43 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
lib/test_stackinit: Fix static initializer test
2021-09-22 12:26:38 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
lib/test_string.c: add some testcases for strchr and strnchr
2019-07-16 19:23:22 -07:00
lib: Add test module for strscpy_pad
2019-04-08 16:44:21 -06:00
tools/testing/selftests/sysctl/sysctl.sh: add proc_do_large_bitmap() test case
2019-05-14 19:52:51 -07:00
lib/test_ubsan.c: VLA no longer used in kernel
2019-03-07 18:32:00 -08:00
usercopy: Avoid soft lockups in test_check_nonzero_user()
2019-10-16 14:56:21 +02:00
lib/test_vmalloc.c:test_func(): eliminate local `ret'
2019-05-14 19:52:49 -07:00
XArray: Fix xas_create_range() when multi-order entry present
2022-04-15 14:18:28 +02:00
lib: textsearch: fix escapes in example code
2019-10-03 12:12:23 -04:00
lib/timerqueue: Rely on rbtree semantics for next timer
2019-07-24 17:38:01 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
lib/ubsan: don't serialize UBSAN report
2020-01-09 10:20:07 +01:00
ubsan: Remove vla bound checks.
2019-05-06 11:12:09 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 120
2019-05-24 17:39:02 +02:00
lib: introduce copy_struct_from_user() helper
2019-10-01 15:45:03 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
random: replace custom notifier chain with standard one
2022-06-22 14:11:13 +02:00
XArray: Update the LRU list in xas_split()
2022-04-15 14:18:28 +02:00
49dac5e017