Niklas Cassel
56f1c7e290
ata: libata-core: Fix double free on error
commit ab9e0c529eb7cafebdd31fe1644524e80a48b05d upstream.
If e.g. the ata_port_alloc() call in ata_host_alloc() fails, we will jump
to the err_out label, which will call devres_release_group().
devres_release_group() will trigger a call to ata_host_release().
ata_host_release() calls kfree(host), so executing the kfree(host) in
ata_host_alloc() will lead to a double free:
kernel BUG at mm/slub.c:553!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
CPU: 11 PID: 599 Comm: (udev-worker) Not tainted 6.10.0-rc5 #47
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-2.fc40 04/01/2014
RIP: 0010:kfree+0x2cf/0x2f0
Code: 5d 41 5e 41 5f 5d e9 80 d6 ff ff 4d 89 f1 41 b8 01 00 00 00 48 89 d9 48 89 da
RSP: 0018:ffffc90000f377f0 EFLAGS: 00010246
RAX: ffff888112b1f2c0 RBX: ffff888112b1f2c0 RCX: ffff888112b1f320
RDX: 000000000000400b RSI: ffffffffc02c9de5 RDI: ffff888112b1f2c0
RBP: ffffc90000f37830 R08: 0000000000000000 R09: 0000000000000000
R10: ffffc90000f37610 R11: 617461203a736b6e R12: ffffea00044ac780
R13: ffff888100046400 R14: ffffffffc02c9de5 R15: 0000000000000006
FS: 00007f2f1cabe980(0000) GS:ffff88813b380000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2f1c3acf75 CR3: 0000000111724000 CR4: 0000000000750ef0
PKRU: 55555554
Call Trace:
<TASK>
? __die_body.cold+0x19/0x27
? die+0x2e/0x50
? do_trap+0xca/0x110
? do_error_trap+0x6a/0x90
? kfree+0x2cf/0x2f0
? exc_invalid_op+0x50/0x70
? kfree+0x2cf/0x2f0
? asm_exc_invalid_op+0x1a/0x20
? ata_host_alloc+0xf5/0x120 [libata]
? ata_host_alloc+0xf5/0x120 [libata]
? kfree+0x2cf/0x2f0
ata_host_alloc+0xf5/0x120 [libata]
ata_host_alloc_pinfo+0x14/0xa0 [libata]
ahci_init_one+0x6c9/0xd20 [ahci]
Ensure that we will not call kfree(host) twice, by performing the kfree()
only if the devres_open_group() call failed.
Fixes: dafd6c4963 ("libata: ensure host is free'd on error exit paths")
Cc: stable@vger.kernel.org
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20240629124210.181537-9-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
2024-07-05 09:08:31 +02:00 |
| .. |
|
acard-ahci.c
|
ata: make qc_prep return ata_completion_errors
|
2020-10-01 13:18:26 +02:00 |
|
ahci.c
|
ahci: asm1064: asm1166: don't limit reported ports
|
2024-04-13 12:51:28 +02:00 |
|
ahci.h
|
ahci: add 43-bit DMA address quirk for ASMedia ASM1061 controllers
|
2024-03-01 13:13:33 +01:00 |
|
ahci_brcm.c
|
ata: ahci_brcm: Add back regulators management
|
2021-03-04 10:26:23 +01:00 |
|
ahci_ceva.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201
|
2019-05-30 11:29:52 -07:00 |
|
ahci_da850.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
|
2019-05-24 17:27:12 +02:00 |
|
ahci_dm816.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
|
2019-05-24 17:27:12 +02:00 |
|
ahci_imx.c
|
ata: ahci-imx: Fix MODULE_ALIAS
|
2022-10-29 10:20:34 +02:00 |
|
ahci_mtk.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
|
2019-05-30 11:26:41 -07:00 |
|
ahci_mvebu.c
|
ata: ahci: mvebu: Make SATA PHY optional for Armada 3720
|
2020-11-01 12:01:05 +01:00 |
|
ahci_octeon.c
|
|
|
|
ahci_platform.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
|
2019-05-24 17:27:12 +02:00 |
|
ahci_qoriq.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
|
2019-05-24 17:27:12 +02:00 |
|
ahci_seattle.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235
|
2019-06-19 17:09:07 +02:00 |
|
ahci_st.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
|
2019-06-19 17:09:55 +02:00 |
|
ahci_sunxi.c
|
ata: ahci_sunxi: Disable DIPM
|
2021-07-19 08:53:15 +02:00 |
|
ahci_tegra.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
|
2019-06-05 17:36:37 +02:00 |
|
ahci_xgene.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13
|
2019-05-21 11:28:45 +02:00 |
|
ata_generic.c
|
|
|
|
ata_piix.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
|
2019-05-21 11:28:46 +02:00 |
|
Kconfig
|
|
|
|
libahci.c
|
ata: libahci: clear pending interrupt status
|
2023-10-10 21:46:36 +02:00 |
|
libahci_platform.c
|
ata: libahci_platform: Sanity check the DT child nodes number
|
2022-10-26 13:22:56 +02:00 |
|
libata-acpi.c
|
|
|
|
libata-core.c
|
ata: libata-core: Fix double free on error
|
2024-07-05 09:08:31 +02:00 |
|
libata-eh.c
|
ata: libata-eh: Fix compilation warning in ata_eh_link_report()
|
2023-10-25 11:53:23 +02:00 |
|
libata-pmp.c
|
libata: Return correct status in sata_pmp_eh_recover_pm() when ATA_DFLAG_DETACH is set
|
2020-04-17 10:50:22 +02:00 |
|
libata-scsi.c
|
ata: libata-scsi: ignore reserved bits for REPORT SUPPORTED OPERATION CODES
|
2023-10-10 21:46:41 +02:00 |
|
libata-sff.c
|
libata: fix ata_pio_sector for CONFIG_HIGHMEM
|
2021-08-12 13:21:04 +02:00 |
|
libata-trace.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
|
2019-05-21 11:28:46 +02:00 |
|
libata-transport.c
|
ata: libata-core: Do not register PM operations for SAS ports
|
2023-10-10 21:46:42 +02:00 |
|
libata-transport.h
|
|
|
|
libata-zpodd.c
|
libata: zpodd: Fix small read overflow in zpodd_get_mech_type()
|
2019-07-29 16:00:14 -06:00 |
|
libata.h
|
ata: libata-core: Do not register PM operations for SAS ports
|
2023-10-10 21:46:42 +02:00 |
|
Makefile
|
|
|
|
pata_acpi.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_ali.c
|
|
|
|
pata_amd.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_arasan_cf.c
|
pata_arasan_cf: fix IRQ check
|
2021-05-14 09:44:24 +02:00 |
|
pata_artop.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_atiixp.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_atp867x.c
|
libata: switch remaining drivers to use dma_set_mask_and_coherent
|
2019-08-26 13:58:59 -06:00 |
|
pata_bk3710.c
|
|
|
|
pata_buddha.c
|
ata/pata_buddha: Probe via modalias instead of initcall
|
2019-08-23 06:58:50 -06:00 |
|
pata_cmd64x.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_cmd640.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_cs5520.c
|
libata: switch remaining drivers to use dma_set_mask_and_coherent
|
2019-08-26 13:58:59 -06:00 |
|
pata_cs5530.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
|
2019-06-05 17:37:06 +02:00 |
|
pata_cs5535.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
|
2019-06-05 17:37:06 +02:00 |
|
pata_cs5536.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
|
2019-06-05 17:37:06 +02:00 |
|
pata_cypress.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_efar.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_ep93xx.c
|
pata_ep93xx: fix deferred probing
|
2021-07-14 16:53:21 +02:00 |
|
pata_falcon.c
|
|
|
|
pata_ftide010.c
|
ata: pata_ftide010: Add missing MODULE_DESCRIPTION
|
2023-09-23 11:00:00 +02:00 |
|
pata_gayle.c
|
|
|
|
pata_hpt3x2n.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_hpt3x3.c
|
libata: switch remaining drivers to use dma_set_mask_and_coherent
|
2019-08-26 13:58:59 -06:00 |
|
pata_hpt37x.c
|
ata: pata_hpt37x: fix PCI clock detection
|
2022-03-08 19:07:46 +01:00 |
|
pata_hpt366.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_icside.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_imx.c
|
|
|
|
pata_isapnp.c
|
ata: pata_isapnp: Add missing error check for devm_ioport_map()
|
2023-12-08 08:44:23 +01:00 |
|
pata_it821x.c
|
|
|
|
pata_it8213.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_ixp4xx_cf.c
|
pata_ipx4xx_cf: Fix unsigned comparison with less than zero
|
2023-01-18 11:40:59 +01:00 |
|
pata_jmicron.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_legacy.c
|
ata: pata_legacy: make legacy_exit() work again
|
2024-06-16 13:28:49 +02:00 |
|
pata_macio.c
|
ata: make qc_prep return ata_completion_errors
|
2020-10-01 13:18:26 +02:00 |
|
pata_marvell.c
|
ata: pata_marvell: Check the 'bmdma_addr' beforing reading
|
2022-04-27 13:50:48 +02:00 |
|
pata_mpc52xx.c
|
|
|
|
pata_mpiix.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_netcell.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_ninja32.c
|
libata: switch remaining drivers to use dma_set_mask_and_coherent
|
2019-08-26 13:58:59 -06:00 |
|
pata_ns87410.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
|
2019-05-21 11:28:46 +02:00 |
|
pata_ns87415.c
|
ata: pata_ns87415: mark ns87560_tf_read static
|
2023-08-11 11:53:49 +02:00 |
|
pata_octeon_cf.c
|
ata: pata_octeon_cf: Fix refcount leak in octeon_cf_probe
|
2022-06-14 18:11:57 +02:00 |
|
pata_of_platform.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
|
2019-06-19 17:09:55 +02:00 |
|
pata_oldpiix.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_opti.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_optidma.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_palmld.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
|
2019-06-19 17:09:55 +02:00 |
|
pata_pcmcia.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
|
2019-05-21 11:28:46 +02:00 |
|
pata_pdc202xx_old.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_pdc2027x.c
|
libata: switch remaining drivers to use dma_set_mask_and_coherent
|
2019-08-26 13:58:59 -06:00 |
|
pata_piccolo.c
|
|
|
|
pata_platform.c
|
|
|
|
pata_pxa.c
|
ata: make qc_prep return ata_completion_errors
|
2020-10-01 13:18:26 +02:00 |
|
pata_radisys.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_rb532_cf.c
|
pata_rb532_cf: fix deferred probing
|
2021-07-14 16:53:20 +02:00 |
|
pata_rdc.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
|
2019-05-21 11:28:46 +02:00 |
|
pata_rz1000.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_samsung_cf.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
|
2019-06-19 17:09:55 +02:00 |
|
pata_sc1200.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
|
2019-06-05 17:37:06 +02:00 |
|
pata_sch.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 300
|
2019-06-05 17:37:00 +02:00 |
|
pata_serverworks.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_sil680.c
|
libata: switch remaining drivers to use dma_set_mask_and_coherent
|
2019-08-26 13:58:59 -06:00 |
|
pata_sis.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_sl82c105.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pata_triflex.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
|
2019-06-05 17:37:06 +02:00 |
|
pata_via.c
|
treewide: Add SPDX license identifier for more missed files
|
2019-05-21 10:50:45 +02:00 |
|
pdc_adma.c
|
ata: make qc_prep return ata_completion_errors
|
2020-10-01 13:18:26 +02:00 |
|
sata_dwc_460ex.c
|
ata: sata_dwc_460ex: Fix crash due to OOB write
|
2022-04-15 14:18:39 +02:00 |
|
sata_fsl.c
|
sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
|
2021-12-08 09:01:11 +01:00 |
|
sata_gemini.c
|
ata: sata_gemini: Check clk_enable() result
|
2024-05-17 11:43:51 +02:00 |
|
sata_gemini.h
|
|
|
|
sata_highbank.c
|
sata_highbank: fix deferred probing
|
2021-07-14 16:53:20 +02:00 |
|
sata_inic162x.c
|
ata: make qc_prep return ata_completion_errors
|
2020-10-01 13:18:26 +02:00 |
|
sata_mv.c
|
ata: sata_mv: Fix PCI device ID table declaration compilation warning
|
2024-04-13 12:51:36 +02:00 |
|
sata_nv.c
|
ata: sata_nv: Fix retrieving of active qcs
|
2020-11-05 11:43:12 +01:00 |
|
sata_promise.c
|
ata: make qc_prep return ata_completion_errors
|
2020-10-01 13:18:26 +02:00 |
|
sata_promise.h
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
|
2019-05-21 11:28:46 +02:00 |
|
sata_qstor.c
|
ata: make qc_prep return ata_completion_errors
|
2020-10-01 13:18:26 +02:00 |
|
sata_rcar.c
|
ata: sata_rcar: Fix DMA boundary mask
|
2020-11-01 12:01:06 +01:00 |
|
sata_sil.c
|
ata: make qc_prep return ata_completion_errors
|
2020-10-01 13:18:26 +02:00 |
|
sata_sil24.c
|
ata: make qc_prep return ata_completion_errors
|
2020-10-01 13:18:26 +02:00 |
|
sata_sis.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
|
2019-05-21 11:28:46 +02:00 |
|
sata_svw.c
|
libata: switch remaining drivers to use dma_set_mask_and_coherent
|
2019-08-26 13:58:59 -06:00 |
|
sata_sx4.c
|
ata: sata_sx4: fix pdc20621_get_from_dimm() on 64-bit
|
2024-04-13 12:51:36 +02:00 |
|
sata_uli.c
|
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
|
2019-05-21 11:28:46 +02:00 |
|
sata_via.c
|
libata: switch remaining drivers to use dma_set_mask_and_coherent
|
2019-08-26 13:58:59 -06:00 |
|
sata_vsc.c
|
libata: switch remaining drivers to use dma_set_mask_and_coherent
|
2019-08-26 13:58:59 -06:00 |
|
sis.h
|
|
|