Darrick J. Wong
ea78d80866
xfs: track log done items directly in the deferred pending work item ...
Christoph reports slab corruption when a deferred refcount update
aborts during _defer_finish(). The cause of this was broken log item
state tracking in xfs_defer_pending -- upon an abort,
_defer_trans_abort() will call abort_intent on all intent items,
including the ones that have already had a done item attached.
This is incorrect because each intent item has 2 refcount: the first
is released when the intent item is committed to the log; and the
second is released when the _done_ item is committed to the log, or
by the intent creator if there is no done item. In other words, once
we log the done item, responsibility for releasing the intent item's
second refcount is transferred to the done item and /must not/ be
performed by anything else.
The dfp_committed flag should have been tracking whether or not we had
a done item so that _defer_trans_abort could decide if it needs to
abort the intent item, but due to a thinko this was not the case. Rip
it out and track the done item directly so that we do the right thing
w.r.t. intent item freeing.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reported-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2016-08-30 13:51:39 +10:00
xfs: track log done items directly in the deferred pending work item
2016-08-30 13:51:39 +10:00
xfs: implement iomap based buffered write path
2016-06-21 09:53:44 +10:00
xfs: improve kmem_realloc
2016-04-06 09:47:01 +10:00
xfs: improve kmem_realloc
2016-04-06 09:47:01 +10:00
xfs: reverse block mapping support for 4.8-rc1
2016-08-06 09:50:36 -04:00
posix_acl: Inode acl caching fixes
2016-03-31 00:30:15 -04:00
xfs: update for 4.8-rc1
2016-07-27 09:53:35 -07:00
xfs: direct calls in the direct I/O path
2016-07-20 11:38:01 +10:00
xfs: remove put_value from attr ->put_listent context
2016-04-06 07:57:45 +10:00
xfs: make several functions static
2016-06-01 17:38:15 +10:00
xfs: make several functions static
2016-06-01 17:38:15 +10:00
xfs: disable XFS_IOC_SWAPEXT when rmap btree is enabled
2016-08-03 12:18:07 +10:00
xfs: change xfs_bmap_{finish,cancel,init,free} -> xfs_defer_*
2016-08-03 11:18:10 +10:00
xfs: prevent dropping ioend completions during buftarg wait
2016-08-26 16:01:59 +10:00
xfs: track and serialize in-flight async buffers against unmount
2016-07-20 11:15:28 +10:00
Merge branch 'xfs-4.8-misc-fixes-4' into for-next
2016-07-22 14:10:56 +10:00
xfs: concurrent readdir hangs on data buffer locks
2016-05-18 13:20:21 -04:00
xfs: rmap btree requires more reserved free space
2016-08-03 11:38:24 +10:00
xfs: rename flist/free_list to dfops
2016-08-03 11:19:29 +10:00
xfs: allocate log vector buffers outside CIL context lock
2016-07-22 09:52:35 +10:00
Merge branch 'xfs-4.8-misc-fixes-3' into for-next
2016-07-20 11:51:08 +10:00
xfs: propagate bmap updates to rmapbt
2016-08-03 12:16:05 +10:00
xfs: abstract block export operations from nfsd layouts
2016-07-15 15:31:29 -04:00
xfs: remove unnecessary parentheses from log redo item recovery functions
2016-08-03 12:29:32 +10:00
xfs: refactor redo intent item processing
2016-08-03 11:23:49 +10:00
xfs: don't invalidate whole file on DAX read/write
2016-08-17 08:31:33 +10:00
xfs: rename flist/free_list to dfops
2016-08-03 11:19:29 +10:00
xfs: store rmapbt block count in the AGF
2016-08-17 08:31:49 +10:00
xfs: cancel eofblocks background trimming on remount read-only
2016-06-21 11:53:28 +10:00
xfs: cancel eofblocks background trimming on remount read-only
2016-06-21 11:53:28 +10:00
xfs: rename flist/free_list to dfops
2016-08-03 11:19:29 +10:00
xfs: change xfs_bmap_{finish,cancel,init,free} -> xfs_defer_*
2016-08-03 11:18:10 +10:00
xfs: allocate log vector buffers outside CIL context lock
2016-07-22 09:52:35 +10:00
fs: return EPERM on immutable inode
2016-08-07 10:03:31 -04:00
xfs: don't pass ioflags around in the ioctl path
2016-07-20 11:29:35 +10:00
xfs: don't pass ioflags around in the ioctl path
2016-07-20 11:29:35 +10:00
Merge branch 'iomap-fixes-4.8-rc3' into for-next
2016-08-17 11:13:37 +10:00
xfs: (re-)implement FIEMAP_FLAG_XATTR
2016-08-17 08:45:30 +10:00
xfs: (re-)implement FIEMAP_FLAG_XATTR
2016-08-17 08:45:30 +10:00
xfs: mode di_mode to vfs inode
2016-02-09 16:54:58 +11:00
xfs: remove __arch_pack
2016-07-20 11:48:46 +10:00
Merge branch 'xfs-4.8-buf-fixes' into for-next
2016-07-20 11:53:35 +10:00
xfs: make several functions static
2016-06-01 17:38:15 +10:00
xfs: allocate log vector buffers outside CIL context lock
2016-07-22 09:52:35 +10:00
xfs: remove transaction types
2016-04-06 09:20:36 +10:00
xfs: remove the extents array from the rmap update done log item
2016-08-03 12:28:43 +10:00
xfs: rmap btree requires more reserved free space
2016-08-03 11:38:24 +10:00
xfs: rmap btree requires more reserved free space
2016-08-03 11:38:24 +10:00
xfs: define the on-disk rmap btree format
2016-08-03 11:36:07 +10:00
xfs: make xfs_bmbt_to_iomap available outside of xfs_pnfs.c
2016-06-21 09:52:47 +10:00
xfs: abstract block export operations from nfsd layouts
2016-07-15 15:31:29 -04:00
xfs: better xfs_trans_alloc interface
2016-04-06 09:19:55 +10:00
xfs: better xfs_trans_alloc interface
2016-04-06 09:19:55 +10:00
xfs: remove unnecessary parentheses from log redo item recovery functions
2016-08-03 12:29:32 +10:00
xfs: remove the extents array from the rmap update done log item
2016-08-03 12:28:43 +10:00
xfs: rename flist/free_list to dfops
2016-08-03 11:19:29 +10:00
xfs: make several functions static
2016-06-01 17:38:15 +10:00
xfs: reverse block mapping support for 4.8-rc1
2016-08-06 09:50:36 -04:00
xfs: add rmap btree stats infrastructure
2016-08-03 11:31:11 +10:00
xfs: disallow mounting of realtime + rmap filesystems
2016-08-26 15:59:19 +10:00
xfs: make several functions static
2016-06-01 17:38:15 +10:00
xfs: rename flist/free_list to dfops
2016-08-03 11:19:29 +10:00
xfs: fix xfs_error_get_cfg for negative errnos
2016-07-20 10:48:51 +10:00
xfs: configurable error behavior via sysfs
2016-05-18 10:58:51 +10:00
xfs: rework xfs_bmap_free callers to use xfs_defer_ops
2016-08-03 11:15:38 +10:00
xfs: track log done items directly in the deferred pending work item
2016-08-30 13:51:39 +10:00
xfs: remove transaction types
2016-04-06 09:20:36 +10:00
xfs: remove the extents array from the rmap update done log item
2016-08-03 12:28:43 +10:00
xfs: remove XBF_STALE flag wrapper macros
2016-02-10 15:01:11 +11:00
xfs: move (and rename) the deferred bmap-free tracepoints
2016-08-03 12:31:07 +10:00
xfs: move di_changecount to VFS inode
2016-02-09 16:54:58 +11:00
xfs: collapse single use static functions
2016-08-03 12:30:31 +10:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-05-27 17:14:05 -07:00
ea78d80866