Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Nicholas Bellinger 064cdd2d91 target: Fix race between iscsi-target connection shutdown + ABORT_TASK ... This patch fixes a race in iscsit_release_commands_from_conn() -> iscsit_free_cmd() -> transport_generic_free_cmd() + wait_for_tasks=1, where CMD_T_FABRIC_STOP could end up being set after the final kref_put() is called from core_tmr_abort_task() context. This results in transport_generic_free_cmd() blocking indefinately on se_cmd->cmd_wait_comp, because the target_release_cmd_kref() check for CMD_T_FABRIC_STOP returns false. To address this bug, make iscsit_release_commands_from_conn() do list_splice and set CMD_T_FABRIC_STOP early while holding iscsi_conn->cmd_lock. Also make iscsit_aborted_task() only remove iscsi_cmd_t if CMD_T_FABRIC_STOP has not already been set. Finally in target_release_cmd_kref(), only honor fabric_stop if CMD_T_ABORTED has been set. Cc: Mike Christie <mchristi@redhat.com> Cc: Quinn Tran <quinn.tran@qlogic.com> Cc: Himanshu Madhani <himanshu.madhani@qlogic.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Hannes Reinecke <hare@suse.de> Cc: stable@vger.kernel.org # 3.14+ Tested-by: Nicholas Bellinger <nab@linux-iscsi.org> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>		2016-07-20 00:58:34 -07:00
..
iscsi	target: Fix race between iscsi-target connection shutdown + ABORT_TASK	2016-07-20 00:58:34 -07:00
loopback	target: make close_session optional	2016-05-10 01:19:26 -07:00
sbp	target: make close_session optional	2016-05-10 01:19:26 -07:00
tcm_fc	target: make ->shutdown_session optional	2016-05-10 01:19:18 -07:00
Kconfig
Makefile
target_core_alua.c	target: use new "dbroot" target attribute	2016-05-09 23:06:20 -07:00
target_core_alua.h
target_core_configfs.c	target: make close_session optional	2016-05-10 01:19:26 -07:00
target_core_device.c
target_core_fabric_configfs.c	target: add a new add_wwn_groups fabrics method	2016-03-30 20:06:44 -07:00
target_core_fabric_lib.c
target_core_file.c
target_core_file.h
target_core_hba.c
target_core_iblock.c	block: kill off q->flush_flags	2016-04-13 13:33:19 -06:00
target_core_iblock.h
target_core_internal.h	target: make target db location configurable	2016-05-09 23:06:15 -07:00
target_core_pr.c	target: use new "dbroot" target attribute	2016-05-09 23:06:20 -07:00
target_core_pr.h
target_core_pscsi.c
target_core_pscsi.h
target_core_rd.c	target: need_to_release is always false, remove redundant check and kfree	2016-05-10 01:19:55 -07:00
target_core_rd.h
target_core_sbc.c
target_core_spc.c
target_core_stat.c
target_core_tmr.c
target_core_tpg.c	target: remove sess_kref and ->shutdown_session	2016-05-10 01:19:49 -07:00
target_core_transport.c	target: Fix race between iscsi-target connection shutdown + ABORT_TASK	2016-07-20 00:58:34 -07:00
target_core_ua.c
target_core_ua.h
target_core_user.c
target_core_xcopy.c	target: enhance and export target_alloc_sgl/target_free_sgl	2016-05-13 13:37:19 -04:00
target_core_xcopy.h