Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Daniel Jordan 0685dfa0a2 padata: validate cpumask without removed CPU during offline ... [ Upstream commit 894c9ef9780c5cf2f143415e867ee39a33ecb75d ] Configuring an instance's parallel mask without any online CPUs... echo 2 > /sys/kernel/pcrypt/pencrypt/parallel_cpumask echo 0 > /sys/devices/system/cpu/cpu1/online ...makes tcrypt mode=215 crash like this: divide error: 0000 [#1] SMP PTI CPU: 4 PID: 283 Comm: modprobe Not tainted 5.4.0-rc8-padata-doc-v2+ #2 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS ?-20191013_105130-anatol 04/01/2014 RIP: 0010:padata_do_parallel+0x114/0x300 Call Trace: pcrypt_aead_encrypt+0xc0/0xd0 [pcrypt] crypto_aead_encrypt+0x1f/0x30 do_mult_aead_op+0x4e/0xdf [tcrypt] test_mb_aead_speed.constprop.0.cold+0x226/0x564 [tcrypt] do_test+0x28c2/0x4d49 [tcrypt] tcrypt_mod_init+0x55/0x1000 [tcrypt] ... cpumask_weight() in padata_cpu_hash() returns 0 because the mask has no CPUs. The problem is __padata_remove_cpu() checks for valid masks too early and so doesn't mark the instance PADATA_INVALID as expected, which would have made padata_do_parallel() return error before doing the division. Fix by introducing a second padata CPU hotplug state before CPUHP_BRINGUP_CPU so that __padata_remove_cpu() sees the online mask without @cpu. No need for the second argument to padata_replace() since @cpu is now already missing from the online mask. Fixes: 33e5445068 ("padata: Handle empty padata cpumasks") Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com> Cc: Eric Biggers <ebiggers@kernel.org> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Cc: Steffen Klassert <steffen.klassert@secunet.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-02-24 08:36:34 +01:00
..
acpi	ACPICA: Introduce acpi_any_gpe_status_set()	2020-02-19 19:52:57 +01:00
asm-generic	mm/mmu_gather: invalidate TLB correctly on batch allocation failure and flush	2020-02-11 04:35:42 -08:00
clocksource
crypto	crypto: algif_skcipher - Use chunksize instead of blocksize	2020-01-17 19:48:46 +01:00
drm	drm: mst: Fix query_payload ack reply struct	2019-12-31 16:42:19 +01:00
dt-bindings	dt-bindings: reset: meson8b: fix duplicate reset IDs	2020-01-23 08:22:28 +01:00
keys
kvm
linux	padata: validate cpumask without removed CPU during offline	2020-02-24 08:36:34 +01:00
math-emu
media	media: v4l2-rect.h: fix v4l2_rect_map_inside() top/left adjustments	2020-02-11 04:35:14 -08:00
misc
net	bonding/alb: properly access headers in bond_alb_xmit()	2020-02-11 04:35:48 -08:00
pcmcia
ras
rdma	IB/core: Let IB core distribute cache update events	2020-02-24 08:36:26 +01:00
scsi	scsi: target: iscsi: Wait for all commands to finish before freeing a session	2020-01-04 19:18:17 +01:00
soc
sound	ALSA: hda: Apply aligned MMIO access only conditionally	2020-02-11 04:35:15 -08:00
target
trace	rcu: Fix data-race due to atomic_t copy-by-value	2020-02-24 08:36:23 +01:00
uapi	rdma: Remove nes ABI header	2020-01-17 19:48:39 +01:00
vdso
video
xen
Kbuild