Denis V. Lunev
fdc0bde90a
icmp: icmp_sk() should not use smp_processor_id() in preemptible code
Pass namespace into icmp_xmit_lock, obtain socket inside and return
it as a result for caller.
Thanks Alexey Dobryan for this report:
Steps to reproduce:
CONFIG_PREEMPT=y
CONFIG_DEBUG_PREEMPT=y
tracepath <something>
BUG: using smp_processor_id() in preemptible [00000000] code: tracepath/3205
caller is icmp_sk+0x15/0x30
Pid: 3205, comm: tracepath Not tainted 2.6.27-rc4 #1
Call Trace:
[<ffffffff8031af14>] debug_smp_processor_id+0xe4/0xf0
[<ffffffff80409405>] icmp_sk+0x15/0x30
[<ffffffff8040a17b>] icmp_send+0x4b/0x3f0
[<ffffffff8025a415>] ? trace_hardirqs_on_caller+0xd5/0x160
[<ffffffff8025a4ad>] ? trace_hardirqs_on+0xd/0x10
[<ffffffff8023a475>] ? local_bh_enable_ip+0x95/0x110
[<ffffffff804285b9>] ? _spin_unlock_bh+0x39/0x40
[<ffffffff8025a26c>] ? mark_held_locks+0x4c/0x90
[<ffffffff8025a4ad>] ? trace_hardirqs_on+0xd/0x10
[<ffffffff8025a415>] ? trace_hardirqs_on_caller+0xd5/0x160
[<ffffffff803e91b4>] ip_fragment+0x8d4/0x900
[<ffffffff803e7030>] ? ip_finish_output2+0x0/0x290
[<ffffffff803e91e0>] ? ip_finish_output+0x0/0x60
[<ffffffff803e6650>] ? dst_output+0x0/0x10
[<ffffffff803e922c>] ip_finish_output+0x4c/0x60
[<ffffffff803e92e3>] ip_output+0xa3/0xf0
[<ffffffff803e68d0>] ip_local_out+0x20/0x30
[<ffffffff803e753f>] ip_push_pending_frames+0x27f/0x400
[<ffffffff80406313>] udp_push_pending_frames+0x233/0x3d0
[<ffffffff804067d1>] udp_sendmsg+0x321/0x6f0
[<ffffffff8040d155>] inet_sendmsg+0x45/0x80
[<ffffffff803b967f>] sock_sendmsg+0xdf/0x110
[<ffffffff8024a100>] ? autoremove_wake_function+0x0/0x40
[<ffffffff80257ce5>] ? validate_chain+0x415/0x1010
[<ffffffff8027dc10>] ? __do_fault+0x140/0x450
[<ffffffff802597d0>] ? __lock_acquire+0x260/0x590
[<ffffffff803b9e55>] ? sockfd_lookup_light+0x45/0x80
[<ffffffff803ba50a>] sys_sendto+0xea/0x120
[<ffffffff80428e42>] ? _spin_unlock_irqrestore+0x42/0x80
[<ffffffff803134bc>] ? __up_read+0x4c/0xb0
[<ffffffff8024e0c6>] ? up_read+0x26/0x30
[<ffffffff8020b8bb>] system_call_fastpath+0x16/0x1b
icmp6_sk() is similar.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
|
2008-08-23 04:43:33 -07:00 |
| .. |
|
ipvs
|
ipvs: Explictly clear ip_vs_stats members
|
2008-08-11 14:00:55 +02:00 |
|
netfilter
|
nf_nat: use secure_ipv4_port_ephemeral() for NAT port randomization
|
2008-08-18 21:32:32 -07:00 |
|
af_inet.c
|
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6
|
2008-07-26 20:23:44 -07:00 |
|
ah4.c
|
|
|
|
arp.c
|
mib: add net to NET_INC_STATS_BH
|
2008-07-16 20:31:16 -07:00 |
|
cipso_ipv4.c
|
|
|
|
datagram.c
|
mib: add net to IP_INC_STATS_BH
|
2008-07-16 20:20:11 -07:00 |
|
devinet.c
|
net: convert BUG_TRAP to generic WARN_ON
|
2008-07-25 21:43:18 -07:00 |
|
esp4.c
|
ipsec: Interfamily IPSec BEET
|
2008-08-06 02:39:30 -07:00 |
|
fib_frontend.c
|
netns: add namespace parameter to rt_cache_flush
|
2008-07-05 19:00:44 -07:00 |
|
fib_hash.c
|
netns: add namespace parameter to rt_cache_flush
|
2008-07-05 19:00:44 -07:00 |
|
fib_lookup.h
|
|
|
|
fib_rules.c
|
net: add fib_rules_ops to flush_cache method
|
2008-07-05 19:01:28 -07:00 |
|
fib_semantics.c
|
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
|
2008-06-13 20:52:39 -07:00 |
|
fib_trie.c
|
proc: consolidate per-net single-release callers
|
2008-07-18 04:07:44 -07:00 |
|
icmp.c
|
icmp: icmp_sk() should not use smp_processor_id() in preemptible code
|
2008-08-23 04:43:33 -07:00 |
|
igmp.c
|
netns: Fix crash by making igmp per namespace
|
2008-08-13 16:15:57 -07:00 |
|
inet_connection_sock.c
|
net: convert BUG_TRAP to generic WARN_ON
|
2008-07-25 21:43:18 -07:00 |
|
inet_diag.c
|
net: remove CVS keywords
|
2008-06-11 21:00:38 -07:00 |
|
inet_fragment.c
|
net: convert BUG_TRAP to generic WARN_ON
|
2008-07-25 21:43:18 -07:00 |
|
inet_hashtables.c
|
net: convert BUG_TRAP to generic WARN_ON
|
2008-07-25 21:43:18 -07:00 |
|
inet_lro.c
|
net/inet_lro: remove setting skb->ip_summed when not LRO-able
|
2008-06-27 20:09:00 -07:00 |
|
inet_timewait_sock.c
|
net: convert BUG_TRAP to generic WARN_ON
|
2008-07-25 21:43:18 -07:00 |
|
inetpeer.c
|
net: remove CVS keywords
|
2008-06-11 21:00:38 -07:00 |
|
ip_forward.c
|
mib: add net to IP_INC_STATS_BH
|
2008-07-16 20:20:11 -07:00 |
|
ip_fragment.c
|
net: convert BUG_TRAP to generic WARN_ON
|
2008-07-25 21:43:18 -07:00 |
|
ip_gre.c
|
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
|
2008-05-25 23:26:10 -07:00 |
|
ip_input.c
|
mib: put ip statistics on struct net
|
2008-07-18 04:02:42 -07:00 |
|
ip_options.c
|
net: remove CVS keywords
|
2008-06-11 21:00:38 -07:00 |
|
ip_output.c
|
net: convert BUG_TRAP to generic WARN_ON
|
2008-07-25 21:43:18 -07:00 |
|
ip_sockglue.c
|
net: remove CVS keywords
|
2008-06-11 21:00:38 -07:00 |
|
ipcomp.c
|
ipcomp: Fix warnings after ipcomp consolidation.
|
2008-07-27 03:59:24 -07:00 |
|
ipconfig.c
|
netns: Use net_eq() to compare net-namespaces for optimization.
|
2008-07-19 22:34:43 -07:00 |
|
ipip.c
|
net: remove CVS keywords
|
2008-06-11 21:00:38 -07:00 |
|
ipmr.c
|
netns: Use net_eq() to compare net-namespaces for optimization.
|
2008-07-19 22:34:43 -07:00 |
|
Kconfig
|
ipsec: ipcomp - Merge IPComp implementations
|
2008-07-25 02:54:40 -07:00 |
|
Makefile
|
|
|
|
netfilter.c
|
|
|
|
proc.c
|
tcp: MD5: Use MIB counter instead of warning for MD5 mismatch.
|
2008-07-30 03:27:25 -07:00 |
|
protocol.c
|
net: remove CVS keywords
|
2008-06-11 21:00:38 -07:00 |
|
raw.c
|
mib: add net to IP_INC_STATS
|
2008-07-16 20:19:49 -07:00 |
|
route.c
|
ipv4: Disable route secret interval on zero interval
|
2008-08-15 13:44:31 -07:00 |
|
syncookies.c
|
syncookies: Make sure ECN is disabled
|
2008-07-26 02:21:54 -07:00 |
|
sysctl_net_ipv4.c
|
net: Add missing extra2 parameter for ip_default_ttl sysctl
|
2008-08-03 14:06:44 -07:00 |
|
tcp.c
|
net: convert BUG_TRAP to generic WARN_ON
|
2008-07-25 21:43:18 -07:00 |
|
tcp_bic.c
|
|
|
|
tcp_cong.c
|
|
|
|
tcp_cubic.c
|
|
|
|
tcp_diag.c
|
net: remove CVS keywords
|
2008-06-11 21:00:38 -07:00 |
|
tcp_highspeed.c
|
|
|
|
tcp_htcp.c
|
|
|
|
tcp_hybla.c
|
|
|
|
tcp_illinois.c
|
|
|
|
tcp_input.c
|
net: convert BUG_TRAP to generic WARN_ON
|
2008-07-25 21:43:18 -07:00 |
|
tcp_ipv4.c
|
tcp: Fix kernel panic when calling tcp_v(4/6)_md5_do_lookup
|
2008-08-06 23:50:04 -07:00 |
|
tcp_lp.c
|
|
|
|
tcp_minisocks.c
|
tcp: (whitespace only) fix confusing indentation
|
2008-08-07 20:27:45 -07:00 |
|
tcp_output.c
|
tcp: Fix bitmask test in tcp_syn_options()
|
2008-07-21 18:45:34 -07:00 |
|
tcp_probe.c
|
tcp: correct kcalloc usage
|
2008-07-10 16:51:32 -07:00 |
|
tcp_scalable.c
|
|
|
|
tcp_timer.c
|
net: convert BUG_TRAP to generic WARN_ON
|
2008-07-25 21:43:18 -07:00 |
|
tcp_vegas.c
|
|
|
|
tcp_vegas.h
|
|
|
|
tcp_veno.c
|
|
|
|
tcp_westwood.c
|
|
|
|
tcp_yeah.c
|
|
|
|
tunnel4.c
|
[IPV4] TUNNEL4: Fix incoming packet length check for inter-protocol tunnel.
|
2008-06-05 04:02:33 +09:00 |
|
udp.c
|
udp: Drop socket lock for encapsulated packets
|
2008-08-09 00:35:05 -07:00 |
|
udp_impl.h
|
net: change proto destroy method to return void
|
2008-06-14 17:04:49 -07:00 |
|
udplite.c
|
mib: put udplite statistics on struct net
|
2008-07-18 04:03:45 -07:00 |
|
xfrm4_input.c
|
|
|
|
xfrm4_mode_beet.c
|
ipsec: Interfamily IPSec BEET
|
2008-08-06 02:39:30 -07:00 |
|
xfrm4_mode_transport.c
|
|
|
|
xfrm4_mode_tunnel.c
|
xfrm: fix fragmentation for ipv4 xfrm tunnel
|
2008-06-17 16:38:23 -07:00 |
|
xfrm4_output.c
|
|
|
|
xfrm4_policy.c
|
|
|
|
xfrm4_state.c
|
|
|
|
xfrm4_tunnel.c
|
|
|