Ard Biesheuvel
80b9d3becd
crypto: shash - avoid comparing pointers to exported functions under CFI
...
[ Upstream commit 22ca9f4aaf431a9413dcc115dd590123307f274f ]
crypto_shash_alg_has_setkey() is implemented by testing whether the
.setkey() member of a struct shash_alg points to the default version,
called shash_no_setkey(). As crypto_shash_alg_has_setkey() is a static
inline, this requires shash_no_setkey() to be exported to modules.
Unfortunately, when building with CFI, function pointers are routed
via CFI stubs which are private to each module (or to the kernel proper)
and so this function pointer comparison may fail spuriously.
Let's fix this by turning crypto_shash_alg_has_setkey() into an out of
line function.
Cc: Sami Tolvanen <samitolvanen@google.com>
Cc: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-07-14 16:53:13 +02:00
..
internal
crypto: shash - avoid comparing pointers to exported functions under CFI
2021-07-14 16:53:13 +02:00
acompress.h
crypto: api - check for ERR pointers in crypto_destroy_tfm()
2021-05-11 14:04:05 +02:00
aead.h
crypto: api - check for ERR pointers in crypto_destroy_tfm()
2021-05-11 14:04:05 +02:00
aes.h
crypto: aes - helper function to validate key length for AES algorithms
2019-08-09 15:11:43 +10:00
akcipher.h
crypto: api - check for ERR pointers in crypto_destroy_tfm()
2021-05-11 14:04:05 +02:00
algapi.h
crypto: api - Remove redundant #ifdef in crypto_yield()
2019-08-02 14:45:13 +10:00
arc4.h
crypto: arc4 - refactor arc4 core code into separate library
2019-06-20 14:18:33 +08:00
asym_tpm_subtype.h
authenc.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
b128ops.h
blowfish.h
cast5.h
cast6.h
crypto: x86 - Regularize glue function prototypes
2021-03-20 10:39:47 +01:00
cast_common.h
cbc.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
chacha.h
crypto: chacha - constify ctx and iv arguments
2019-06-13 14:31:40 +08:00
cryptd.h
ctr.h
crypto: ctr - add helper for performing a CTR encryption walk
2019-07-26 14:56:07 +10:00
des.h
crypto: des - remove now unused __des3_ede_setkey()
2019-08-22 14:57:33 +10:00
dh.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
drbg.h
ecdh.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
engine.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
gcm.h
crypto: gcm - helper functions for assoclen/authsize check
2019-08-09 15:11:41 +10:00
gf128mul.h
ghash.h
crypto: ghash - add comment and improve help text
2019-07-27 21:08:38 +10:00
hash.h
crypto: api - check for ERR pointers in crypto_destroy_tfm()
2021-05-11 14:04:05 +02:00
hash_info.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
hmac.h
if_alg.h
crypto: algif_aead - Only wake up when ctx->more is zero
2020-08-21 13:05:30 +02:00
kpp.h
crypto: api - check for ERR pointers in crypto_destroy_tfm()
2021-05-11 14:04:05 +02:00
md5.h
nhpoly1305.h
null.h
padlock.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
pcrypt.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335
2019-06-05 17:37:06 +02:00
pkcs7.h
PKCS#7: Introduce pkcs7_get_digest()
2019-08-05 18:40:19 -04:00
poly1305.h
public_key.h
rng.h
crypto: api - check for ERR pointers in crypto_destroy_tfm()
2021-05-11 14:04:05 +02:00
scatterwalk.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
serpent.h
crypto: x86 - Regularize glue function prototypes
2021-03-20 10:39:47 +01:00
sha.h
crypto: sha256 - Remove sha256/224_init code duplication
2019-09-05 14:54:54 +10:00
sha1_base.h
crypto: add header include guards
2019-08-02 14:44:02 +10:00
sha3.h
sha256_base.h
crypto: sha256 - Remove sha256/224_init code duplication
2019-09-05 14:54:54 +10:00
sha512_base.h
crypto: add header include guards
2019-08-02 14:44:02 +10:00
skcipher.h
crypto: api - check for ERR pointers in crypto_destroy_tfm()
2021-05-11 14:04:05 +02:00
sm3.h
sm3_base.h
crypto: add header include guards
2019-08-02 14:44:02 +10:00
sm4.h
streebog.h
twofish.h
xts.h
crypto: x86 - Regularize glue function prototypes
2021-03-20 10:39:47 +01:00