android_kernel_motorola_sm6375/net/ncsi
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Paul Fertser 70dc66d0cb net/ncsi: wait for the last response to Deselect Package before configuring channel
commit 6bb194d036c6e1b329dcdff459338cdd9a54802a upstream.

The NCSI state machine as it's currently implemented assumes that
transition to the next logical state is performed either explicitly by
calling `schedule_work(&ndp->work)` to re-queue itself or implicitly
after processing the predefined (ndp->pending_req_num) number of
replies. Thus to avoid the configuration FSM from advancing prematurely
and getting out of sync with the process it's essential to not skip
waiting for a reply.

This patch makes the code wait for reception of the Deselect Package
response for the last package probed before proceeding to channel
configuration.

Thanks go to Potin Lai and Cosmo Chou for the initial investigation and
testing.

Fixes: 8e13f70be0 ("net/ncsi: Probe single packages to avoid conflict")
Cc: stable@vger.kernel.org
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Link: https://patch.msgid.link/20250116152900.8656-1-fercerpav@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-03-13 12:43:11 +01:00
..
internal.h net/ncsi: Fix netlink major/minor version numbers 2024-01-25 14:34:25 -08:00
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
ncsi-aen.c Revert ncsi: Propagate carrier gain/loss events to the NCSI controller 2023-11-28 16:50:21 +00:00
ncsi-cmd.c net/ncsi : Add payload to be 32-bit aligned to fix dropped packets 2021-12-01 09:23:33 +01:00
ncsi-manage.c net/ncsi: wait for the last response to Deselect Package before configuring channel 2025-03-13 12:43:11 +01:00
ncsi-netlink.c net/ncsi: Fix netlink major/minor version numbers 2024-01-25 14:34:25 -08:00
ncsi-netlink.h net/ncsi: Fix netlink registration 2020-11-24 13:29:00 +01:00
ncsi-pkt.h net/ncsi: Fix netlink major/minor version numbers 2024-01-25 14:34:25 -08:00
ncsi-rsp.c net/ncsi: Fix netlink major/minor version numbers 2024-01-25 14:34:25 -08:00